Comments (5)
Ah okay, got your point now.
from fava_investor.
Yes, that's the idea: the fava_investor modules themselves should be agnostic to whether they are being called with beancount or fava underneath. The APIs abstract this out for them. This way, they can be called through a CLI without fava, or through fava, and they'll happily work with either. They'll never know if the API layer is using beancount or fava underneath. Does this explanation make sense?
(Note: beancountinvestorapi.root_tree()
is the only hack I've temporarily put in that goes against this. I'll remove it once I figure out assetalloc_account
which is a WIP.)
from fava_investor.
I don't understand what value it provides.
Our modules will depend of fava and/or beancount anyway as APIs' methods are returning data structures defined in beancount and fava. There is still coupling there. Logic in our modules (that is processing entries in journal for example) is still relying on beancount's Transaction, Posting, addition of Inventories, etc. That coupling will break them if beancount's code is changed in the future and API classes doesn't seem to help with that.
from fava_investor.
How would you rewrite libtlh.py
to simultaneously work as a) a library without fava dependency (so you can call it from a CLI), and b) usable with a fava context?
BTW, insulation from fava/beancount code is not the goal. We will depend on them heavily and always. The goal is agnosticism to one vs. the other.
from fava_investor.
Cool. Also: I'm okay moving forward with code that is fava-specific, deferring the goal of making it work with beancount as well. As an example, your balance module uses a fava-specific tree structure which makes it a bit difficult to get it to work without fava. I'm okay with this for now. There is a reason this is called "fava_investor" - fava is primary compared to the library/CLI targets.
Bottomline: please don't worry about the library/CLI aspect of your module for now.
from fava_investor.
Related Issues (20)
- Postive amounts of non-monetary commodities crash aa_class HOT 5
- Incorrect proceeds because sale price not used HOT 3
- Fava Investor won't load HOT 3
- Function get_account_open in favainvestorapi.py returns an empty list HOT 3
- Incorrect allocation percentage computation in "Asset Allocation Accounts" HOT 4
- Fava QueryShell Change HOT 5
- Need a good example.beancount that demonstrates all modules
- [Feature] Write errors to GUI callout instead of exiting HOT 3
- [Feature] Sum up allocation sub classes HOT 3
- [Feature] Allow filtering for accounts HOT 1
- [Feature] Use implicit prices HOT 2
- [Feature] Asset allocation tools
- Fava investor tab fails to load HOT 8
- Asset Allocation Classes-- TypeError: unsupported operand type(s) for /: 'str' and 'int' HOT 3
- Asset Allocation by Class does not convert prices transitively HOT 3
- New fava version breaks fava-investor HOT 3
- Fava 1.26.2 breaks fava _investor HOT 3
- Asset allocation display is broken in Fava 1.25 onwards
- cannot import name 'cost_or_value' from 'fava.template_filters' HOT 3
- Multicurrency Asset Allocation in Fava HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fava_investor.