Giter VIP home page Giter VIP logo

Comments (4)

aclindsa avatar aclindsa commented on September 11, 2024

I've skimmed through the commit messages between fava v1.18 and master and nothing immediately sticks out at me as a potential reason for this breakage. I can attempt to git bisect to find where the breakage occurs if I have time in the next few days.

from fava_investor.

aclindsa avatar aclindsa commented on September 11, 2024

My git bisect says this is the fava commit which introduced the breakage: beancount/fava@287fe97

Posting here in case you have insights to point me in the right direction. I'll keep looking into it as I have time.

from fava_investor.

aclindsa avatar aclindsa commented on September 11, 2024

Looks like they modified their querytable macro, breaking fava_investor's usage of it. I've made a PR, which appears to allow fava_investor to work both with the latest upstream fava and with fava 1.18: #58

@redstreet Let me know how this solution looks to you.

from fava_investor.

redstreet avatar redstreet commented on September 11, 2024

Looks great. Thanks for catching this and the PR. Merging. However, I'll wait to release a pip version until the next version of fava is released, so we have confirmation that the querytable change indeed made it through.

from fava_investor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.