r_wrist frame typo about nao_robot HOT 6 CLOSED

@suryaambrose, @lsouchet, please confirm / infirm.

from nao_robot.

Please note that the V32 values are fine but 33/40/50 have the same typo.

from nao_robot.

I confirm the typo, I found the same inside aldebaran's library from which the urdf files are generated.
Now that I fixed it there, I suppose generating the urdf files again should propagate the fix to ros.

from nao_robot.

@sbarthelemy thx. Can you please send me the newly generated URDFs so that I fix that bug ? Thx. Otherwise, you can make a PR yourself using those instructions: https://github.com/ros-naoqi/naoqi_bridge/blob/master/naoqi_tools/scripts/README_generate_urdf.py.rst

from nao_robot.

btw, @letrend , how did you find that bug ? did it impact any of your experiments ?

from nao_robot.

@vrabaud
jup, made transformations from gripper to torso frame impossible.
at first this seemed to solve our issues, but we noticed that the coordinate frame of the right gripper was still weiredly twisted. So there might still be something wrong about the coordinate frames. we couldnt figure out what, however.
eventually we used visual tracking of the endeffectors to compensate for this.

from nao_robot.