Compile error - cannot "make" due to problem with ffindex.c about hh-suite HOT 6 CLOSED

Mac users can not compile HH-suite at the moment. This bug has todo with ffindex commit soedinglab/ffindex_soedinglab@360e417. @meiermark should we rollback it back?

from hh-suite.

Thank you for the reformatting and quick reply! I have an update that may or may not be relevant to the issue with the ffindex.c file, but hopefully will help others with my Open MP issue. Running cmake as written in your readme instructions plus the option: "-DCMAKE_CXX_COMPILER=gcc-7" seems to fix it. (Total command line: cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -G "Unix Makefiles" -DCMAKE_INSTALL_PREFIX=/usr/local/ -DCMAKE_CXX_COMPILER=gcc-7 ..)

Also, regarding the ffindex problem: I realized my initial issue post did not include this other warning that I got while running cmake (and still do even with successful Open MP)

CMake Warning (dev):
Policy CMP0042 is not set: MACOSX_RPATH is enabled by default. Run "cmake
--help-policy CMP0042" for policy details. Use the cmake_policy command to
set the policy and suppress this warning.

MACOSX_RPATH is not specified for the following targets:

ffindex_shared

Could that be part of the issue?

from hh-suite.

the commit that caused the problems with mac clang is now reverted.
does the problem persist?

from hh-suite.

Unfortunately no... it got a lot further.. but now there's a new issue. Before it stopped at make [ 3% ], this time it got to around [66%] before throwing up warnings. It kept going for a little while but this is the ultimate output / error message:

ld: symbol(s) not found for architecture x86_64
collect2: error: ld returned 1 exit status
make[2]: *** [bin/hhblits_mpi] Error 1
make[1]: *** [src/CMakeFiles/hhblits_mpi.dir/all] Error 2
make: *** [all] Error 2

The whole output was really long so I've attached a .txt file of it with my command line input / output from cmake to make.
cmake-output_6.9.17-1513.txt

from hh-suite.

Never mind!! I used a different compiler for cmake command (x86_64-apple-darwin15.6.0-c++7) and it worked! Successful installation, can run hhsearch/etc from my shell. Thank you so much!!

from hh-suite.

I encounter the same error with ffindex.c during make:

Error after cmake and make:
->cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -G "Unix Makefiles" -DCMAKE_INSTALL_PREFIX=${INSTALL_BASE_DIR} -DCMAKE_CXX_COMPILER=gcc-7 ..
->make
Scanning dependencies of target ffindex
[ 1%] Building C object lib/ffindex/src/CMakeFiles/ffindex.dir/ffindex.c.o
/Users/luc/Applications/hh-suite/lib/ffindex/src/ffindex.c:526:3: error: function definition is not allowed here
{
^
/Users/luc/Applications/hh-suite/lib/ffindex/src/ffindex.c:542:27: warning: incompatible pointer types passing 'void
(const void *, const VISIT, const int, void )' to parameter of type 'void ()(const void *, VISIT, int)'
[-Wincompatible-pointer-types]
twalk(index->tree_root, action);
^~~~~~
/usr/include/search.h:59:34: note: passing argument to parameter here
void twalk(const void , void ()(const void *, VISIT, int));
^
1 warning and 1 error generated.
make[2]: *** [lib/ffindex/src/CMakeFiles/ffindex.dir/ffindex.c.o] Error 1
make[1]: *** [lib/ffindex/src/CMakeFiles/ffindex.dir/all] Error 2
make: *** [all] Error 2

I have tried different compliers for cmake command including c++-7, g++-7, gcc-7 and x86_64-apple-darwin17.3.0-c++-7, the same error persists;
my gcc is version 7.3.0, and my cmake is 3.10.2.

I am building hhsuit for the first time, and I am sorry if I miss something obvious... any help is appreciated!!

from hh-suite.