Giter VIP home page Giter VIP logo

Comments (9)

croth1 avatar croth1 commented on July 18, 2024

ping @meiermark, @martin-steinegger

from hh-suite.

martin-steinegger avatar martin-steinegger commented on July 18, 2024

As you metioned already correctly you need to alter two files to add the support. You need to check for POWER8 in CheckSSEFeatures.cmake and add all needed compiler flags to the SSE_FLAGS variable. After this you have to add the VSX intrinsics to the simd.h power8 code path. We sadly can't help you with that, since none here has any expertise with POWER.

from hh-suite.

danparrot avatar danparrot commented on July 18, 2024

Got CMake to run to completion. That's good. But, make then chokes. Not so good. The reason is that PowerPC vector intrinsics are not quite 1-to-1 with intel intrinsics.
Question: Is there a regression test to ensure that changes to codebase meet some minimum correctness?

from hh-suite.

martin-steinegger avatar martin-steinegger commented on July 18, 2024

We dont have regression tests. We normally benchmark our software before we release it. Maybe we can give you our benchmark set and you can run it. Does HHblits produces the sames scores as on an SSE machine?

from hh-suite.

danparrot avatar danparrot commented on July 18, 2024

Any of set of tests that will verify functionality after replacing Intel with PowerPC intrinsics will be sufficient. If you provide instructions on where to obtain and how to run the tests, the changes should be completed in a day or so.

from hh-suite.

martin-steinegger avatar martin-steinegger commented on July 18, 2024

Did you finish the PowerPC implementation? @meiermark can you make the benchmark set and scripts for the fold regonition test available for danparrot?

from hh-suite.

meiermark avatar meiermark commented on July 18, 2024

Sure. The corresponding private bitbucket repository is still under development.
How may I invite you?

from hh-suite.

kWeissenow avatar kWeissenow commented on July 18, 2024

Do I understand it correctly that 3342110 essentially discontinued David Miller's ppc64le support? We're trying to build the most recent hh-suite on an IBM AC922, but cmake complains about SSE2 missing. The architecture-specific definitions in src/simd.h are still there, however.

from hh-suite.

milot-mirdita avatar milot-mirdita commented on July 18, 2024

Could you make a new issue please?
We don't have any PPC systems and last time I checked there were no free continuous integration solutions for PPC. I am not sure how to keep the PPC build from not breaking without having a CI system, so I am also not very happy about maintaining PPC support.

from hh-suite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.