Comments (4)
Hello @ctf0,
I'm not sure if I understand your usecase, but can you try using cancelOnUserAction: false
?
from animated-scroll-to.
using cancelOnUserAction: false
means that why the user try to scroll while the lib is working he wont be able to cancel the scrolling.
what the PR is for is basically add an option to decide whether using the keyboard keys will disable the scrolling or not.
this opens the way to use keydown events with keys like right,left,top,bottom, etc..
to trigger the scroll
also it wont cuz any breakage to anyone.
from animated-scroll-to.
Sorry, but I still don't understand, as cancelOnUserAction
does exactly what you described:
what this pr is for is basically add an option to decide whether using the keyboard keys will disable the scrolling or not.
Can you please create a simple example on https://codesandbox.io/ or https://codepen.io/
Sorry for the inconvenience but I'm trying hard not to bloat this library. Thank you!
from animated-scroll-to.
its okay, np, can u plz first take a look at the cancelOnUserAction
in the lib
animated-scroll-to/animated-scroll-to.js
Line 159 in a163140
using the option will disable those 2 events, while i only want to disable/enable the keydown
event
btw all i added to the PR is an extra config and a condition based on it, thats it.
from animated-scroll-to.
Related Issues (20)
- Can you update the CHANGELOG.md for v2? HOT 1
- V2 - Cannot find module 'animated-scroll-to' from 'scrollTo.js' HOT 1
- Switching to commonjs instead of es2015 HOT 2
- v2 breaks SSR apps HOT 4
- Typescript typings are out of date and not stored in the the repo HOT 6
- can you remove comment script tag HOT 4
- Compatible with react HOT 9
- Limit scroll directions HOT 1
- No trigger HOT 4
- OnComplete option is not available since v2 HOT 4
- Remove "@types/node" dependency
- Compile Error on node 14 HOT 3
- wrong dependency? HOT 3
- Add note about scroll-behaviour: smooth to readme HOT 3
- [Feature] Add support for iframe contentWindow HOT 1
- It don't work on my mobile applications HOT 4
- Set default options during import HOT 4
- Using with Typescript and useRef hook throws a type error HOT 2
- [feature] add support for scroll-to element and locate it from bottom HOT 1
- Speed can't be changed HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from animated-scroll-to.