Giter VIP home page Giter VIP logo

Comments (4)

Stanko avatar Stanko commented on July 20, 2024

Hello @ctf0,
I'm not sure if I understand your usecase, but can you try using cancelOnUserAction: false?

from animated-scroll-to.

ctf0 avatar ctf0 commented on July 20, 2024

using cancelOnUserAction: false means that why the user try to scroll while the lib is working he wont be able to cancel the scrolling.

what the PR is for is basically add an option to decide whether using the keyboard keys will disable the scrolling or not.

this opens the way to use keydown events with keys like right,left,top,bottom, etc.. to trigger the scroll

also it wont cuz any breakage to anyone.

from animated-scroll-to.

Stanko avatar Stanko commented on July 20, 2024

Sorry, but I still don't understand, as cancelOnUserAction does exactly what you described:

what this pr is for is basically add an option to decide whether using the keyboard keys will disable the scrolling or not.

Can you please create a simple example on https://codesandbox.io/ or https://codepen.io/

Sorry for the inconvenience but I'm trying hard not to bloat this library. Thank you!

from animated-scroll-to.

ctf0 avatar ctf0 commented on July 20, 2024

its okay, np, can u plz first take a look at the cancelOnUserAction in the lib

if (options.cancelOnUserAction) {

using the option will disable those 2 events, while i only want to disable/enable the keydown event

btw all i added to the PR is an extra config and a condition based on it, thats it.

from animated-scroll-to.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.