Comments (5)
Published in v1.3.0 🎉 onComplete
now receives a boolean argument isCanceledByUserAction
from animated-scroll-to.
Hey @mciastek,
You are correct, it doesn't get called in that scenario. I thought about it for a while, and I think better solution would be to add a new property onUserCancelation
(name is open for suggestion 🙈).
Honestly I never run into scenario where I needed that.
What do you think?
EDIT: It could be added here:
https://github.com/Stanko/animated-scroll-to/blob/master/animated-scroll-to.js#L140-L143
from animated-scroll-to.
Hi @Stanko! Thanks for responding to my issue!
Honestly, I'm not sure if I need to know if scroll animation has been interrupted by user or not. I would prefer having only one callback which tells me that animation ended. Simple as that. If such information is required I would add an argument to onComplete
callback, which tells you if animated has been ended before it's done. What do you think about it?
from animated-scroll-to.
It probably makes sense to have one callback, and pass a boolean argument to it canceled
. I'll create a change soon.
from animated-scroll-to.
Great! I'm happy to help with PR if needed.
from animated-scroll-to.
Related Issues (20)
- Can you update the CHANGELOG.md for v2? HOT 1
- V2 - Cannot find module 'animated-scroll-to' from 'scrollTo.js' HOT 1
- Switching to commonjs instead of es2015 HOT 2
- v2 breaks SSR apps HOT 4
- Typescript typings are out of date and not stored in the the repo HOT 6
- can you remove comment script tag HOT 4
- Compatible with react HOT 9
- Limit scroll directions HOT 1
- No trigger HOT 4
- OnComplete option is not available since v2 HOT 4
- Remove "@types/node" dependency
- Compile Error on node 14 HOT 3
- wrong dependency? HOT 3
- Add note about scroll-behaviour: smooth to readme HOT 3
- [Feature] Add support for iframe contentWindow HOT 1
- It don't work on my mobile applications HOT 4
- Set default options during import HOT 4
- Using with Typescript and useRef hook throws a type error HOT 2
- [feature] add support for scroll-to element and locate it from bottom HOT 1
- Speed can't be changed HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from animated-scroll-to.