Giter VIP home page Giter VIP logo

Comments (5)

syoyo avatar syoyo commented on July 28, 2024

You need to show the line

from tinyobjloader-c.

nashidau avatar nashidau commented on July 28, 2024

There is no line for the leak. The problem is in the file reader buf is allocated and passed back in. But it isn't freed.
I think a better fix is to add a context pointer to the file reader. Then caller can clean up after.

from tinyobjloader-c.

syoyo avatar syoyo commented on July 28, 2024

@nashidau Thanks for the detailed information. App user need to explicitly manage the pointer to buf(since there is no free when the memory is allocated with mmap).

At least I need to add freeing pointer code in example/viewer example and describe how to manage memory in README.

I think a better fix is to add a context pointer to the file reader

Yes, this is the best way to fix. I'll do that.

from tinyobjloader-c.

nashidau avatar nashidau commented on July 28, 2024

I jus tmade a pull request that adds it.

from tinyobjloader-c.

syoyo avatar syoyo commented on July 28, 2024

@nashidau 👍

PR #46 has been merged so close the issue.

from tinyobjloader-c.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.