telly / tlyshynavbar Goto Github PK

self.shyNavBarManager.scrollView = self.tableView;
            UIView *eView = [[UIView alloc] initWithFrame:CGRectMake(0, 0, self.view.frame.size.width, 100)];
[eView addSubview:self.calendarMenuView];
[eView addSubview:self.calendarContentView];
[self.shyNavBarManager setExtensionView:eView];

This is what I am working with. I have my tableview set up exactly as your scrollview in the demo. The delegate is setup in the storyboard as well. I have tried putting this in my viewDidLoad and viewDidAppear. The UITableView moves but the extension and navBar do not move at all. I am importing <TLYShyNavBar/TLYShyNavBarManager.h> in the header file so I can access the shyNavBarManager. Still nothing

Hello, I am using component on view with tableview witch have refresh control, searchbar in header, sections and index bar.
The issue is that table header goes under white gap when nav bar scrolls up, the sections issue that they stop under standart navigation bar place.
Wich solution can I use here?

Thank you!

Not sure if i'm doing something wrong but easy way to reproduce:

1. Have a tableview where the contentsize is smaller than the height.
2. Contentsize should be large enough such that when the keyboard appears the tableview can scroll up. 3. Scroll the tableview content so that the status bar shrinks
3. dismiss the keyboard, now the tableview will look how it did in step 1 but the status bar will still be shrunk and there will be a space between the shrunk status bar and the topmost cell.

Another way to reproduce:

1. Have a tableview where the contentsize is larger than the tableview height.
2. Scroll the tableview content so that the status bar shrinks
3. Delete a tableview cell so that the contentsize is now smaller than the tableview height.
4. same scenario as in the previous situation. status bar will still be shrunk and there will be a space between the status bar and the topmost cell.

Gonna guess the status bar height is determined by scroll events but doesn't get updated when the scrollview height changes.

As we make a hotspot connecting, a blue toolbar, which height is 20, will appear on the top of screen. I found 2 problems with this situation.

1.TLYShyNavBar's height become larger.
2.The connected scrollview and extensionview can't be adaptive.

Hello,
Really great library, like it.
But it have problems with status bar when in-call or other status bars like this.
http://www.screencast.com/t/6q0CJpNHT.
How to avoid them?
Thanks!

In iOS 7 the library functions without a problem both on simulator and device -- however, when I switch to iOS 8 on the simulator, I get the below error. I do not receive the error on a physical iOS 8 device.

This error occurs when trying to go back from any pushed VC that has ShyNavBar enabled using
self.shyNavBarManager.scrollView = self.tableView;

*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 
'*** -[NSProxy doesNotRecognizeSelector:_accessibilityValueForKey:] called!'
*** First throw call stack:
(
    0   CoreFoundation                      0x000000010b0793f5 __exceptionPreprocess + 165
    1   libobjc.A.dylib                     0x000000010ad12bb7 objc_exception_throw + 45
    2   CoreFoundation                      0x000000010b07932d +[NSException raise:format:] + 205
    3   CoreFoundation                      0x000000010afd87fc ___forwarding___ + 988
    4   CoreFoundation                      0x000000010afd8398 _CF_forwarding_prep_0 + 120
    5   UIKit                               0x000000011b492daf -[UIScrollViewAccessibility _axCleanupDelegateClearer] + 89
    6   UIKit                               0x000000011b492cd6 -[UIScrollViewAccessibility clearDelegateClearer] + 30
    7   UIKit                               0x000000011b492fde -[UIScrollViewAccessibility setDelegate:] + 36
    8   UIKit                               0x0000000108d44e73 -[UITableView setDelegate:] + 122
    9   MyApp                          0x0000000107018f17 -[TLYShyNavBarManager dealloc] + 215
    10  libobjc.A.dylib                     0x000000010ad2728e _ZN11objc_object17sidetable_releaseEb + 236
    11  libobjc.A.dylib                     0x000000010ad15426 _object_remove_assocations + 410
    12  libobjc.A.dylib                     0x000000010ad1f9be objc_destructInstance + 109
    13  libobjc.A.dylib                     0x000000010ad1f9e4 object_dispose + 22
    14  UIKit                               0x0000000108dd91ba -[UIResponder dealloc] + 90
    15  UIKit                               0x0000000108d86353 -[UIViewController dealloc] + 1899
    16  UIKit                               0x0000000108c5994d __destroy_helper_block_114 + 93
    17  libsystem_sim_blocks.dylib          0x000000010ba54734 _Block_release + 196
    18  UIKit                               0x0000000108cd480d -[UIViewAnimationBlockDelegate dealloc] + 63
    19  libobjc.A.dylib                     0x000000010ad2728e _ZN11objc_object17sidetable_releaseEb + 236
    20  CoreFoundation                      0x000000010af50d2b CFRelease + 603
    21  CoreFoundation                      0x000000010af8593d -[__NSDictionaryI dealloc] + 125
    22  libobjc.A.dylib                     0x000000010ad2728e _ZN11objc_object17sidetable_releaseEb + 236
    23  libobjc.A.dylib                     0x000000010ad278cd _ZN12_GLOBAL__N_119AutoreleasePoolPage3popEPv + 591
    24  CoreFoundation                      0x000000010af70346 _CFAutoreleasePoolPop + 22
    25  CoreFoundation                      0x000000010afa4473 __CFRunLoopRun + 2051
    26  CoreFoundation                      0x000000010afa3a06 CFRunLoopRunSpecific + 470
    27  GraphicsServices                    0x000000010cb0f9f0 GSEventRunModal + 161
    28  UIKit                               0x0000000108c63550 UIApplicationMain + 1282
    29  MyApp                          0x0000000106eaae03 main + 115
    30  libdyld.dylib                       0x000000010ba09145 start + 1
    31  ???                                 0x0000000000000001 0x0 + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

Thanks for your wonderful library.

I'm trying to hide NavigationController with this library but it's not working. I think that causes my ViewController is a little complicated.
My viewController extend AXStretchableHeaderTabViewController library whose structure is like below.

Stretchable HeaderView
|
ParentContainerViewController
|
|-- FirstSubViewController (CollectionView)
|-- SecondSubViewController (TableView)
|-- ThirdSubViewController(TableView)

ParentContainerView extends AXStretchableHeaderTabViewController and has UIScrollView as ContainerView. I try to set it like "self.shyNavBarManager.scrollView = self.containerView;" but not working also " [self.shyNavBarManager setExtensionView:stretchableheaderView Instance];" is not working.Even when I doing that in SubViewController, it was not working.

As if it is scrolling in SubViewController, I can not get scroll delegate in ParentContainer otherwise can not get navigationController and Navbar in SubViewController.

I saw your code but it's tough to find which part is not workig for me in my poor skill.
If you have any idea, could you let me know what's wrong?

Thanks!

After adding shyNavBarManager, i.e. adding the following line:

self.shyNavBarManager.scrollView = self.tableView;

Everything works perfect, except that the UIRefreshControl is not behaving normally: It is flickery, only shows a "crosshair" while dragging down, and disappears when let go at refreshing position. See attached gif.

I have initially implemented everything with UITableViewController, hit the bug of extension view not fixed (#1), and then migrated everything to UIViewController. Therefore I can verify that this bug exists in both UIViewController and UITableViewController.

FYI, here is the code I wrote to add UIRefreshControl

UIRefreshControl *refreshControl = [[UIRefreshControl alloc] init];
[refreshControl addTarget:self action:@selector(refresh)
         forControlEvents:UIControlEventValueChanged];
self.refreshControl = refreshControl;
[self.tableView addSubview:self.refreshControl];

I have been using a local fork of ShyNavBar for some time. Today I tried to use 0.9.7 and noticed that the navbar never hides. I'm probably missing something, but I need some help finding out what...

I found out that self.isViewControllerVisible is false in _shouldHandleScrolling.
This is because prepareForDisplay is never getting called because _internalShyNavBarManager returns NULL.

- (void)tly_swizzledViewWillAppear:(BOOL)animated
{
    NSLog(@"OBJECT: %@", [self _internalShyNavBarManager]);
    [[self _internalShyNavBarManager] prepareForDisplay];
    [self tly_swizzledViewWillAppear:animated];
}

Outputs OBJECT: (null)

I am developing a chat application where I set the content offset programmatically when inserting new rows in chat table view.

TLYShyNavBar trigger when this happens and shortly contracts the navigation bar. Is there a way to solve this?

For instance, temporarily disable ShyNavBar while programmatically changing the content offset or make it trigger only when the user is scrolling.

I made a simple project with a UIViewController with a UITableView inside it. By default, it all works fine. Changing the translucent property of the navigation bar to NO however causes some issues. It seems the reason is this component depends on a translucent bar as it only adjusts the content inset of the scroll view (and a scrollview with a non translucent bar doesn't use this functionality since there is no hidden portion). When the navigation bar hides, it leaves a blank space in its place since the underlying view does not actually extend underneath it.

Sample project here: http://cl.ly/2D2F090o2I3d

Wondering if there is a straightforward way to solve this.

The way I have solved it in my app for the short term is as follows:

1. manually extend the frame of the scroll view underneath the nav bar (so decreasing origin.y and increasing size.height both by the height of the navigation bar)
2. overriding topLayoutGuide to return a custom object with length being the height of the navigation bar so TLYShyNavBar can use that value as if the navigation bar is transparent without knowing or caring that it isn't.

This solution is working for me at the moment and behaves smoothly but has a few issues. First off, I don't see a way of easily extending this functionality into the component. The second is that overriding the layout guide seems to actually be unsupported behavior and although it is working for me, can cause some issues with autolayout, as shown here.

What do you think?

 self.navigationController?.navigationBar.barTintColor = UIColor(red:241/255, green:48/255, blue:29/255, alpha:1)
        self.navigationController?.navigationBar.translucent = false

I'm setting my bartintcolor in my view controller and I got this weird black background when I scroll down.

Thanks for sharing this wonderful project for us,I tried today,and I found a bug.
Open app,push a view controller,scroll down to the bottom,nav bar hidden,then swip from left edge to right, so it will pop to show parent view controller,then It gets a exc_bad_access error.

When in-call or tethering, the margins aren't quite correct for both shyNavBar states. For my UITableView-embedded UIViewControllers the hidden state remains 20px, and isn't pushed behind the 40px status bar. In addition, after revealing the shyNavBar, the navigation bar grows to 62px (the 20px appendage on the double status bar remains below it). When the content in my scroll view is not pushaway-scrollable (smaller than the frame), the small contraction when bouncing it offsets the navigation bar behind the status bar, as well.

I'm not certain if every one of these issues is completely attributable to TLYShyNavBar, but I'm certain at least the first and mutations of the rest are likely to exist in other apps. If these results are intentional, please let me know if there's something else I should do with the view controller to make the presentation less intrusive.

I'd love to use TLYShyNavBar, but it doesn't seem to support extension views when auto layout is enabled. TLYShyViewController.updateYOffset is using self.view.center = ... to move the view which very quickly gets overridden by the auto layout engine. Another project mentioned on your project page, https://github.com/andreamazz/AMScrollingNavbar, seems to have a solution for this using [self followScrollView:self.scrollView usingTopConstraint:self.topLayoutConstraint];. Would it be possible to add a similar solution to this project?

Hi
First of all great project, very elegant compared to most of the other solutions!
I've been playing with using it with UICollectionViewControllers within a UIPageViewController - when the 'page' is changed to a new UICollectionViewController, I set self.shyNavBarManager.scrollView to collectionViewController.collectionView.
It works fairly well, but randomly crashes with EXC_BAD_ACCESS on the TLYDelegateProxy property originalDelegate during what appears to be a call to respondsToSelector. originalDelegate isn't nil, and as the collectionView has no delegate set by me the originalDelegate is a TLYDelegateProxy too.

Secondly, but far less important - when 'paging' to a new UICollectionViewController and setting shyNavBarManager.scrollView, the contentOffset isn't applied to the new scrollView. I'm guessing this could be solved fairly easily - may make a pull request if you don't mind :)

Thanks for sharing your work!

Hello,

Thank you so much for creating this component. The "shy" nav bar has become a very common UX practice and it's incredibly helpful to have component like this that just works out of the box.

I have a table view which is using the shy nav bar. When there are "new items" available, a red alert label is shown in the nav bar to take them up to the top and see the new items. This works great if the user actually sees the button, but if they are scrolling down they may not. What I'd like to be able to do is force the nav bar to stay visible (ie, not contract on scroll) when new items are present, and be "shy" and work as normal otherwise.

I've looked through the source and I can't seem to find any methods to toggle this behavior. Am I just missing it? If not, would this be something you'd consider adding?

Thanks!

• Leland

Im using TLYShyNavBar in UITableViewController. I have an InputAccessoryView with a UITextView inside. When UITextView is tapped, keyboard appears. This causes hidden navBar to be drawn on top of the keyaboard, incorrectly.

How can I manually show and hide the bar, so that when keyboard appears I can be able to hide the navbar.

thanks

Hey again! We've been messing around with this project and I seem to have found a few funny cases.

Using a barebones UITableViewController causes the component not to work. I uploaded my sample project showcasing this: http://cl.ly/3d3A3W3b3W0u

Along with the navigation bar never hiding, if you scroll to the bottom of the table and bounce, it causes the whole table to jump up a bit leaving some whitespace at the bottom.

Not a big deal but was just wondering if you were aware of this issue.

There should be a public way to control the effects applied to the navbar as it disappears. At the very least, a way to disable/enable the alpha fade. (This is particularly important in cases where the navbar is a custom view)

When scrolling to the top of a UITableView with a reasonable amount of force, the extension view would sometimes flicker. I have attached a video of what I'm seeing via Dropbox:

https://dl.dropboxusercontent.com/u/1319151/Screencast.mov

Any ideas?

Use Case:
My Extension view contains a toggle that I use to switch between two content scroll views. Both scroll views should appear just below my extension view, however when I toggle between them (and assign the newly visible scroll view to the shy nav bar), the content insets of the new scroll view are not updated according to the height of the extension view.

In an attempt to fix this I have exposed the layoutViews method in my client code, so that I can invoke it when I swap the scrollViews, however the content inset of the new scroll view is not set because UIEdgeInsetsEqualToEdgeInsets(scrollInsets, self.previousScrollInsets) causes the method to return. Setting previousScrollInsets to UIEdgeInsetsZero prior to this seems to do it, however it feels like a hacky solution so would like to raise this so that a proper fix can be devised.

Current version is 0.9.7, but version in cocoapods repo is 0.9.2. Outdated.
Please, update it.

Hello,

_Update, I've narrowed down the cause of the issue, please scroll to stars to see_

I have a UIViewController embedded in a navigation controller. Not sure if this is relevant, but a tabBarController is my root view controller.

Anyways I setup the shynavbarcontroller per the quick setup in viewDidLoad and set a tableView as the scrollview. This code comes after functions thats setup the tableview and add it as a subview to the view controller.

I also created an extension view similar to the example project, which shows up fine. There is no response to the tableview scrolling though. Is there a setting or code I have in place that may cause the shynavbar to not "see" movements in the tableview? The tableview behaves normally but the extension and the navbar never budge.

_UPDATE: If I remove - (void)viewWillAppear:(BOOL)animated function, the shynavbar behaves as expected. Is this a bug?_

Setup code below, I'll post any other code that would help my situation:

self.shyNavBarManager.scrollView = self.tableView;

UIView *view = [[UIView alloc] initWithFrame:CGRectMake(0, 0, CGRectGetWidth(self.view.bounds), 44.f)];
view.backgroundColor = [UIColor redColor];
[self.shyNavBarManager setExtensionView:view];

When I change the height of the extension view after calling setExtensionView, the contractionAmount and expandCenter of extensionController remain unchanged.

What should I do after updating the extension view frame height?

I have opaque tab bar at bottom, and scrollView's content bottom inset is not adjusted in layoutViews.
I use [self setExtendedLayoutIncludesOpaqueBars:YES]. Any help?

It starts to happen, after presenting view controller and hiding status bar, then when going back showing status bar again. Even after few refreshes, topLayoutGuide includes only height of the navigation bar (44px) but not the status bar.

Hello, i tried to use it with a collectionView, but the headers appears behind the status bar when the navigationbar is hidden. Any suggestions?

When scrolled down a list, with shy nav bar hidden, when the view controller is about to disappear (e.g. pushing another view controller because user tapped on a cell), the navigation bar abruptly (without animation) appears briefly before the view controller transition

Any way we can get swift bridging headers etc?

Hi,
I have been using this library since you published, and I really like it so much!
and I am using this on my current project right now, :)

I have just small issues:

I have project that pushes to navigation on appear setNavigationBarHidden = YES

The effect is:

• the navigationBar will be hidden on the transition effect and the extensionView will be left shown (seems not good to see)

question:

1. Can we also set the extensionView hidden when Navigation is hidden?
2. when pushed and the extensionView and the navigation is hidden, can we let it be hidden upon push to another viewController? because right now when I push, It automatically shows the navigation and extensionView

Sorry for noob question :)

Hello. I use your code wonderfully.
And this time I make a app with Instagram SDK.

So make a tableView and custom Header Section.
tableView issued is solved, but problem is Header Section.
When navigationBar hidden, Header Section is not follow just remained.

like this.

How can I make Header section could move in navigationBar.position when it disappear?

Hello, i tried to use it with a UIWebView, but when i scoll the WebView nothing happens. Any suggestions?

This issue was discussed a bit here #2, but I wanted to dedicate that issue for the navbar animation.

Currently, the TLYNavBarManager applies a "cleanup" in viewWillAppear, viewWillDisappear, causing the navbar state to be lost. We can't just remove that code, but I suppose we can change the prepareForDisplay to:

(self.previousContractionState ? [self contract] : [self expand]);

and of course, remove the code that resets the previousContractionState variable.

I will probably also add a public variable that users can use to switch this behavior on and off. As far as I can tell, the facebook app, for example, doesn't preserve the states when switching tabs or pushing view controllers.

Running the demo gives this error: "You are using the component wrong... Please see the README file."

The code, when compiled in my project, gives three errors that all relate to TLYShyNavBarManager.m, line 92: __weak typeof(self) weakSelf = self; <- the typeof needs __ in front

I still get the same error in my project even after correcting the code.

First time posting an issue; hope I'm not breaking an "rules"

Anyways, I'm using TLYShyNavBar with a TableView and it works great for the most part. However, the Title object in my NavBar disappears when the NavBar is "shy," as seen in this video: http://youtu.be/Eb2B4J040ak

My NavBar is Opaque, and I fixed that bug with self.extendedLayoutIncludesOpaqueBars = true — not sure if that's affecting it.

Let me know if any other info is needed. Thanks!

It is really cool component, great gob.
I am using it on view controller which is using two collection views in scroll view added like a child view controllers, they are changing by swiping left or right.
I set up everything like after scroll page changed i am seting shymanagers scroll and controller :

self.shyNavBarManager.scrollView = self.collectionViewFromChild;
[self.shyNavBarManager setViewController:rightCollectionViewController];

the same for right.

its working fine on scrolling up, navigation bar hides cool.

The problem is that when I am scrolling down and scroll offset goes under status bar a bit and i begin to scroll down navigation bar begin to appear, but it should appear only when offset y reached the status bar height. Than in expands with out animation.
Video:
https://www.dropbox.com/s/x024oe0hkydlfyx/bug.mp4
Please help me with this problem. How I can fix it?

Thank you!

When the scrollView's contentSize is, say, 10 px extra, the scrolling of the navbar causes the component to set the scrollView's contentOffset beyond it's maximum value, causing for some broken behavior.

The current version of TLYShyNavBar in cocoa pods is 0.9.2.

Current master version is 0.9.8 prior to the pull request, probably should add 0.9.8 and 0.9.9? to the cocoa pods repo.

wierd behaviour seen when a custom height UINavigationBar is used

Hi-

Has anyone had issues implementing with a UITableView? I can't scroll at all after implementing this - only to the bounce points.

Thanks

Hi,
I am using your component and it is really great.
Can you please fix issue with in call status bar it seems not work well with it.
http://joxi.ru/EA4ng06ujYWYmb

Thanks!

In controller A, I scroll to top, the navigationbar work fine and hide, and click a push segue go to the next controller B.
When I back to pre controll A, navigationbar always auto show again.
How to dismiss it?

Hi

I've found an issue when the apps comes alive from the background. Scenario:

• Scroll to hide the navigation bar
• Click the device's home button to go to the "desktop"
• Re-open the app by tapping its icon

At first, the navigation bar remains hidden, but after half a second or so it goes back to its normal state, but the buttons, title, etc. do not appear until scrolling again.

Hi,

I have used your code in my application & it works pretty good. Only it shows issue while i am using the UIScrollView,

My Code structure is like below:

1. There is one view controller which contains a scrollView. Inside that scroll view i have loaded 4 another views.
2. The scrolling of pages are only horizontally & all the view contains a collection view.
3. So when i scroll the collection view to up, the navigation bar is get hide as per requirement but while i scroll the UIScrollView horizontally the next view shows a white screen at a top (in place of navigation bar).

I'm assuming you can remove the extension view using:

[self.shyNavBarManager setExtensionView:nil];

But it's not working. I guess this line is missing in setExtension method:

_extensionView = view;

Hi!
Thanks for this control, truly great work!
In my case, the screenshot you see below is from a UITableViewController. The position of the drawer is wrong and i can not scroll the whole table. I made an experiment and used a UIVIewController and everything worked smoothly.
Is anything special i can do to get it working with a UITableViewController?

First of all, this looks awesome. I have been messing with this stuff myself and your solution looks like the best and most robust I've seen yet. Great work!

I haven't poked around the code yet but noticed a slight difference in behavior between this component and what Instagram/Facebook use. Is there any plan to add the ability to push a view onto the stack without expanding the navigation bar on the current view? Then, when popping back, popping back to the bar in the state it was in (so if it was hidden, leaving it hidden?).

To put it more simply, take a look at the Facebook app:

• If you hide the navigation bar then push a new view, the new view has a new navigation bar that gets pushed with it, not changing the root view at all.
• If you unhide the navigation bar and push a new view, it gets pushed like a view controller normally does and the new navigation item fades in over the old one.

I have introspected those other apps' view hierarchies using Spark Inspector on a jailbroken device in the past and as far as I remember the way Facebook accomplishes it is by having the status bar background actually being a separate view than the navigation bar itself, so it is able to stay anchored on the root view while the actual navigation bar is pushed on top of it with the next one. Instagram did the same thing but in their case it is more trivial because no matter what state it is in when you push, the pushed navigation bar is obviously a different view (not even the same color).

Anyways, the component is pretty awesome without this but it would perhaps be a little less jarring to the user if the navigation bar does not pop in as a new view is about to be pushed. I'm not sure if this can be easily added while maintaining the simplicity of the component.