Ich habe nur eine 2. Klasse gemacht, dass man in aller Ruhe unabhängig an beiden PRs arbeiten kann und es keine Merge Konflikte gibt.

#13 (comment)

Only included change: #19

The result Error: Language 'de_DE' not found. from the wp language plugin|theme install % de_DE causes capistrano to think that the command has failed.

By using raise_on_non_zero_exit: false we can make capistrano does not fail https://stackoverflow.com/a/23424213/850651

In preparation of making this gem public I'm proposing to rename it to capistrano-wearerequired. Why? The new name has one less character and no underscore. 🙈 The current tasks/recipes are specific to our company/workflow but are still generic enough to be useful for others.

I searched for similar names in the repo and found https://github.com/demonz/capistrano-demonz, https://github.com/augustash/capistrano-ash, or https://rubygems.org/gems/crossroads_capistrano.

Thoughts?

Besides wp language core there are now wp language plugin and wp language theme commands to install translations. Those are available since WP-CLI 2.0.

We should add them as well to make sure we get all the translations for our projects, not just the core ones.

Can we get the release out next week?

See https://github.com/wearerequired/prohelvetia/blob/66d45bd075b885814cb980f54069de115517b311/lib/capistrano/tasks/wp.rake

https://github.com/wearerequired/prohelvetia/blob/master/lib/capistrano/cap_notify.rb

With SlackistranoMessagingColors we currently get this:

I'd like to see the revision/commit hash there too and the environment should be highlighted somehow. Anything else?

Slackistrano provides a nice example: https://github.com/phallstrom/slackistrano#customizing-the-messaging

Instead we should pass them as a list to the install command to reduce the number of commands.

Should probably be changed once wp-cli/language-command#61 is fixed.

Example: http://stackoverflow.com/a/26933503/3507335

This is necessary to make the gem compatible for non-WP projects.

Disccusion on Slack https://required.slack.com/archives/C0EMY854H/p1507700186000028

/usr/local/lib/ruby/gems/2.7.0/gems/slackistrano-3.8.4/lib/slackistrano/capistrano.rb:34: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call 
/usr/local/lib/ruby/gems/2.7.0/gems/capistrano-wearerequired-2.0.0/lib/capistrano/wearerequired/slackistrano_messaging_elements.rb:7: warning: The called method `initialize' is defined here

The current requirements allows to use this lib with 3.8.4 Slackistrano which has changed the constructor to a single argument.

3.1: https://github.com/phallstrom/slackistrano/blob/v3.1.0/lib/slackistrano/messaging/base.rb
3.8: https://github.com/phallstrom/slackistrano/blob/v3.8.4/lib/slackistrano/messaging/base.rb

We shouldn't trim lines for Markdown files

We use a task on Cyon to clear the cache.

# Opcache Reset
namespace :deploy do
  desc 'Create a temporary PHP file to clear the opcache.'
  task :clear_cache do
    on roles(:app) do
      within fetch(:release_path) do
        opcache_file = "#{fetch(:release_path)}/opcache_clear.php"
        execute :touch, "#{opcache_file}"
        execute :chmod, "-R 644 #{opcache_file}"
        execute :echo, "'<?php opcache_reset(); ?>' > #{opcache_file}"
        execute :curl, "-s -k #{fetch(:opcache_file_url)}"
        execute :rm, "-f #{opcache_file}"
      end
    end
  end
end
after 'deploy:finishing', 'deploy:clear_cache'

We have had trouble in the past to due to some cache issue with composer. It would be cool to have a task that does it on all three servers when we run into a issue.

it would be even better if the command was bundle exec cap staging composer clear-cache

	desc 'Clear composer cache'
	task :composer_clear_cache do
		on roles(:app) do
			within fetch(:release_path) do
				execute "composer clear-cache"
			end
		end
	end

Getting messages like this when not using Slack notifications for a project:

  WARN [slackistrano] You are using an outdated configuration that will be removed soon.

  WARN [slackistrano] Please upgrade soon! <https://github.com/phallstrom/slackistrano>

  WARN [slackistrano] Error notifying Slack!

  WARN [slackistrano]   Error: #<SocketError: Failed to open TCP connection to .slack.com:443 (getaddrinfo: nodename nor servname provided, or not known)>

If no Slackistrano config is provided, we shouldn't attempt to load and execute it in the first place.

https://github.com/phallstrom/slackistrano/blob/ffe8f433f2ca48ba63dce3d9b821e09a8fa72e42/lib/slackistrano/messaging/helpers.rb#L5-L11