This was a useful function added in X2DownloadableContentInfo to allow mods to define their own rules for certain items, as to let them be equipped by certain types of units if the standard rules couldn't cover the intended usage.

That said, a weakness of it was that there was no way to tell the user why they couldn't equip an item, and this could cause misidentifications of a bug.

This could be resolved by expanding on GetDisabledReason() in UIArmory_Loadout to include another DLC hook, something like HaveDisabledReasonForItem(), where a mod could send back a string if it's disabling the current item being checked from being equipped for that unit.

This is usefull to globally add animation sets to pawns and also as callback to do pawn specific stuff like resizing the pawn.

I already have code to solve this problem, so I will make an updated X2Ability_GrenadierAbilitySet file with the fix in it and put in a pull request.

Currently, the X2SoldierClassTemplateManager.GetCrossClassAbilities(optional X2SoldierClassTemplate ExcludeClass) doesn't check against abilities that the soldier class itself has.

This can happen for example when bAllowAWCAbilities is set to true for sparks, this allows both sparks and grenadiers the possibility to get "Shredder" as a trainable perk.

@maluco I'd like to request a very, very easy unprotecting/configurability of a variable.

class XComAutosaveMgr extends Actor dependson(XComOnlineEventMgr);

const MAX_TACTICAL_AUTOSAVES = 3;

There's really no reason to limit the game to 3 saves (they are so small), and since sometimes saves get corrupted it would be nice to be able to rollback to a previous one that works during a tactical mission.

Thank you.

The game ends SoundCue narrative moments after three seconds because it assumes they fail to play.

Relevant code in UINarrativeMgr

m_arrConversations[0].AudioComponent.OnAudioFailedToPlay = OnAudioFailedToPlay;
// ...
function OnAudioFailedToPlay(AudioComponent AC)
{
    UpdateConversationDialogueBox();
    SetTimer(FailedAudioDuration, false, nameof(EndCurrentConversation));
} 

However, OnAudioFailedToPlay is commented like this:

/** assign this delegate to get a notification when this AudioComponent knows has failed to play a wise event */
delegate OnAudioFailedToPlay(AudioComponent AC);

It always fires on SoundCues that do not have an AkEventOverride. This breaks Mod-added narratives!

GetWeaponStatsForUI() does not check for damage modifying weapon upgrades

GetUpgradeModifiersForUI(X2WeaponUpgradeTemplate UpgradeTemplate) uses UpgradeTemplate.BonusDamage.Damage > 0 to solely identify MissDamage, rather than damage and UpgradeTemplate.BonusDamage.Tag=="Miss" so that an upgrade improving normal damage can get a UI stat markup.

Note: This should only add those abilities that hasn't been populated in the ability tree.

The specific issue is specifically in XComGameState_AdventChosen's AssignStartingTraits(), as it will forcefully assign Shadowstep to the Assassin if the narrative's enabled, after initial weaknesses have been chosen randomly.

This means that an Assassin can roll with traits that shouldn't appear on a Chosen with shadowstep. This should be able to be fixed via alteration of when the game checks if it should give the narrative trait to the chosen getting its starting traits.

just referencing suggestion from campaign save fix issue to make an efficient sorting algorithm available to modders

Trigger an event for RetainConcealmentOnActivation in XComGameState_Unit.OnAbilityActivated that allows to modify the bRetainConcealment result on ability activation.

Hello, I have seen this problem in the steam website, and in this forum as issue #69. The issue is that, I put the folder onto the xcomegame/mods folder at war of the chosen directory,
I see the mod when I open it in ModLauncherWPF, and I enable it for War of the Chosen, but when I open the game, the version string does not appear at the lower right corner of the screen in the main menu, meaning its nominally loaded but not recognized in game. I have tried reinstalling the game, uninstalling all mods,using an older version of the highlander, and trying to only use the highlander, but even then it does not work ,(the version does not show up on the lower right corner, and all mods I try with it as a requirement miss textures).

I need help to solve this issue.
Best regards.

If I enable only this mod, XCom2 will crash with a segmentation fault. No log produced, only a few Config files created. There is a dump file.

2f9b2726-120d-fc4a-7c5f7b7b-1fad17b5.zip

Fix an issue in the base game where Strategy X2EventListenerTemplates only register when going from tactical to strategy, not when loading into strategy in any other form.

Changes are needed in XGStrategy.state'LoadingGame', maybe also XGStrategy.state'StartingDebugCheatGame' and XGStrategy.state'StartingFromTutorial'.

While not that important, it would be nice to have any assigned names to enemies properly show up on them.

The specific function for this is GetName() in XComGameState_Unit, an edit so it would allow enemies to show a proper name if strFirstname or strLastName aren't empty should be sufficient.

Currently, when populating the utility items in UIArmory_Loadout, it gets a list of all items in the eInvSlot_Utility of the unit OR any items in other slot that has the default slot set to eInvSlot_Utility, but exclude only items equipped in eInvSlot_GrenadePocket. This can lead to items equipped in the ammo slot to be displayed as equipped in utility slot when not all utility item slots are used, or lead to utility items getting pushed out of the list if the ammo item has a lower index than the utility items and all utility items slots are used.

To fix, make class'UIUtilities_Strategy'.static.GetEquippedUtilityItems properly exclude any items that are equipped in the eInvSlot_AmmoPocket

By adding two events in UITacticalHUD, mods should able to use the Reaper UI without using the "SuperConcealed" mechanic,

Copy of Issue #215 of XCOM2 Highlander.

Thought this might be useful

(NEW LIST BELOW)

Also Ruler Nerf Nerf 1123973745 might be worth including since it touches on an unintended exploit. Fusion Ripjack Applies Stun 1128495039 is also worth considering since by default, the beam ripjack is a downgrade from the magnetic ripjack.

Ability Interaction Fixes and Damage Flyover Fix conflict with each other because they both fix different flyover texts.

Something like the DLCAppendSockets functions in XComUnitPawn and XComHumanPawn from LW2/X2CommunityHighlander.

Requested in order to bring the models/animations/sockets of the secondary weapons added in LW2 over to WOTC. Thanks!

Essentially a port of X2CommunityCore/X2CommunityHighlander#164

Will require several steps to get it right:

• Port X2CommunityCore/X2CommunityHighlander#231 for better navigation
• Port X2CommunityCore/X2CommunityHighlander#58 for better callbacks
• Port X2CommunityCore/X2CommunityHighlander#164 for the actual main menu

When a new faction is added to the game, the game doesn't know how to handle it and gives a standard cyan color. The highlander is a good place to put this fix.

This was discovered just recently, I am posting it here because I think a Highlander mod might be able to fix it more elegantly than the hacky workarounds currently proposed.

Details here: http://steamcommunity.com/workshop/filedetails/discussion/1132835147/1474222595306563689/?tscn=1506142512#c1496741765133336770

I've got quite a few mods however using the Highlander and Fulton Extraction Mods seem to be crashing it every time I start a mission. if this has already been resolved please show me.

Basically a follow-up to #45. That one affects weapons (which allows Assault Rifles and similar weapons to work with suppression), but using that for enemies (such as the viper) doesn't look good:
https://www.youtube.com/watch?v=HK2Lebzwgrc

This is because of this code in XComIdleAnimationStateMachine:

AnimParams.AnimName = 'FF_FireSuppressIdle';
AnimParams.Looping = true;
if( Unit.m_bSuppressing )
{
	UnitPawnNative.GetAnimTreeController().PlayFullBodyDynamicAnim(AnimParams); // idle until we shoot again
	Sleep(((Rand(100) / 100.0f)*2.0f) + 1.5f); // only shoot every 1.5-3.5 seconds when supressing (an addition 0.5 after target peeks)
	goto('Firing');
}

Very few weapons grant FF_FireSuppressIdle, even Assault Rifles only do because Firaxis included them for some reason.

An easy fix is to just check if the unit can play this animation, and if not, use NO_IdleGunUp instead (which is used for blending from to in vanilla). This looks much better:
https://www.youtube.com/watch?v=x3Ie3gjFXio

In case this animation can't be played as well, just freeze the unit for the time it's waiting.

Hello,

If I understand correctly this mod provides an easier way to mod the base game AND will provide unofficial bugfix ?

If the bugfix part is correct should we report base game bug here ?

I don't know if you noticed, but in base game the weapons used to move when you were in the attachment menu, this doesn't work anymore.

Every weapon seems to be affected by that (Spark also, but since there were not allowed to use attachment I suppose that Firaxis didn't code any movement for them.

To be more specific https://youtu.be/ISTbsrqpzgg?t=168 (this is just a random video on YouTube with attachment) so you can see what i mean when "weapon don't move"

"Summoning Sickness" is a flag on a AIGroup that prevents them from being granted a turn. It is set when the Group scampers, and reset when the associated player's turn begins.

There is an issue in BeginInitiativeTurn that resets it whenever the player's turn begins or is resumed.

if( CachedUnitActionPlayerRef.ObjectID == CachedUnitActionInitiativeRef.ObjectID )
{
	ResetHitCountersOnPlayerTurnBegin();
	
	// ...

	if( !bResumeFromInterruptedInitiative && !bBeginInterruptedInitiative )
	{
		// Trigger the PlayerTurnBegun event
		EventManager = `XEVENTMGR;

			// build a gamestate to mark this beginning of this players turn
			Context = class'XComGameStateContext_TacticalGameRule'.static.BuildContextFromGameRule(eGameRule_PlayerTurnBegin);
		Context.PlayerRef = CachedUnitActionPlayerRef;

A fix is to move ResetHitCountersOnPlayerTurnBegin(); into the if block. This also prevents it from resetting Hit/Miss streaks when the initiative interruption is done.

In the vanilla Highlander, there was a function GetNumUtilitySlots() (see X2CommunityCore/X2CommunityHighlander#114 ). It was called wherever some code would change / reset the number, and expected an override number. This made a lot of code more ugly than it already is.

In WotC, it gets worse. Consider this code that handles unequipping a piece of armor:

case eInvSlot_Armor:
	if(!IsMPCharacter() && X2ArmorTemplate(Item.GetMyTemplate()).bAddsUtilitySlot)
	{
		if (!HasExtraUtilitySlotFromAbility())      //  don't lower the bonus if one is given via an ability
		{
			SetBaseMaxStat(eStat_UtilityItems, GetMyTemplate().GetCharacterBaseStat(eStat_UtilityItems));
			SetCurrentStat(eStat_UtilityItems, GetMyTemplate().GetCharacterBaseStat(eStat_UtilityItems));
		}
	}
	break;

This is bad. All code that handles the utility item stat needs to be aware of any other systems that touch the slot number.

I would use a slightly different approach: A function called RealizeNumUtilitySlots() that can be called whenever anything happens that would modify utility slot numbers, and an additional DLC hook that allows mods to modify / override this number. This function would always run all the checks: Character Base Stat, Bonus Armor Slot, Tactical Rigging, DLC Hooks, and then set the character stat. Sensible places to do this are equipping / unequipping items, buying abilities.

This function should then be the only code that sets this stat (except TQL / dev tools, cheats and MP).

Hi, I'm having issues with some (=most) of the textures for LW secondary weapons that the highlander makes possible for other mods to use not showing up at all. I'm using "A Better Barracks" that uses the LW secondaries and had all the pre requisite mods installed already (highlander and missing resources) but for w/e reason the only LW secondary weapon that had a model was the vibroblade T2. The T1 looked like the standard T1 sword, and the T3 blade was also not showing up. They work from a gameplay standpoint, the perks attached to them work, the fire and provide +aim and stuns and everything, I just cant see them doing it lol. I tried refreshing the .ini files and that didn't help.

I tried uninstalling all mods and doing an .ini refresh, then installed only missing resources, highlander and LW secondary weapons to see if it was any incompatibility with some of my other mods, but that didn't worked.

I also tried contacting the mod creators for "A Better Barracks" and "LW secondary weapons", and it seems the issue lies with Highlander. Apparently I was supposed to see a number version of highlander on the corner of the main menu, but I don't. I tried reinstalling highlander countless times and nothing.

X2EventListenerTemplate.AddEvent should be enhanced so you can specify EventListenerDeferral for the delegate.

Currently UIArmory_Loadout tests UpdatedUnit.GetRank() > 0 to check if it should display the secondary weapon slot. The right way should be to test against UpdatedUnit.NeedsSecondaryWeapon() which evaluates X2SoldierClassTemplate.bNoSecondaryWeapon.

Not sure if @bountygiver is already going to do this/suggest doing this, but integrating save management features into the highlander would be ideal, since this overrides multiple classes (UISaveGame, UILoadGame, UISaveLoadGameListItem) and provides a great deal of functionality. It would also hopefully prevent issues with the configurable tactical save amounts.

[WOTC] Rename and Reorganize Campaign

Add a simple event trigger in XComGameStateContext_WillRoll.ContextBuildGameState(). This allows mods to make simple changes to the resulting game state, add visualization (via PostBuildVisualization), ...

Per here, XGUnitNativeBase.ShouldUseWalkAnim() checks if a unit is at red alert if it's an AI. Since Gremlins are cosmetic units and thus do not interface with the green/red alert system, they always use the walk anims, even for active combat abilities such as Combat Protocol.

Although loot tables are already deprivatized there is no common way to add/remove loot.
There are some caveats involved,e.g. loot chances must be recalculated per rollgroup when a loot table is edited.
A simple helper class with static methods would go a long way in providing a unified interface for mods to interact with loot tables without the hassle of ini entry manipulating.

For pre start state manipulation of loot tables use the static methods in OnPostTemplatesCreated like this
class'X2LootTableManager'.static.AddEntryStatic(LootTableName, LootTableEntry);

At runtime you can use the singleton instance like

LootManager = class'X2LootTableManager'.static.GetLootTableManager();
LootManager.AddEntry(LootTableName, LootTableEntry);
LootManager.InitLootTables();

this will also reinitialise the loot tables.

For bulk add to loot tables you can move the chance recalculation to the end:

LootManager.AddEntry(TableName, EntryToAdd, false);
LootManager.AddEntry(TableName, EntryToAdd, false);
LootManager.AddEntry(TableName, EntryToAdd, false);
LootManager.RecalculateLootTableChance(TableName);

This way your chance ratio is preserved.

The specific offender is the function UpdateMissions(), as the if check for faction HQs assumes that any haven with a faction HQ attached it will be one of the vanilla three factions to init, as so:

               FactionHQ = XComGameState_Haven(ScanSite);
                if(FactionHQ != none)
                {
                    numHQ++;
                    switch (FactionHQ.GetResistanceFaction().GetChampionClassName())
                    {
                    case 'Skirmisher':
                        MissionItemUI.MissionIcons[1].SetScanSite(ScanSite);
                        break;
                    case 'Reaper':
                        MissionItemUI.MissionIcons[0].SetScanSite(ScanSite);
                        break;
                    case 'Templar':
                        MissionItemUI.MissionIcons[2].SetScanSite(ScanSite);
                        break;
                    }
                    
                }

This should be relatively easy to fix by altering this function to account for the possibility of mod-created factions, both for the actual initialization of the icon and for the NumHQ check so it doesn't think the center three icons are filled when they are not.

Since the new patch i cannot use the mod i figured out only today after a week of testing what mod was crashing my game every time i was going in battle (WIn 10)

I have two classes which do not have AWC abilities. The Samurai and the SpecOps class.

The samurai wouldnt even benefit from 90% of the AWC abilities because his primary weapon is the sword.

Either way i want these classes to behave like normal classes and don't want them to be Hero classes or get AWC abilities. I just just want to allow them to participate in the Combat Intelligence / Ability Points System.

This can be achieved by a config array of class names that prevent certain classes from rolling awc abilities in XComGameState_Unit.RollForTrainingCenterAbilities() as @robojumper suggested.

This way you could also give Sparks access to the Combat Intelligence / Ability Points System without having them AWC abilities as an example.

Originally done in the Long War Highlander for Vanilla, needed for slight changes to abilities rather than full overwrites.

It is reported that the highlander does not work on MacOS. To test, we've cooked up a highlander that ONLY adds a version template and a version check of 9.9.9. If this lightest touch is not functional, it is likely an issue that requires a fix upstream from Firaxis/Feral to allow for cooking highlanders for all platforms, not just windows.

If you wish to help test this on MacOS, do the following:

1. Download the Blank Highlander linked below.

X2WOTCCommunityHighlanderBlankTest.zip

2. Unhide the Library folder in your home directory.
3. Unsubscribe from the Community Highlander and delete the folder: ~/Library/Application Support/Steam/steamapps/workshop/content/268500/1134256495 to remove all traces of the highlander.
4. Extract the Blank community highlander to ~/Library/Application Support/Steam/steamapps/common/XCOM 2/XCom2-WarOfTheChosen/XComGame/Mods

When you run XCOM 2 it should show the X2WOTCCommunityHighlander WITHOUT the steam icon next to it. Try to run with only the highlander, and report whether the game loads or not.

If it works properly, you should see a version number of 9.9.9 on the bottom right of the main menu screen.

Allow the modification of default spawn size to support squads larger than 9 units

Bug in action: https://www.youtube.com/watch?v=OJXpriUV8oU

Ever since Long War 2 the modding community standard for custom classes has shifted to 8 ranks with 3 abilities per rank. While more than 2 abilities per rank are fairly easily implemented more than 7 ranks is not.

Ideally 7 rank soldiers and soldiers with higher amount of ranks should peacefully coexist. But the moment you implement an experience table rank entry for 8 or higher things go wonky. And the solutions tend to live in XComGameState_Unit.

I'm not aware enough of the codebase as a whole go give comprehensive suggestions for what to do here but I've got some starting points.

First and most obvious:

2:57 PM]  robojumper: Right, `GET_MAX_RANK is global for everyone
[2:58 PM] robojumper: X2SoldierClassTemplate has a function GetMaxConfiguredRank()
[2:58 PM] robojumper: We should probably replace calls to `GET_MAX_RANK with those
[2:59 PM] robojumper: Care to open an issue in the HL?

Second:

When calling a XComGameState_Unit.GetRankAbilities(int Rank) for an unavailable rank it returns the squaddy rank Abilities. I suggest it instead return EmptyRankAbilities.

Peek From Concealment and Gotcha Again require a really hacky patch to be compatible with one another that also requires an ini edit if they're not loading in the right order.

http://steamcommunity.com/sharedfiles/filedetails/?id=1136981000

Furthermore, Perfect Information, another popular mod, conflicts with this fix as well as Gotcha Again.

Would be cool if Highlander could help sort out this compatibility clusterfuck, specifically with XComPathingPawn.

Code Changes to XComUnit_Pawn.txt

The Configs in there current form must be implemented in a helper class!

As an added bonus, the code change also allows Chosen death animations to be interrupted optionally

This hasn't been solved for base WOTC yet, but since the Highlander is replacing the will roll script file anyway, I figure it would be easier to implement a fix here.

This is the code directly involved in the will roll on mission start:

if(RollInfo.MaxWillPercentageLostPerMission > 0)
		{
			// get the unit's will at the start of the mission
			History = `XCOMHISTORY;
			StartOfMissionUnit = XComGameState_Unit(History.GetGameStateForObjectID(InSourceUnit.ObjectID,, History.FindStartStateIndex()));
			MaximumWillLossPerMission = RollInfo.MaxWillPercentageLostPerMission * InSourceUnit.GetMaxStat(eStat_Will);
			MinimumAllowedWill = max(MinimumAllowedWill, StartOfMissionUnit.GetCurrentStat(eStat_Will) - MaximumWillLossPerMission);
		}

Here's a list of secondary and tertiary mission part names:

if(MissionTemplate == 'LostAndAbandonedC')
'LastGiftB'
'LastGiftC'
'ChosenShowdown_Assassin'
'ChosenShowdown_Warlock'
'ChosenShowdown_Hunter'
'AssaultFortressLeadup' (not sure if this is the first part)`
'DestroyAvatarProject'

I think changing if(RollInfo.MaxWillPercentageLostPerMission > 0) to if(RollInfo.MaxWillPercentageLostPerMission > 0 && MissionTemplate != 'LostAndAbandonedC' || etc...) might work, but that wouldn't easily expandable if modders implemented multi-part missions of their own.

Edit: The characterPoolManager is passed in a parameter for ForcedCountry that is never used in the creation of a solider in the CreateCharacter function.

In addition, I'm looking to work with the CharacterPoolManager, however right now this is a class that cannot be overridden. It was done in the vanilla highlander so I assume that it is possible here. This functionality would be a lot of help if added to the Highlander.

I am willing to work on this if someone breaks down on a high level what is required for the task
Thanks!

This is a base WOTC bug I've noticed when using suppression on pistols/sidearms and occasionally when just firing the pistol - the game will use the primary weapon, even though that's not the intended behavior.