Giter VIP home page Giter VIP logo

Comments (5)

zhpn1024 avatar zhpn1024 commented on July 19, 2024 1

https://github.com/zhpn1024/ribotish/commit/ed3d80d5aed2e504c2eb120f8b6e51b05db14acf

from ribotish.

zhpn1024 avatar zhpn1024 commented on July 19, 2024

Thank you for reporting the bug. Let me see how to deal with it.

from ribotish.

zhpn1024 avatar zhpn1024 commented on July 19, 2024

The problem is that the 'start_codon' line is missing, and the code calculate start codon position with stop codon, resulting in frame shift error. The t.cds_start(cdna=True) should be 0 instead of 2, and t.cds_stop(cdna=True) should be 1335.
Deleting the second stop_codon line should be fine.
I have find a way to fix the bug.

from ribotish.

mt1022 avatar mt1022 commented on July 19, 2024

Thanks for the timely response.

By the way, I am not sure whether self.cds_start have similar problems when "start_codon" lines are present in gtf. It is possible that a start codon might be distributed over two exons in rare cases, which might also lead to incorrect results in cds_start() class mehtod.

from ribotish.

zhpn1024 avatar zhpn1024 commented on July 19, 2024

You are right. The split of start codon should also be considered.

from ribotish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.