Comments (1)
Team's Response
The severity of this issue is VeryLow, as this is purely cosmetic.
Furthermore, it is intended for this diagram to take up the whole page, such that it acts as a clean page break to move the DG on to the next section. If the diagram were to be smaller, the next section may appear and get cut in half, worsening the entire experience for the user and causing confusion.
This was a design consideration that our team decided on and not a bug, and felt that it is best for this diagram to be big so that users can read it more easily.
Items for the Tester to Verify
❓ Issue response
Team chose [response.Rejected
]
- I disagree
The screenshot is from the official CS2103 website.
it is best for this diagram to be big
The developer has agreed that font in the diagram is particularly big compared to the one in the DG. Hence, it's a bug.
Furthermore, it is intended for this diagram to take up the whole page, such that it acts as a clean page break to move the DG on to the next section. If the diagram were to be smaller, the next section may appear and get cut in half, worsening the entire experience for the user and causing confusion.
I do not accept this reason as there're other ways to introuduce a page break and I believe making a diagram particularly big just to create a page break is a bad idea.
A simple Google search will lead you to:
<div style="page-break-after: always"></div>
for adding page breaks.
❓ Issue severity
Team chose [severity.VeryLow
]
Originally [severity.Low
]
- I disagree
Reason for disagreement: This is not a purely cosmestic problem. The user should be able to read the other texts of the DG just fine. Hence, they should be able to read diagrams with similar font size. Making the diagram needlessly large unconvinence the user. They now have to scroll more to read the DG.
The screenshot is from the official CS2103 website.
I believe this quite important as it's mentioned explicitly in the list of tips to make a good DG.
from pe.
Related Issues (15)
- The app is unusable
- A way to easily unSU a module HOT 1
- Average CAP needed calculation HOT 1
- I can't retake a module in different semesters HOT 1
- Find command shows modules from different semesters HOT 1
- I should not have average CAP required to meet my target anymore HOT 1
- Year long module is not reflected by MyMods HOT 1
- No checking for invalid data HOT 1
- No mention of add, edit, delete, can only be used in the semester of the module HOT 1
- Inconsistent capitalization of UI HOT 1
- Return arrow is not dashed HOT 1
- Else in activity diagram HOT 1
- Theme change should be more precise in the UG HOT 1
- Arrow stops halfway through HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pe.