Giter VIP home page Giter VIP logo

Comments (1)

nus-se-bot avatar nus-se-bot commented on July 29, 2024

Team's Response

The severity of this issue is VeryLow, as this is purely cosmetic.

Furthermore, it is intended for this diagram to take up the whole page, such that it acts as a clean page break to move the DG on to the next section. If the diagram were to be smaller, the next section may appear and get cut in half, worsening the entire experience for the user and causing confusion.

This was a design consideration that our team decided on and not a bug, and felt that it is best for this diagram to be big so that users can read it more easily.

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: Screenshot from 2020-11-18 16-03-48.png

The screenshot is from the official CS2103 website.

it is best for this diagram to be big

The developer has agreed that font in the diagram is particularly big compared to the one in the DG. Hence, it's a bug.

Furthermore, it is intended for this diagram to take up the whole page, such that it acts as a clean page break to move the DG on to the next section. If the diagram were to be smaller, the next section may appear and get cut in half, worsening the entire experience for the user and causing confusion.

I do not accept this reason as there're other ways to introuduce a page break and I believe making a diagram particularly big just to create a page break is a bad idea.
A simple Google search will lead you to:
<div style="page-break-after: always"></div> for adding page breaks.


❓ Issue severity

Team chose [severity.VeryLow]
Originally [severity.Low]

  • I disagree

Reason for disagreement: This is not a purely cosmestic problem. The user should be able to read the other texts of the DG just fine. Hence, they should be able to read diagrams with similar font size. Making the diagram needlessly large unconvinence the user. They now have to scroll more to read the DG.

Screenshot from 2020-11-18 16-03-48.png

The screenshot is from the official CS2103 website.

I believe this quite important as it's mentioned explicitly in the list of tips to make a good DG.


from pe.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.