Comments (1)
Team's Response
This issue is not a functionality bug as purposefully replacing implementation details of the data file is not a legitimate user behavior. (As from the textbook, a legitimate user behavior is eg incorrect commands, or extra parameters while using our app).
Furthermore, editting the data file will NOT affect the product's functionalities, as the CAP calculation and progress still reflect accurate results, but with respect to the editted data inputted. (e.g. CAP calculation still counts the correct CAP, assuming a 20MC module exists; progress command is showing the accurate progress, but with respect to the editted data inputted i.e. a goal CAP of 0.0).
Therefore, it is rejected.
Also changed the severity to low, as this issue will not affect normal operations of the product for most of the users, and will only appear in very rare cases when a user edits the data file directly.
Items for the Tester to Verify
❓ Issue response
Team chose [response.Rejected
]
- I disagree
Reason for disagreement: > This issue is not a functionality bug as purposefully replacing implementation details of the data file is not a legitimate user behavior.
It's expected for users to be able to edit the JSON file.
Furthermore, editting the data file will NOT affect the product’s functionalities, as the CAP calculation and progress still reflect accurate results, but with respect to the editted data inputted. (e.g. CAP calculation still counts the correct CAP, assuming a 20MC module exists; progress command is showing the accurate progress, but with respect to the editted data inputted i.e. a goal CAP of 0.0).
I believe this is false as I can't input 20MCs, goal CAP of 0.0 from the command line interface. If such input doesn't affect the app's functionality, then why is there a restriction in the first place. Are the restrictions just made arbitrarily? I believe the developer has put such restrictions for a reason. Hence, the edited data should result in an error and not just the app continuing to work not as intended.
From the message, I expect that there should never exists a module with 20 MCs in the app. But, from the screenshot I provided, there's a module with 20 MCs. Hence, the behaviour is not expected.
This behaviour bypasses the restrictions the developer has put in place for the app. User can just edit the file and put what they want not following the app's restriction. This is not an expected behavior. Hence, this is a bug.
❓ Issue severity
Team chose [severity.Low
]
Originally [severity.High
]
- I disagree
Reason for disagreement: The definition of low is something that happens very rarely. The target audience of the app is NUS students which are arguably tech-savy enough to be able to edit JSON files.
I believe the severity should at least be a medium.
from pe.
Related Issues (15)
- The app is unusable
- A way to easily unSU a module HOT 1
- Average CAP needed calculation HOT 1
- I can't retake a module in different semesters HOT 1
- Find command shows modules from different semesters HOT 1
- I should not have average CAP required to meet my target anymore HOT 1
- Year long module is not reflected by MyMods HOT 1
- No mention of add, edit, delete, can only be used in the semester of the module HOT 1
- Inconsistent capitalization of UI HOT 1
- Return arrow is not dashed HOT 1
- Else in activity diagram HOT 1
- This diagram should be resized HOT 1
- Theme change should be more precise in the UG HOT 1
- Arrow stops halfway through HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pe.