Giter VIP home page Giter VIP logo

Comments (1)

nus-se-bot avatar nus-se-bot commented on July 29, 2024

Team's Response

This issue is not a functionality bug as purposefully replacing implementation details of the data file is not a legitimate user behavior. (As from the textbook, a legitimate user behavior is eg incorrect commands, or extra parameters while using our app).

Furthermore, editting the data file will NOT affect the product's functionalities, as the CAP calculation and progress still reflect accurate results, but with respect to the editted data inputted. (e.g. CAP calculation still counts the correct CAP, assuming a 20MC module exists; progress command is showing the accurate progress, but with respect to the editted data inputted i.e. a goal CAP of 0.0).

Therefore, it is rejected.

Also changed the severity to low, as this issue will not affect normal operations of the product for most of the users, and will only appear in very rare cases when a user edits the data file directly.

image.png

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: > This issue is not a functionality bug as purposefully replacing implementation details of the data file is not a legitimate user behavior.

Screenshot from 2020-11-18 21-50-41.png

It's expected for users to be able to edit the JSON file.

Furthermore, editting the data file will NOT affect the product’s functionalities, as the CAP calculation and progress still reflect accurate results, but with respect to the editted data inputted. (e.g. CAP calculation still counts the correct CAP, assuming a 20MC module exists; progress command is showing the accurate progress, but with respect to the editted data inputted i.e. a goal CAP of 0.0).

I believe this is false as I can't input 20MCs, goal CAP of 0.0 from the command line interface. If such input doesn't affect the app's functionality, then why is there a restriction in the first place. Are the restrictions just made arbitrarily? I believe the developer has put such restrictions for a reason. Hence, the edited data should result in an error and not just the app continuing to work not as intended.

Screenshot from 2020-11-18 22-06-04.png

From the message, I expect that there should never exists a module with 20 MCs in the app. But, from the screenshot I provided, there's a module with 20 MCs. Hence, the behaviour is not expected.

This behaviour bypasses the restrictions the developer has put in place for the app. User can just edit the file and put what they want not following the app's restriction. This is not an expected behavior. Hence, this is a bug.


❓ Issue severity

Team chose [severity.Low]
Originally [severity.High]

  • I disagree

Reason for disagreement: The definition of low is something that happens very rarely. The target audience of the app is NUS students which are arguably tech-savy enough to be able to edit JSON files.
I believe the severity should at least be a medium.


from pe.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.