When you change the class of an item in the item editor, the attribute labels and text box enabledness are not updated. You have to close the dialog and reopen it again.

This did properly work in 2.5, but I'm not sure when the bug was introduced.

Reported by Shadowblitz16.

Items placed on the screen in ZQuest cannot be moved. Reported and verified on Win builds.

I tried builds all the way back to 4-JUNE-2017, and every build had this issue. I do not6 know when it was introduced, but I did not touch screen items in a way that should be able to affect this, AFAIK.

I need to sleep before i delve into this. Can someone check a few older builds and back-track this one?

This is currently the biggest issue at the moment: Dependency crap.

There's three related problems: 64-bit builds in general, osx/linux, vs2015 (or any other compiler that just fucking breaks stuff randomly).

I'm contemplating creating a new repository called "Zelda Classic Dependencies" as putting all the binaries for every conceivable platform configuration is just silly, as you say. This can house the complete source (and projects--as users can freely contribute new platforms as needed) and heck, even binaries for common platforms; sure, why not just cherry-pick a single folder with pre-built stuff if it exists? This is great for new people.

On the maintenance side of things in the main code base we actually don't have to micro-manage project files; by utilizing the unity-esque build_modules approach, trivial additions or deletions of cpp files will not break compilation of anything. As long as one person keeps up to date with changes then all projects stay up-to-date.

Thoughts; Ideas; Monsters?

I am having trouble compiling branch 2.50.x on Linux. It seems the function "pack_fopen_password" is not declared in my distribution's version of Allegro:

Linux Mint x86_64
kernel 4.4.0-47-generic
Allegro version: 4.4.2

Make output:

$ make linux
make[1]: Entering directory '/home/jordan/Development/ZeldaClassic/zelda-classic'
Compiling Zelda Classic for Linux...
g++  -DPTW32_STATIC_LIB -O3 -Wno-long-long -W -Wall -Wshadow -Wpointer-arith -pedantic -I./include -I./include/alogg -I./include/almp3 -I./include/dumb -I./include/loadpng -I./include/lpng1212 -I./include/jpgalleg-2.5 -I./include/zlib123 -fpic -c src/zcmusic.cpp -o obj/zcmusic.o -s 
src/zcmusic.cpp:31:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning(disable:4512) //assignment operator could not be generated
 ^
src/zcmusic.cpp:32:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning(disable:4100) //unreferenced formal parameter
 ^
src/zcmusic.cpp:38:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning(default:4100)
 ^
src/zcmusic.cpp:39:0: warning: ignoring #pragma warning  [-Wunknown-pragmas]
 #pragma warning(default:4512)
 ^
In file included from ./include/gme/Nsf_Emu.h:11:0,
                 from src/zcmusic.cpp:33:
./include/gme/Nes_Cpu.h: In member function ‘void Nes_Cpu::end_frame(nes_time_t)’:
./include/gme/Nes_Cpu.h:145:54: warning: declaration of ‘end_time_’ shadows a member of ‘Nes_Cpu’ [-Wshadow]
 inline void Nes_Cpu::end_frame( nes_time_t end_time_ )
                                                      ^
./include/gme/Nes_Cpu.h:101:13: note: shadowed declaration is here
  nes_time_t end_time_;
             ^
./include/gme/Nes_Cpu.h: In member function ‘void Nes_Cpu::map_memory(nes_addr_t, long unsigned int, Nes_Cpu::reader_t, Nes_Cpu::writer_t)’:
./include/gme/Nes_Cpu.h:167:91: warning: declaration of ‘r’ shadows a member of ‘Nes_Cpu’ [-Wshadow]
 inline void Nes_Cpu::map_memory( nes_addr_t addr, unsigned long s, reader_t r, writer_t w )
                                                                                           ^
./include/gme/Nes_Cpu.h:65:14: note: shadowed declaration is here
  registers_t r;
              ^
In file included from ./include/gme/Spc_Emu.h:9:0,
                 from src/zcmusic.cpp:35:
./include/gme/Fir_Resampler.h: In member function ‘int Fir_Resampler<width>::read(Fir_Resampler<width>::sample_t*, long int)’:
./include/gme/Fir_Resampler.h:108:18: warning: declaration of ‘imp’ shadows a member of ‘Fir_Resampler<width>’ [-Wshadow]
  sample_t const* imp = impulses [this->imp];
                  ^
./include/gme/Fir_Resampler.h:66:6: note: shadowed declaration is here
  int imp;
      ^
./include/gme/Fir_Resampler.h:110:12: warning: declaration of ‘step’ shadows a member of ‘Fir_Resampler<width>’ [-Wshadow]
  int const step = this->step;
            ^
./include/gme/Fir_Resampler.h:70:6: note: shadowed declaration is here
  int step;
      ^
In file included from src/zcmusic.cpp:35:0:
./include/gme/Spc_Emu.h: At global scope:
./include/gme/Spc_Emu.h:76:43: warning: unused parameter ‘gain’ [-Wunused-parameter]
  blargg_err_t init( long r, double gain = 1.4 ) { return set_sample_rate( r ); }
                                           ^
In file included from /usr/include/sched.h:28:0,
                 from /usr/include/pthread.h:23,
                 from src/mutex.h:35,
                 from src/zcmusic.cpp:22:
./include/gme/Vgm_Emu.h:85:43: warning: unused parameter ‘end_out’ [-Wunused-parameter]
  int track_length( const byte** end_out = NULL, int* remain_out = NULL ) const
                                           ^
./include/gme/Vgm_Emu.h:85:67: warning: unused parameter ‘remain_out’ [-Wunused-parameter]
  int track_length( const byte** end_out = NULL, int* remain_out = NULL ) const
                                                                   ^
In file included from src/zcmusic.cpp:36:0:
./include/gme/Vgm_Emu.h: In member function ‘const char* Vgm_Emu::load(const void*, long int)’:
./include/gme/Vgm_Emu.h:110:64: warning: declaration of ‘data’ shadows a member of ‘Vgm_Emu’ [-Wshadow]
 inline blargg_err_t Vgm_Emu::load( void const* data, long size )
                                                                ^
In file included from ./include/gme/Vgm_Emu.h:10:0,
                 from src/zcmusic.cpp:36:
./include/gme/Vgm_Emu_Impl.h:47:14: note: shadowed declaration is here
  byte const* data;
              ^
In file included from src/zcmusic.cpp:37:0:
./include/gme/Gym_Emu.h: At global scope:
./include/gme/Gym_Emu.h:61:43: warning: unused parameter ‘gain’ [-Wunused-parameter]
  blargg_err_t init( long r, double gain = 1.5, double oversample = 5 / 3.0 )
                                           ^
./include/gme/Gym_Emu.h:61:72: warning: unused parameter ‘oversample’ [-Wunused-parameter]
  blargg_err_t init( long r, double gain = 1.5, double oversample = 5 / 3.0 )
                                                                        ^
src/zcmusic.cpp: In function ‘MP3FILE* load_mp3_file(char*)’:
src/zcmusic.cpp:830:52: error: ‘pack_fopen_password’ was not declared in this scope
     if((f = pack_fopen_password(filename, F_READ,""))==NULL)
                                                    ^
src/zcmusic.cpp: In function ‘OGGFILE* load_ogg_file(char*)’:
src/zcmusic.cpp:1027:52: error: ‘pack_fopen_password’ was not declared in this scope
     if((f = pack_fopen_password(filename, F_READ,""))==NULL)
                                                    ^
makefile:232: recipe for target 'obj/zcmusic.o' failed
make[1]: *** [obj/zcmusic.o] Error 1
make[1]: Leaving directory '/home/jordan/Development/ZeldaClassic/zelda-classic'
makefile:212: recipe for target 'linux' failed
make: *** [linux] Error 2

When DD moved the sfx stuff to the new backend, he missed continue_sfx() and adjust_sfx(). I believe that the former restarted a sound from its first bit (in a loop), and adjust_sfx() did some interesting things. We are missing a few audio effects/functions that were available before, and we still need to update our enhanced audio libs, too.

Stuff to set MIDI loops and whatnot seems to be absent.

This is not a new issue, but if you declare two functions with differing return types, and the same line params, the parser does not distinguish between them, and returns an error 'The function foo was already declared with that type of signature.'

Example:

int x = 6;
int foo() { return x; }
bool foo() { return ( x != 0 ); }

The parser sees these and does not make its duplicate function validation based on the return type, for bool and int functions.

This kind of conflict seems to crash the parser now, as soon as it hits 'Generating Symbol Tables'.

Want to transfer items between quest files but not set up each and every one individually?

Well, too bad! No method currently exists that does this.

Mostly useful if you want to change tilesets, but keep similar items.

Any attempt to call rotate_sprite_trans(), which is an allegro 4 drawing function, returns an error.

It seems to be missing from our ag4 implementation?! Please verify.

Let's face it guys. This is gonna be a pain in the ass. Hookshot, Ladder, Flippers, Sword probably gonna be the most difficult because it has so many features. Like what is it 7 or so optional things it can do?

Any advice would be appreciated.

Selecting the menu option ''File->ROM File Types instantly crashes RV.

Changing the file type from the default SNES ROMs to anything else scrambles the UI:
* UI elements are not drawn int he priper locations, and order.
* ZQuest has the same problem, from the new UI backends.
Load Palette does not support ZPL files? -- What does it support?
File output ( bitmaps ) are solid blue.

ZQuest is going to need a 24b double-blit, just as ZC has.

From here:
https://www.purezc.net/forums/index.php?showtopic=72661&page=8#entry1026835

the <tl;dr> is that if you take a scripted quest from 2.50.2 (or earlier), recompile the scripts and reassign them, that when you open the quest in 2.53.0 (branch 2.50.x), either the quest data is corrupted, or there is a ZQuest memory leak that corrupts FF Data in all quests that you try to open in ZQuest from that point onward.

The latter is what I experienced. When I recompiled, I could save, and immediately thereafter, if I try to load a quest file, or create a new quest, ZQ crashes at Loading FF Data.

Lut claims that he is experiencing ZQ crashing when it tries to save, or that the quests that he saves have corrupted data. I cannot reproduce that specific symptom.

Instead, I can create a situation where ZQuest crashes whenever it tries to load FF data from the quest file after recompiling. I suspect some kind of memory leak here, corrupting the FFC data in the quest file, but I have not been able to narrow it down, and frankly, I'm stumped.

The issue with the this (InitD) being offset, is fixed. (I remember patching that for Beta 2 or 3 with the missing push.) Thus, you can ignore that part of his post. ( He verified that Beta 4 does not have this issue. )

It might be something weird with slot assignment changes? I did not do any of the parser tinkering here, so I (1) do not recall what has changed, and (2) I am not steeped enough int he aspect of storing the bytecode and the ffc data to know what to look for; but it seems to be something bad with where ZQ is writing it. Was there some modification tot he filepack (that I did not make) that would account for this?

All of my filepack changes are in master, not 2.50.x.

When adding a MIDI file to the 2.50.x branch, ZQuest will either crash, or return that the MIDI is corrupted.

I have verified that the MIDI files are good, using 2.50.2.

Array indices no longer properly cast to ool.

If you do:

bool f(){
int arr[3];
arr[1] = 1;
if ( arr[1] ) return true;
return false;
}

The compiler will return an error: 'Cannot cast from float[] to bool'. Note the braces here. This is contrary to all ZScritpt syntax to date, and must be fixed.

It's not included in the makefile Gleeok. Probably should add that.

I just compiled the updated source on VS2015 which now can be use with cmake. I am using Windows 10 and it works great when in game. But everytime I push the win key to switch. Game crashed.

The parser crashes ZQuest if the user calls an internal function that it cannot find, or uses the wrong number of args for a valid function.

If you for example, call, SetDMapScreenD(1,1,1,40) instead of Game->SetDMapScreenD(1,1,1,40), it crashes.

if you call, Game->SetDMapScreenD(1,1,40) --missing a value -- it crashes.

The same occurs if you have a typo, such as Link->PressEc1. Crash, crash, crash.
I believe that you rewrote ParseError.cpp, so you should look into this.

I've managed to compile Zelda Classic for arm and x86-64, however it cannot load quest files because it says "Invalid Quest FIle" and sometimes "Invalid Header String". Also, after the zelda intro everything is black, although i can still press esc and quit. It seems that the program needs some data files, fonts.dat qst.dat sfx.dat zelda.dat and zquest.dat, and by looking in an hex editor it seems that all these files have machine code inside then, so i assume that these files depend on architecture, am i right? If so, can i build these files somehow? Do these files even relate to my problem?

If you set an item in init data, then change to another item and set its value, the value that you set for the prior item is not preserved. i.e. When the UI element refreshes to show the new selection, it is not maintaining prior settings changes.

To replicate this, open the init data dialogue, select arrows, set wooden arrows true; then set bows, and set a short bow true.

Close the dialogue, and reopen it. Select arrows, and the arrow that you set will not be set, but the bow will.

This chains out to as many changes as you make. Only the last change is retained.

@Gleeok

#include "precompiled.h"
#include "config.h"

#include "angelscript/aszc.cpp"
#include "angelscript/scriptData.cpp"
#include "angelscript/util.cpp"

#include "angelscript/scriptbuilder/scriptbuilder.cpp"
#include "angelscript/scriptmath/scriptmath.cpp"
#include "angelscript/scriptstdstring/scriptstdstring.cpp"
#include "angelscript/scriptarray/scriptarray.cpp"

#include "angelscript/scriptContext.cpp"
#include "angelscript/scriptGC.cpp"

//That last line gleeok causes compile errors, Cause the file simply does not exist on the repository. I'm sure you have it somewhere on your Harddrive. Might want to push that to the origin.

The new UI code that DD added do not draw properly in some instances. Here is what Quest->Init Data displays for me:

http://timelord.insomnia247.nl/zc/zc_dev/Quest-Init-Data-Drawing_error1.png
http://timelord.insomnia247.nl/zc/zc_dev/Quest-Init-Data-Drawing_error2.png

UtillVisitors line 40 has an illegal use of va_start with a reference type:

va_start(args, error);

The restrictions that ISO C places on the second parameter to the va_start() macro in header are different in this International Standard. The parameter parmN is the identifier of the rightmost parameter in the variable parameter list of the function definition (the one just before the ...). If the parameter parmN is declared with a function, array, or reference type, or with a type that is not compatible with the type that results when passing an argument for which there is no parameter, the behavior is undefined.

Moreover the compiler now has dozens of warnings about incorrect use of class vs struct. Please fix these as well.

The scrolling on dialogue/file listers, when clicking on the up/down arrow buttons is far too fast on modern systems. It scrolls so fast that the entire list zips past, and there are legitimately areas in the list that you cannot reach without using arrow keys.

Any chance of getting some versioned release tarballs of the source code? Looked into packaging Zelda Classic for Solus, an independent Linux based operating system, but we generally try to avoid working with specific commits and the like; versioned release tarballs make maintaining packages far more reasonable.

Thank you. ^^

The 'Windows Button' in the taskbar is visible (often flickering) when running ZQuest in fullscreen mode, and it is not obscured by the black backdrop. Perhaps blitting a solid black layer might fix this.

In short: trying to use the allegro headers as is kind of sucks when using Visual Studio 2015. I'm not able to compile even ZC due to the use of version detection compared to feature detection (newer builds include the necessary headers).

I would like to upgrade to a higher version of Allegro (5.0.11 is the latest stable), but I need to know what sort of dangers there are in upgrading it. If it ends up being a problem, then that kind of puts my plans on using cmake on hold.

Using the parser files dated 10th January, 2017

In ffc scripts, the values of the InitD inputs are not forwarded as local variables.

Example:

ffc script foo
{
void run(int var_a, int var_ b, int var_c)
{
int d = var_a;
int e = var_b;
int f = var_c;

int d1 = this->initD[0];
int e1 = this->initD[1];
int f1 = this->initD[2];
}
}

When referencing one of the variables that is used as a line param for run(), by its Identifier, the variable will always be a value of 0. Thus, variables d, e, and f will all be '0, whilst d1, d2, and d3 will all have the proper InitD values. I suspect it is related to the change that destroys variables when their scope exits, and I need to verify that this is not in master as well.

This likely also affects item scripts.

This affects both zelda and zquest. In zquest, if you try to play music from the Etc>The Travels of Link menu, nothing happens. Same result if you try to play a midi from a quest through Quest>Audio>MIDIs. In zelda, if you play a quest with midi music, the music does not play.

This problem does not occur in 2.50.2.

Investigation:
I was able to bisect the problem and found that the last good commit was 1ca34af, and the first known bad commit is f95b800 (as the previous commit could not be built). Combing through the changes I discovered that this was introduced with the removal of two methods, file_size_ex_password and pack_fopen_password, from file.c and the introduction of alleg_compat.cpp. So there seems to be some problem with alleg_compat.cpp's re-implementation of these methods.

OS: Xubuntu 16.04 64-bit
commit: c8701fc

@Saffith
More of a question really, but is this going to be the equivalent of a questrules2 enum. Gleeok has mentioned doing such in the past.

Following the steps as written in the readme:

cd build
cmake ..
make

make fails with fatal error: allegro/platform/alunixac.h: No such file or directory

Copying alunixac.h from allegro/extra to allegro/include/allegro/platform allows it to build. But the resulting zelda binary does not have sound, and looking at it with ldd reveals that, for some reason, libasound is not linked.

On the 2.50.2 build from the website, sound does work and it has libasound linked.

I did try getting a fresh copy of allegro 4.4.2 to generate an alunixac.h. The result did define a few alsa variables the other did not. But copying that to allegro/include/allegro/platform still gave me the same result.

Linux Version: Xubuntu 16.04 64-bit
Commit: c8701fc

In the menu under Quest->Graphics->Sprites->Weapons/Misc is the sprite editor. This is used a lot to make custom graphics for things like weapons and items. Also, referencing a specific sprite number is often done by scripts to set these things up.

However, the menu only shows the name and visual appearance of each sprite. This means that to find out the specific sprite number, you have to click on one of them to see that info.

Having the sprite number displayed at all times once that menu was opened would make things easier, since you could determine which sprite numbers were already being used or shouldn't be changed more readily.

Since the enemy editor and item editor already have this option, I'm not sure why it isn't included in the sprite editor.

Grayswandirs changes to the parser do not compile on MSVC9.

1>------ Build started: Project: ZERO_CHECK, Configuration: Release Win32 ------
1>Checking Build System
1>CMake does not need to re-run because C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/CMakeFiles/generate.stamp is up-to-date.
1>Build log was saved at "file://c:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\ZERO_CHECK.dir\Release\BuildLog.htm"
1>ZERO_CHECK - 0 error(s), 0 warning(s)
2>------ Build started: Project: zcsound, Configuration: Release Win32 ------
3>------ Build started: Project: romview, Configuration: Release Win32 ------
3>Compiling...
2>Compiling...
3>UB_RomviewGUI.cpp
2>UB_SoundLibCore.cpp
2>Creating library...
2>Build log was saved at "file://c:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\zcsound.dir\Release\BuildLog.htm"
2>zcsound - 0 error(s), 0 warning(s)
4>------ Build started: Project: zelda, Configuration: Release Win32 ------
5>------ Build started: Project: zquest, Configuration: Release Win32 ------
5>[FLEX][ZScriptLexer] Building scanner with flex 2.5.37
4>Compiling...
4>UB_ZeldaSubscreen.cpp
5>[BISON][ZScriptParser] Building parser with bison 2.7
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:441.66: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:441.66: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:443.66: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:443.66: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:447.78: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:447.78: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:458.68: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:458.68: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:460.68: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:460.68: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:462.58: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:462.58: future versions of Bison will not add the ';'
3>UB_RomviewCore.cpp
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:464.53: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:464.53: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:466.59: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:466.59: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:473.68: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:473.68: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:475.70: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:475.70: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:477.70: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:477.70: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:482.66: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:482.66: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:484.68: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:484.68: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:489.70: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:489.70: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:491.70: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:491.70: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:496.62: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:496.62: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:498.62: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:498.62: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:500.62: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:500.62: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:502.62: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:502.62: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:507.62: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:507.62: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:509.62: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:509.62: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:514.71: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:514.71: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:519.72: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:519.72: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:524.70: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:524.70: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:529.66: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:529.66: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:534.64: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:534.64: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:539.72: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:539.72: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:541.80: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:541.80: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:543.82: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:543.82: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:545.82: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:545.82: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:547.84: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:547.84: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:549.84: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:549.84: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:551.84: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:551.84: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:553.84: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:553.84: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:555.84: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:555.84: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:557.84: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:557.84: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:559.82: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:559.82: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:561.78: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:561.78: future versions of Bison will not add the ';'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:563.76: warning: a ';' might be needed at the end of action code
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ffscript.ypp:563.76: future versions of Bison will not add the ';'
5>Compiling...
5>lex.yy.cpp
5>y.tab.cpp
4>UB_ZeldaSprite.cpp
3>Generating Code...
5>.\src\parser\y.tab.cpp(1634) : warning C4065: switch statement contains 'default' but no 'case' labels
5>UB_ZQuestZScript.cpp
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/ByteCode.cpp(1925) : error C2084: function 'std::string OGetFFCScript::toString(void)' already has a body
5> c:\users\dell\desktop\zc_2.54\2.54_merge\src\parser\ByteCode.h(2448) : see previous definition of 'toString'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/DataStructs.cpp(29) : warning C4018: '<' : signed/unsigned mismatch
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/DataStructs.cpp(50) : warning C4018: '<' : signed/unsigned mismatch
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/DataStructs.cpp(116) : warning C4018: '>' : signed/unsigned mismatch
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/DataStructs.cpp(170) : warning C4018: '>' : signed/unsigned mismatch
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/GlobalSymbols.cpp(2004) : error C2065: 'memberids' : undeclared identifier
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/GlobalSymbols.cpp(2020) : error C2065: 'memberids' : undeclared identifier
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/GlobalSymbols.cpp(2035) : error C2065: 'memberids' : undeclared identifier
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/GlobalSymbols.cpp(2050) : error C2065: 'memberids' : undeclared identifier
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/GlobalSymbols.cpp(3124) : error C2065: 'memberids' : undeclared identifier
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/GlobalSymbols.cpp(3139) : error C2065: 'memberids' : undeclared identifier
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/GlobalSymbols.cpp(3203) : error C2065: 'memberids' : undeclared identifier
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/Types.cpp(6) : error C2039: 'to_string' : is not a member of 'std'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/Types.cpp(6) : error C2873: 'to_string' : symbol cannot be used in a using-declaration
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/parser/Types.cpp(110) : error C3861: 'to_string': identifier not found
5>UB_ZQuestMisc.cpp
4>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/script_drawing.cpp(17) : warning C4005: 'DegtoFix' : macro redefinition
4> C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/maps.cpp(43) : see previous definition of 'DegtoFix'
4>UB_ZeldaGUI.cpp
5>c:\users\dell\desktop\zc_2.54\2.54_merge\src\parser\Types.h(81) : error C2628: 'ZVarTypeSimple' followed by 'void' is illegal (did you forget a ';'?)
5>c:\users\dell\desktop\zc_2.54\2.54_merge\src\parser\Types.h(81) : error C2208: 'const ZVarTypeSimple' : no members defined using this type
5>c:\users\dell\desktop\zc_2.54\2.54_merge\src\parser\Types.h(92) : error C2059: syntax error : 'constant'
5>c:\users\dell\desktop\zc_2.54\2.54_merge\src\parser\Types.h(92) : error C2238: unexpected token(s) preceding ';'
5>c:\users\dell\desktop\zc_2.54\2.54_merge\src\zquestdat.h(10) : warning C4005: 'BMP_MOUSE' : macro redefinition
5> c:\users\dell\desktop\zc_2.54\2.54_merge\src\zeldadat.h(7) : see previous definition of 'BMP_MOUSE'
5>UB_ZQuestGUI.cpp
4>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(5) : error C2062: type 'int' unexpected
4>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(5) : error C2062: type 'int' unexpected
4>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(5) : error C2059: syntax error : ')'
4>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(5) : error C2143: syntax error : missing ';' before '{'
4>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(5) : error C2447: '{' : missing function header (old-style formal list?)
4>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(6) : error C2062: type 'int' unexpected
4>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(6) : error C2062: type 'int' unexpected
4>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(6) : error C2059: syntax error : ')'
4>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(6) : error C2143: syntax error : missing ';' before '{'
4>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(6) : error C2447: '{' : missing function header (old-style formal list?)
4>UB_ZeldaCore.cpp
3>Compiling resources...
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(5) : error C2062: type 'int' unexpected
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(5) : error C2062: type 'int' unexpected
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(5) : error C2059: syntax error : ')'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(5) : error C2143: syntax error : missing ';' before '{'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(5) : error C2447: '{' : missing function header (old-style formal list?)
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(6) : error C2062: type 'int' unexpected
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(6) : error C2062: type 'int' unexpected
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(6) : error C2059: syntax error : ')'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(6) : error C2143: syntax error : missing ';' before '{'
5>C:/Users/DELL/Desktop/ZC_2.54/2.54_Merge/src/backend/SFXBackend.cpp(6) : error C2447: '{' : missing function header (old-style formal list?)
5>UB_ZQuestCore.cpp
3>Microsoft (R) Windows (R) Resource Compiler Version 6.0.5724.0
3>Copyright (C) Microsoft Corporation. All rights reserved.
3>Linking...
3>al_gif.lib(algif.obj) : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance
3>Generating code
4>Generating Code...
3>Finished generating code
5>Generating Code...
3>al_gif.lib(algif.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\al_gif.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngtrans.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngget.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(png.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngwtran.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libjpgal.lib(encode.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libjpgal.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>loadpng.lib(loadpng.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\loadpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>al_gif.lib(lzw.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\al_gif.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngrutil.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngwutil.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngread.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngset.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngwio.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libjpgal.lib(decode.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libjpgal.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>loadpng.lib(savepng.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\loadpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>al_gif.lib(gif.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\al_gif.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngmem.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngrio.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngrtran.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngerror.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libpng.lib(pngwrite.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libjpgal.lib(io.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libjpgal.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>libjpgal.lib(jpgalleg.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\libjpgal.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>loadpng.lib(regpng.obj) : warning LNK4099: PDB 'vc80.pdb' was not found with 'libs\win32\loadpng.lib' or at 'C:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\Release\vc80.pdb'; linking object as if no debug info
3>Embedding manifest...
3>Build log was saved at "file://c:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\romview.dir\Release\BuildLog.htm"
3>romview - 0 error(s), 24 warning(s)
5>Build log was saved at "file://c:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\zquest.dir\Release\BuildLog.htm"
5>zquest - 25 error(s), 45 warning(s)
4>Build log was saved at "file://c:\Users\DELL\Desktop\ZC_2.54\2.54_Merge\zelda.dir\Release\BuildLog.htm"
4>zelda - 10 error(s), 1 warning(s)
========== Build: 3 succeeded, 2 failed, 1 up-to-date, 0 skipped ==========

Hello everyone,

My OS is Debian Jessie x64 with Pulseaudio.
In case it's important, I use an usb audio device.

When I launch the game and look in pavucontrol, it look like the sound playback go up and down.
To stabilize it I need to turn off my device and set it on again.
After a few times I have the sound correctly.

I use only pulseaudio so I don't know if we have the same problem with pure alsa or oss.

Cheers.

// Returns true if enemy is floating and blocked by a combo type or flag.
bool flyerblocked(int dx, int dy, int special)
{
    return ((special==spw_floater)&&
            ((COMBOTYPE(dx,dy)==cNOFLYZONE)||
             (combo_class_buf[COMBOTYPE(dx,dy)].block_enemies&4)||
             (MAPFLAG(dx,dy)==mfNOENEMY)||
             (MAPCOMBOFLAG(dx,dy)==mfNOENEMY)));
}

bool m_walkflag(int dx,int dy,int special, int x, int y)
{
    int yg = (special==spw_floater)?8:0;
    int nb = get_bit(quest_rules, qr_NOBORDER) ? 16 : 0;

    if(dx<16-nb || dy<zc_max(16-yg-nb,0) || dx>=240+nb || dy>=160+nb)
        return true;

    if(isdungeon() || special==spw_wizzrobe)
    {
        if((x>=32 && dy<32-yg) || (y>-1000 && y<=144 && dy>=144))
            return true;

        if((x>=32 && dx<32) || (x>-1000 && x<224 && dx>=224))
            if(special!=spw_door)                                 // walk in door way
                return true;
    }

    switch(special)
    {
    case spw_clipbottomright:
        if(dy>=128 || dx>=208) return true;

    case spw_clipright:
        break; //if(x>=208) return true; break;

    case spw_wizzrobe:
    case spw_floater:
        return false;
    }

    dx&=(special==spw_halfstep)?(~7):(~15);
    dy&=(special==spw_halfstep || tmpscr->flags7&fSIDEVIEW)?(~7):(~15);

    if(special==spw_water)
        return (water_walkflag(dx,dy+8,1) || water_walkflag(dx+8,dy+8,1));

    return _walkflag(dx,dy+8,1) || _walkflag(dx+8,dy+8,1) ||
           groundblocked(dx,dy+8) || groundblocked(dx+8,dy+8);
}

If they're not No Flying Enemy combos that is to say. Also effects Teleporting wizzrobes in some cases.
I believe this is the cause.

if((x>=32 && dy<32-yg) || (y>-1000 && y<=144 && dy>=144))

In the quest editor, under the menu Quest, go down to Graphics and Sprites.

The settings for Weapons/Misc can't be exported currently, to my knowledge.

I'm not sure how useful this would be, actually. (Since the tiles would almost certainly be different between quests.)

I guess it could let you retain the names and animation settings, along with their placement in the order they were in the original quest.

When ZQuest exits, ag.cfg is being corrupted with binary code.

Opening the file after this occurs, it is a mangled mess, and after this happens, ZQ and ZC will not display properly. Is this also some attempt to write through the packfile encryption, like the MIDI issue?

This happens during the ZQuest close action.

ag.cfg before and after:
http://timelord.insomnia247.nl/zc/zc_dev/ag_cfg_issue

One of the most annoying things I've found when creating multiple quests is the fact that I either have to use the same file for all my quests or import each and every music and sfx file that I want to change from the default.

Is there a way to make it where you can export (and import) these files to prevent this hassle?

I can get the program compiled. I'm using vs2008 as the newer version give me even problem.
In the lib folder we miss alld.lib. If I download and use the allegro 4.2.2 version I get missed symbol.
__imp_pack_fopen_password() and cannot compile.
On zquest I get missing sysmbol from FFCSet::FFCSet, FFCSet:clear.

That's right, they're missing quite a few stuff.
Mostly the new stuff such as the angelscript stuff and other new code files.

Gleeok has to fix this one, then I'll generate codeblocks projects.

Make a seperate branch @Gleeok please.

Using ADDASSIGN, MINUSASSIGN, or similar with internal ZScript arrys crashes ZC instantly.

Example:

Link->Misc[0]++; //This crashes ZC
Link->Misc[0] += 9; //This crashes ZC.
Link->Misc[0] = 9; //This does not crash ZC

I still cannot build a debug version in msvc
MSVC crashes whenever I try.
with this:

2>LINK : fatal error LNK1000: Internal error during IncrBuildImage
2> Version 9.00.21022.08
2> ExceptionCode = C0000005
2> ExceptionFlags = 00000000
2> ExceptionAddress = 4C003FC0
2> NumberParameters = 00000002
2> ExceptionInformation[ 0] = 00000008
2> ExceptionInformation[ 1] = 4C003FC0
2>CONTEXT:
2> Eax = 4C003FC0 Esp = 003AEE10
2> Ebx = 40008184 Ebp = 003AEE3C
2> Ecx = 00DED670 Esi = 4064510C
2> Edx = 003AEE2C Edi = 00EFD6C0
2> Eip = 4C003FC0 EFlags = 00010246
2> SegCs = 00000023 SegDs = 0000002B
2> SegSs = 0000002B SegEs = 0000002B
2> SegFs = 00000053 SegGs = 0000002B
2> Dr0 = 00000000 Dr3 = 00000000
2> Dr1 = 00000000 Dr6 = 00000000

See
http://timelord.insomnia247.nl/zc/zc_dev/msvc_debug_errors.txt
for the full log of trying to build in debug mode

Using:

Microsoft Visual Studio 2008
Version 9.0.21022.8 RTM
Microsoft .NET Framework
Version 3.5 SP1

Installed Edition: Professional

This is the error message I get. Which I get only once.
....\allegro/allegro/platform/alwin.h:49:86: error: conflicting declaration of C function 'int WinMain(void_, void_, char*, int)

• MacOS app should use MacOS app style defaults
  • Move files (quests logs saves etc) to ~/Library/Application\ Support/Zelda\ Classic
  • Use MacOS notification to ask 'Are you sure' When quitting

Will update further as noticed

The path /src/build_modules is specified by the VS2008 project for the 2.50.x branch, but those files only exist under the master branch.

The UI element for ROM File Types displays all the way on the bottom-right, and in the default view, you can only see its titlebar.

Image:
http://timelord.insomnia247.nl/zc/zc_dev/romview_issue_3.png

There is no resolution option in the menus to fix this.

Hello, I have a weird issue.
When I launch ZC with zelda-l or zlauncher it work without issue.
But when I run it with Steam as non-steam game, I see the Armageddon logo very slowly.

I do ctrl + alt + F1, the sound seem good so I go back with ctrl + alt + F7 but the game is freeze.
(Seem if I try to kill it with pkill -9 it hold the the loge screen in a freeze).

I launch the game in Steam do make the configuration of the Steam controller.
I tried to do the configuration in ZC directly but it seem not recognize all the buttons.

If you need more informations, let me now.
Cheers.

This is meant as a "sibling" of #11 here: in order for Allegro to play nice with Windows, we have to play nice with Allegro.

I've done some initial scouting on how we can use a modern, up to date version of Allegro. It would really help with building on Windows, especially for those that prefer using the MSVC tools.

The #allegro channel on Freenode took a quick gander at the source code to get an idea. Most of the graphics calls we make should be convert-able with some A4 to A5 tool that was made. Manual steps are also provided on their wiki. However, the biggest issue is that instead of drawing on bitmaps and bliting them (or drawing sprites) to the screen, you write to the screen the entire time. The dialog box features...there was some slight disagreement as to whether they could be directly converted or not, but it shouldn't be too difficult to come up with something new if necessary. The big one deals with pixel manipulation.

In looking at tiles.cpp, a lot of lines in the form of b->line[y][x] were noticed. That's a general pattern for accessing pixels directly in memory. In Allegro 5, that can't be done right away: instead, the bitmap would have to be "locked", manipulated, and then "unlocked". It's likely to be a slow operation. Instead, it was suggested to use the new primitives Allegro 5 brought, and/or utilize pixel shaders.

The A4 to A5 tool does not work with palettes or direct bitmap access. That is what has to be worked around. Everything else should have an automatic or clearly stated conversion. If we solve the palette/bitmap issue, Allegro 5 will work for us.

Changing the CSet of an enemy in the enemy editor, does not work.

Normally, if you click on a tile, change its CSet , and return tot he editor, the cset that you selected is forwarded. This no longer happens, and the CSet is stuck at its default.

Rather than giving an error/warning, and cleanly exiting, ZC outright crashes immediately after passing the title screen (Zelda Classic logo, not AGN flame banner) if the file libzcsound.dll is not present.

It is likely missing a check for the file before doing things that need it. This may also be true for other files, but I'm rather certain that without the allegro libs, ZC won;t run at all, so it cannot crash.

These should be output when compiling, but they are not; and libzcsound.dll is not present in the package (under /bin, with the allegro libs).