Giter VIP home page Giter VIP logo

Comments (5)

danielesteban avatar danielesteban commented on June 16, 2024 1

Just tested all the minimal examples with the #178 patch and everything works as intended as far as I can tell.

Also tested the more complex ones that originated the issue and everything is also working as intended:
screenshot-(33)

You're so welcome. I'm glad I was able to help.
And thank you for this amazing library! I just couldn't have done all this geometry without it.

from three-bvh-csg.

gkjohnson avatar gkjohnson commented on June 16, 2024 1

Awesome! Just published a new version

from three-bvh-csg.

danielesteban avatar danielesteban commented on June 16, 2024

Ah! And if you're curious this is what I changed from the #173 example that got fixed.
danielesteban/csgtest@36d597c#diff-27653c212e1cfe533e4eb2f7d0d3f89604c9de48a09583b4cbbbcbd08a07da79
Just added a cone at the bottom of the base and moved the camera to better illustrate the issue.

from three-bvh-csg.

danielesteban avatar danielesteban commented on June 16, 2024

Been doing some digging and made an even simpler example. This one is just an addition between a box and a cone:
https://jsfiddle.net/z4cnpsra/38/

Here's with v0.0.10:
image

Here's with v0.0.12:
image

In the new version it creates sort of like an interior face when merging the box and the cone.
I dunno if any of this is related. but seems it could be the root of the issue I posted on the previous example.

from three-bvh-csg.

gkjohnson avatar gkjohnson commented on June 16, 2024

Should be fixed now in #178. Can you give it a check before I merge and publish? A simple way is to just use the commit link index.js from that PR via githack to test the functionality:

https://raw.githack.com/gkjohnson/three-bvh-csg/d2f7d1221476e22b8769402b8d7342b593d0c72b/src/index.js
image

There was another longer standing bug that this exposed relating to coplanar faces, as well. Thanks again for submitting minimal repros and hunting down the commits!

from three-bvh-csg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.