Giter VIP home page Giter VIP logo

Comments (8)

codand avatar codand commented on June 16, 2024 1

Can you please produce a simpler example that just includes the two geometries and the clipping operation and the wireframe?

Sure. here's a stripped down version.

from three-bvh-csg.

gkjohnson avatar gkjohnson commented on June 16, 2024 1

Looks like the eges issue can't be easily reproduced at the moment - we can track it down when it arrises another time:

image

from three-bvh-csg.

gkjohnson avatar gkjohnson commented on June 16, 2024

Interesting - I'm also seeing that "intersectionEdges" is reporting some odd extraneous edges:

image

Can you please produce a simpler example that just includes the two geometries and the clipping operation and the wireframe?

isWaterTight reports true for this mesh,

Also note that is water tight is not documented and not currently fully functional.

from three-bvh-csg.

gkjohnson avatar gkjohnson commented on June 16, 2024

I fixed #183 in v0.0.15 which seemed to be related but it does not seem to have fixed this issue. Are you seeing this same kind of issue with any simpler models? Ideally generated models from the three.js primitives?

from three-bvh-csg.

codand avatar codand commented on June 16, 2024

I've not yet seen it happen from a single subtraction between two threejs primitives, but I have seen it happen after multiple consecutive subtractions. I'll see if I can produce a simpler example on the latest update this week. Thank you for investigating!

from three-bvh-csg.

gkjohnson avatar gkjohnson commented on June 16, 2024

It looks this this is happening as part of the "full triangle" accumulation step - ie the step where unclipped triangles are appended to the result.

image

These edges look like they intersect the the clip volume but the intersection detection skips triangles marked as "degenerate". It seems they're inadvertently being added to the result geometry elsewhere, instead.

image

They're gone if we filter triangles with area === 0 when building the result geometry:

image

These degenerate triangles are in the original model, as well - 563 of them. I guess these will have to be filtered out during the clip process. I'll just have to think abut the right place to do it.

from three-bvh-csg.

gkjohnson avatar gkjohnson commented on June 16, 2024

#193 should fix it:

image image

from three-bvh-csg.

gkjohnson avatar gkjohnson commented on June 16, 2024

I still want to check out the "intersection edges" issue listed above, though.

from three-bvh-csg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.