ni / reviewboard-userscripts Goto Github PK
View Code? Open in Web Editor NEW✨ Userscripts to enhance the Review Board experience ✨
License: MIT License
✨ Userscripts to enhance the Review Board experience ✨
License: MIT License
As an overloaded code owner, I would like a way to automatically re-classify / re-prioritize reviews that have open issues from other reviewers, so that I can focus on the reviews that are ready for my attention.
Perhaps by adding a fourth category, in addition to "Incomplete", "Reviewed" and "Ship It!"
In a current review, the latest Linux prebuild run suceeded, yet it still shows an X in the meta-data
For some reason, the latest prebuild
reviews are not being parsed as build results.
When viewing a large screenshot, both vertical and horizontal scrollbars are always visible. However, with this user script, only the vertical scrollbar is visible at all times; the horizontal scrollbar is only visible when you scroll to the bottom of the image.
Without userscript, both scrollbars are always visible:
With userscript, only vertical scrollbar is visible at first:
...but when I scroll to the bottom of the image, the horizontal scrollbar is also visible.
If applicable, add any relevant messages or errors you see in the browser's JavaScript console.
NI has an official JS style guide that is in-work, based on Airbnb. We should upgrade to use it:
Kiran: if i give a ship it... then a fix it... on my dashboard the review shows up as in the "ship it" section. not sure if there is anything you can do about that, just FYI
Me: just by having open issues?
Kiran: yes
I have zero outgoing reviews open in RB, but counter on the Outgoing dashboard shows incomplete 1.
Comparing Chrome with no extension to Firefox with this extension
If applicable, add any relevant messages or errors you see in the browser's JavaScript console.
(Tracking the work I did here in this issue.)
The edit pencil is missing for the main description. This includes when initially adding the review, and double clicking doesn't always enable editing.
Yes. Review overload. My team gets a lot of reviews (as I'm sure most teams do). In our retrospective, most people expressed wanting to be alerted to the reviews, but also want to be able to sort reviews that they have to review vs reviews where they are optional.
Be able to sort reviews on the reviewboard mainpage based on whether you're an owner, an alternate, or a reviewer.
An email rule that flags a reviewboard email if you're an owner.
On a 4k monitor, using Firefox, the 'My Dashboard' window does not scale to fit the whole window width, making it hard to read.
If applicable, add any relevant messages or errors you see in the browser's JavaScript console.
In Firefox 76.0.1 on Windows, the dashboard (incoming review list / default landing page) doesn't take up the full windows width that it does without the plugin (seems optimized for mobile?), and the far right status column is cut off by the scrollbar. See screenshot. This is all if you have not enabled the My Comments column.
Follow the instructions on the nag dialog about dashboard sorting by adding the My Comments column. With the My Comments field added, the width rendering becomes more sane. If you don't have that field enabled, it will nag you on every reload and have the messed up width. If you remove that column, the problem will come back.
If applicable, add screenshots to help explain your problem.
Comparison of workaround after adding the sortability "My Comments" column:
If applicable, add any relevant messages or errors you see in the browser's JavaScript console.
The dark theme uses a midnight blue / inky color but the categories view in the RB dashboard for what review groups you belong to are still rendered in black, so they are almost impossible to read as dark text on a dark background unless you zoom way in.
Screenshot has group names censored, but the Incoming categories "Open" and "To Me" show the problem just as well. Not sure why we have weird negative counts in some cases but I don't believe it's anything to do with this userscript.
If applicable, add any relevant messages or errors you see in the browser's JavaScript console.
N/A
Since I recolored submitted reviews to green, there is now a conflict with the existing green banner representing a draft review.
Color the draft review banner yellow.
Reverting the green back to gray, but it should be green to better match AzDO and societal expectation of what green means (success).
Userscript version: v1.1.10
When leaving a comment to a review, if you have a longer string (multi-line? Not sure if it' sa character cutoff or line thing), the summary box shown after you click OK but before you click Publish/Discard/Close will get really wide and shift to the right, regardless of your setting for review with to be optimized for readability or full width (original)
Steps to reproduce:
If applicable, add any relevant messages or errors you see in the browser's JavaScript console.
I was removed (declined) from a review by another reviewer/alternate, but the review still appears in my incoming list. I assume that if I've been removed from the review, I wouldn't still need to see it in my incoming list.
In this review: https://review-board.natinst.com/r/339057/
Valerie Juarez declined jdowns (out of office) on June 15, but on June 17, I still see the review in the Incomplete bucket of the incoming review list.
When viewing incoming reviews, if I select a review and archive/unarchive it, the page stops filtering reviews until I refresh the page. Is this a known limitation? I see a text box pop up that says "When you are done changing/rearranging columns, reload the page to refresh the review list", but I'm archiving reviews, not rearranging columns.
We should change the text or be able to handle a review being archived/unarchived.
With this script enabled, there's no distinguishable link formatting for links that are also code segments. Example markdown:
[`boost::none`](https://www.boost.org/doc/libs/1_74_0/boost/none.hpp)
With the script disabled/enabled:
None
I'd like the ability to easily link to any arbitrary review comment. Currently, clicking an issue in the issues list for a review will link to (and highlight, but that's less important) the relevant comment. I'd like to have a way to link to specific comments without having to inspect the page source and find the comment ID myself.
For comments on issues, make the timestamp text a link to the issue:
For issues, add some element to each issue which is also a link to the comment. The timestamp doesn't make as much sense here since all of the issues from one review will have the same timestamp, but it may be worth having for consistency.
None.
Add any other context or screenshots about the feature request here.
I can't see the full width of the diff associated with a comment on the Reviews page of a review. It wraps sometime later, but I can't see the full file path or the rightmost part of the diff.
I'm wondering if it's related to this rendering oddity where the comments are narrower than the review summary:
It makes sense to organize my incoming reviews around whether I have responded or given a ship it, but this doesn't make sense for outgoing reviews. I did try removing the 'My Comments' column in the Outgoing view, but apparently this setting is global, since it was also then removed from the Incoming view.
rossh is a Reviewer and gave a Ship It, but the Note to Reviewers doesn't have a check next to his name, even though it is there in the Reviewers section on the right-hand side
No
People aren't reviewing my code fast enough.
A button like we have in AzDo to remind them to review my code.
None
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.