Giter VIP home page Giter VIP logo

Comments (35)

ifthompson avatar ifthompson commented on June 29, 2024 1

Oops, it generated fine offline with the docker image, but I found and removed a tab character that may have caused this error.

from joss-reviews.

kthyng avatar kthyng commented on June 29, 2024 1

@ifthompson Sorry for my delay. Your submission has passed the scope review and I will start looking for an editor. However, I do need to place this on our waitlist to wait for a relevant editor. Thanks for your patience, again!

from joss-reviews.

Mariosmsk avatar Mariosmsk commented on June 29, 2024 1

Hi @jsta, yes I am interested.

from joss-reviews.

editorialbot avatar editorialbot commented on June 29, 2024

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

from joss-reviews.

editorialbot avatar editorialbot commented on June 29, 2024
Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (680.7 files/s, 49268.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          17            358            240            702
SVG                              4              4              4            298
CSS                              2             54             11            244
reStructuredText                 8            227            235            220
YAML                             3             18              6             81
TeX                              1              0              0             52
Markdown                         2             18              0             48
DOS Batch                        1              8              1             26
JSON                             1              0              0             20
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            40            691            504           1700
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

from joss-reviews.

editorialbot avatar editorialbot commented on June 29, 2024

Wordcount for paper.md is 561

from joss-reviews.

editorialbot avatar editorialbot commented on June 29, 2024

⚠️ An error happened when generating the pdf.

from joss-reviews.

ifthompson avatar ifthompson commented on June 29, 2024

@editorialbot generate pdf

from joss-reviews.

editorialbot avatar editorialbot commented on June 29, 2024

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

from joss-reviews.

kthyng avatar kthyng commented on June 29, 2024

Hi @ifthompson and thanks for your submission! Because the size of the package is relatively small (lines of code < 1000) I need to ping the editorial board to vote on whether the submission is in scope in terms of substantial scholarly effort. This will take 1-2 weeks, thanks for your patience.

from joss-reviews.

kthyng avatar kthyng commented on June 29, 2024

@editorialbot query scope

from joss-reviews.

editorialbot avatar editorialbot commented on June 29, 2024

Submission flagged for editorial review.

from joss-reviews.

kthyng avatar kthyng commented on June 29, 2024

@editorialbot add @jsta as editor

from joss-reviews.

editorialbot avatar editorialbot commented on June 29, 2024

Assigned! @jsta is now the editor

from joss-reviews.

kthyng avatar kthyng commented on June 29, 2024

@ifthompson You have an editor now – @jsta – who will be taking over from here.

from joss-reviews.

jsta avatar jsta commented on June 29, 2024

Hi @ifthompson 👋, After reading the paper, I'm interested to hear more about the code operation over the course of the review. In the meantime, do you have any suggested reviewers?

from joss-reviews.

ifthompson avatar ifthompson commented on June 29, 2024

Hi @jsta 👋 , the conceptual overview section of the docs explains some of the ideas in the paper in more detail. Usually it is most convenient to control operation with a configuration file, and then just run tethys.run_model('configuration_file.yml). I'm happy to discuss the code more if you have specific questions. Also, pinging coauthor @zarrarkhan here who can also answer questions.

I don't know a lot of people so I don't have any suggested reviewers in mind. Can you pick volunteers?

from joss-reviews.

jsta avatar jsta commented on June 29, 2024

Thanks @ifthompson, it would be very helpful if you could provide reviewer suggestions for people in the subfield with whom you and your co-authors are unaffiliated. It's preferable that they already be active on Github but not strictly required.

from joss-reviews.

jsta avatar jsta commented on June 29, 2024

👋 @eldemet Would you be willing to review this submission to JOSS?

from joss-reviews.

jsta avatar jsta commented on June 29, 2024

👋 @Mariosmsk Would you be willing to review this submission to JOSS?

from joss-reviews.

jsta avatar jsta commented on June 29, 2024

Thanks so much @Mariosmsk ! it may be a little while until the review starts. Still need to find another reviewer.

from joss-reviews.

jsta avatar jsta commented on June 29, 2024

@editorialbot add @Mariosmsk as reviewer

from joss-reviews.

editorialbot avatar editorialbot commented on June 29, 2024

@Mariosmsk added to the reviewers list!

from joss-reviews.

jsta avatar jsta commented on June 29, 2024

👋 @nickrsan Would you be willing to review this submission to JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

from joss-reviews.

nickrsan avatar nickrsan commented on June 29, 2024

@jsta thanks for thinking of me. I'd be willing to and the software looks interesting, but I'll note that downscaling isn't my area of expertise. I can possibly recommend another reviewer who knows Python and downscaling if you'd prefer.

from joss-reviews.

jsta avatar jsta commented on June 29, 2024

@nickrsan Thanks for the offer! Yes, please, other reviewer suggestions would be most welcome.

from joss-reviews.

nickrsan avatar nickrsan commented on June 29, 2024

The person I know who would have expertise in these areas is @khegewisch, if she's available. I'd still be happy to review the parts of it that are in my wheelhouse if you need a reviewer, but if Katherine has time/interest, I think she could better evaluate the methods, in addition to expertise in the software components.

from joss-reviews.

khegewisch avatar khegewisch commented on June 29, 2024

Hi, I'm sorry. I do not have time to do this.

from joss-reviews.

jsta avatar jsta commented on June 29, 2024

Thanks for the suggestion @nickrsan. Unfortunately, it seems Katherine is unavailable. Can I add you as a reviewer?

from joss-reviews.

nickrsan avatar nickrsan commented on June 29, 2024

Yes, I'm still willing, but likely can't review until at least October due to current commitments. If that's acceptable, I'd be happy to review the paper and code.

from joss-reviews.

jsta avatar jsta commented on June 29, 2024

That sounds reasonable to me! Thanks.

from joss-reviews.

jsta avatar jsta commented on June 29, 2024

@editorialbot add @nickrsan as reviewer

from joss-reviews.

editorialbot avatar editorialbot commented on June 29, 2024

@nickrsan added to the reviewers list!

from joss-reviews.

jsta avatar jsta commented on June 29, 2024

@editorialbot start review

from joss-reviews.

editorialbot avatar editorialbot commented on June 29, 2024

OK, I've started the review over in #5855.

from joss-reviews.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.