Giter VIP home page Giter VIP logo

Comments (5)

jdyb avatar jdyb commented on July 21, 2024

I have considered adding this myself as well.
But does it not belong in naoqi_bridge/naoqi_driver? (naoqi_joint_stiffness.py/cpp perhaps?)
That way it is available to all robots.

from nao_robot.

k-okada avatar k-okada commented on July 21, 2024

Yes, that's nice direction, and I found that current naoqi_joint_states.py is not just publish joint_states, but also publish imu or other topics, so I added to publish joint_stiffness too

see ros-naoqi/naoqi_bridge#23

from nao_robot.

Karsten1987 avatar Karsten1987 commented on July 21, 2024

Just a few comments on that:

If I understood your idea, then it ought to be inside naoqi_bridge. The idea of this package would be to provide robot agnostic features and packages which can be freely configured per robot using rosparams.

Regarding joint_states.py, it publishes joint_states, TF, odom and IMU. I would prefer if we could incorporate the joint_stiffness into the effort component of the joint_states topic since it's a fraction of the motor's maximal current.
At the same time we could extract the IMU into a dedicated node to keep it clean.

any ideas on that?

from nao_robot.

jdyb avatar jdyb commented on July 21, 2024

We have moved to naoqi_bridge, se the linked pr (this could probably be closed).
Note that the original pr only conserned the stiffness of the joints, not the applied effort.
In this case, stiffness (ALMotionProxy::get/set-Stiffness) is the maximum current allowed for a specific joint. I dont think we want stiffness in the joint_states topic, but rather the torque derived from the electric current value from naoqi.

from nao_robot.

vrabaud avatar vrabaud commented on July 21, 2024

moving to naoqi_bridge as mentioned above

from nao_robot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.