skidamek / automodpack Goto Github PK

sometimes after modpack update loading screen does not disappear...

Modpack delete doesn't work properly. Doesn't delete all mods


some mods gets trashed but some not

AutoModpack can't download as fast as game start so game get crashed

latest.log

Is your feature request related to a problem? Please describe.
Automatic uploading to Google drive would be really good to avoid wasting time doing so.

Describe the solution you'd like

• User/admin needs to have an oauth application and generate gcp credentials to allow access to its account.
• Credentials file should exist on server only and maybe in the mod config folder such as config/automodpack/credentials.json
• Code to upload files is shown here: https://developers.google.com/drive/api/quickstart/java and https://developers.google.com/drive/api/guides/manage-uploads

Describe alternatives you've considered
Another alternative that may be easier for developers is using Amazon S3 as a popular cloud.

Additional context
This process is heavy and must be done in a background task to avoid freezing main thread.

Describe the bug
Auto modpack updater text has boxes instead of text.

To Reproduce
Steps to reproduce the behavior:

1. You'd need to install both automodpack, fabric api, bclib, and betterend/betternether mods
2. Simply launch minecraft and pay attention to the automodpack updater info.

Expected behavior
Of course, I'd expect the intended text. This is just a small nitpick, but something I thought was worth mentioning.

Screenshots

AutoModpack and Minecraft Version you are using (please complete the following information):

• AutoModpack version 2.3.6 for mc 1.19.2, Minecraft 1.19.2

Additional context
Truthfully, I thought only BClib and the betterx mods caused this issue, but after removing those 3 mods and reintroducing all 150+ mods back into my mods folder, the issue persisted. There's definitely more than one mod causing this issue, but it'd be a little tedious to dig through the mod list to find out which one causes this problem. Hopefully this helps you figure it out though! It really is just a minor issue.

Describe the bug
A clear and concise description of what the bug is.

On the latest update of the mod, attempting to update the modpack from the server just returns "Up to date!" even if the modpack isn't actually the same. This is seemingly caused by a Java error on the client's side. "java.net.sockettimeoutexception connect timed out"
To Reproduce
Steps to reproduce the behavior:

1. Create a new modpack, with just FAPI and AutoModpack along with a server set up.
2. Launch the game, and attempt to join the server.
3. No profit D:

Expected behavior
A clear and concise description of what you expected to happen.
The client should notice that there's an update and tell you instead of booting you from the server due to a mod missing.

Screenshots
If applicable, add screenshots to help explain your problem.

AutoModpack and Minecraft Version you are using (please complete the following information):

• AutoModpack 2.3.7, 1.18.2

Additional context
Add any other context about the problem here.

My client is running a recently installed EndeavourOS. I have 16 gigabytes of RAM, and have an Intel i3-9300H along with an Nvidia Geforce GTX 1050 3GB, if this helps.

The hosting part of automodpack doesn't stop when I stop it.
latest.log
.

Modrinth 1.19 download leads to 1.18 mod version

When updating a modpack, the zip file is 1 bit larger than the server's source, causing it to think there is an update required

A mod crashed on startup!
net.fabricmc.loader.impl.FormattedException: java.lang.RuntimeException: Could not execute entrypoint stage 'preLaunch' due to errors, provided by 'automodpack'!
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:164)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:214)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:249)
at org.multimc.EntryPoint.listen(EntryPoint.java:143)
at org.multimc.EntryPoint.main(EntryPoint.java:34)
Caused by: java.lang.RuntimeException: Could not execute entrypoint stage 'preLaunch' due to errors, provided by 'automodpack'!
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:162)
... 10 more
Caused by: java.lang.RuntimeException: Failed to load class file for 'pl.skidam.automodpack.client.modpack.DeleteMods'!
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPreMixinClassByteArray(KnotClassDelegate.java:449)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPostMixinClassByteArray(KnotClassDelegate.java:407)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.tryLoadClass(KnotClassDelegate.java:323)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:218)
at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
at pl.skidam.automodpack.client.modpack.UnZip.(UnZip.java:52)
at pl.skidam.automodpack.client.modpack.DownloadModpack.(DownloadModpack.java:191)
at pl.skidam.automodpack.client.modpack.DownloadModpack$prepare.(DownloadModpack.java:228)
at pl.skidam.automodpack.client.modpack.CheckModpack.(CheckModpack.java:55)
at pl.skidam.automodpack.PreLoad.onPreLaunch(PreLoad.java:40)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47)
... 12 more
Caused by: java.util.zip.ZipException: ZipFile invalid LOC header (bad signature)
at java.base/java.util.zip.ZipFile$ZipFileInputStream.initDataOffset(ZipFile.java:920)
at java.base/java.util.zip.ZipFile$ZipFileInputStream.read(ZipFile.java:931)
at java.base/java.util.zip.ZipFile$ZipFileInflaterInputStream.fill(ZipFile.java:448)
at java.base/java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158)
at java.base/java.io.FilterInputStream.read(FilterInputStream.java:132)
at java.base/java.io.FilterInputStream.read(FilterInputStream.java:106)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getRawClassByteArray(KnotClassDelegate.java:493)
at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.getPreMixinClassByteArray(KnotClassDelegate.java:447)
... 23 more
^crash thing from the fabric popup

AutoModpack-1.19.x-2.4.1

Basically, if a mod contains a bracket in its name a modpack will get stuck whilst updating.
For reference, when InventoryHUD-fabric-[1.19.1]+-3.4.2.jar is placed in the mods folder for an update any client attempting to update will simply remain stuck on the updating screen until they forcefully close the game; however, renaming the file to InventoryHUD-fabric-1.19.1+-3.4.2.jar will result in everything working as intended.

Though unnecessary, it might be helpful to include a 'Cancel Download' or 'Cancel Update' button to forcefully return to the main menu for added convenience in the event this or similar issues occur.

Describe the bug
A clear and concise description of what the bug is.

internal exception: io.netty.handler.codec.decoderexception: net.minecraft.class_151: Non [A-z0-9/,_-] character in path of location: minecraft.soh

To Reproduce
Steps to reproduce the behavior:

1. start server
2. attempt to login to server from client
3. connection lost

AutoModpack and Minecraft Version you are using (please complete the following information):

-- 2.41

Client & Server log
Log from ./logs/latest.log (If you scared of ip leak, please dm me logs on discord Skidam#8666)

upon request

When launching the game and having automodpack install its update, the instance of the game continues running and results in the game telling you theres another instance running in that game directory.

Steps to reproduce the behavior:

1. Install AutoModpack-1.19.x-2.3.0
2. Run the game
3. Close out the automodpack window
4. Try launching minecraft and notice it says there is still an instance of minecraft running in that game directory

Expected behavior:
That instance should be closed automatically

• AutoModpack-1.19.x-2.3.0 updated to AutoModpack-1.19.x-2.3.5
• Clientside

Log:
2022-08-20-1.log

• Work on servers
• Generate files on server (configs, modpack folder)
• Auto generate zip from mods/confings etc.
• Host Modpack on server
• Kick player who doesn't have AutoModpack
• When player have AutoModpack send packet with "link" and Download modpack from it
• Clone mods from mods loaded on server to mods in modpack
• Config
• --#19-- use AutoPlug
• Make it work.

Describe the bug
Crash when minecraft initialize

Client & Server log
https://mclo.gs/uFFlZSA

AutoModPack updates itself and shuts down the game. When I run my game again, it keeps trying to update itself and cannot do so.

https://paste.ee/p/OConO

My friend recently added automod to his server so it could update the mods for him, but when I got to it, I have not been able to get it working, as soon as the download is finished when I join the server and it goes to extracting it suspends my minecraft and it stops responding, I've checked if minecraft had both read and write permissions, ran it as administrator, Tried a new instance on curseforge, used just fabric in my minecraft folder, I've checked my network permissions, java install, everything, I cannot find any other reasons for it not be working, when I checked task manager as it was launching minecraft my computer used 100% of my cpu whenever launching, then evens out, when it crashed it was only using 43% of my cpu, so i dont think its a cpu issue, network issue, it didnt seem to be throtling and again the problem was when extractign the files not downloading.

Describe the bug
After following the instructions, my game gets stuck on the initial Downloading screen at 0%

To Reproduce
Steps to reproduce the behavior:

1. There aren't many steps to reproduce, for me it is getting stuck here mostly out of the box.

Expected behavior
I expected this would skip over the Downloading screen as I have the most current version of the modpack as I put it together.

Screenshots

AutoModpack and Minecraft Version you are using (please complete the following information):
Minecraft 1.19
AMP is the latest release from 7/12, no version number other than 1.19

Additional context
Hastebin of my config file

exactly as the title says.
if you connect to a server it downloads the new zip file but doesnt replace the old one
and it even crashes the game when modpack.zip gets pressed.

The config files synchronization seems to be disabled in the code as of today.
If it is indeed disabled/not handled it would be great to see this feature coming back?

Describe the bug
Mod is causing multiple errors seemingly related to Netty when added to my server pack. Prevents people from joining the server. The errors themselves all seem to stem from other mods but only appear when the AutoModpack mod is added so I would assume its the real cause.

To Reproduce
Steps to reproduce the behavior:

1. With PolyMC/MultiMC: Add instance and use url provided for non-launcher method.
   Without PolyMC/MultiMC: Download the modpack (available here) Sorry no ssl yet but its just an asset dump so should be fine
2. Run modpack
3. Attempt to join my server at 158.140.235.250:25566
4. Edit: Let me know if you end up wanting to jump on my server for testing so I can reset the mods back. Removed AutoModpack for the time being so people can still sue it.

Expected behavior
Connects just fine. As it does when I remove AutoModpack

Screenshots

AutoModpack and Minecraft Version you are using (please complete the following information):
AutoModpack version 2.4.1 for MC 1.18.2

Additional context
Other problems have popped up before too including a weird error the google hivemind doesn't even know about:
"java.lang.IllegalArgumentException: Fluid may not be flowing. " - not a single related result I could find.

Client & Server log
Log file

With both mods (Fabric API installed manually)

Error log:
A mod crashed on startup!
net.fabricmc.loader.impl.FormattedException: java.lang.RuntimeException: Could not execute entrypoint stage 'preLaunch' due to errors, provided by 'automodpack'!
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:164)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: java.lang.RuntimeException: Could not execute entrypoint stage 'preLaunch' due to errors, provided by 'automodpack'!
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:162)
... 2 more
Caused by: java.lang.NumberFormatException: For input string: "5,8"
at java.base/jdk.internal.math.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2054)
at java.base/jdk.internal.math.FloatingDecimal.parseFloat(FloatingDecimal.java:122)
at java.base/java.lang.Float.parseFloat(Float.java:476)
at pl.skidam.automodpack.utils.Download.Download(Download.java:64)
at pl.skidam.automodpack.client.modpack.TrashMod.(TrashMod.java:24)
at pl.skidam.automodpack.PreLoad.onPreLaunch(PreLoad.java:50)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47)
... 4 more

And only with AutoModpack:

A mod crashed on startup!
net.fabricmc.loader.impl.FormattedException: java.lang.RuntimeException: Could not execute entrypoint stage 'preLaunch' due to errors, provided by 'automodpack'!
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:164)
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:68)
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: java.lang.RuntimeException: Could not execute entrypoint stage 'preLaunch' due to errors, provided by 'automodpack'!
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
at net.fabricmc.loader.impl.launch.knot.Knot.init(Knot.java:162)
... 2 more
Caused by: java.lang.RuntimeException: java.io.EOFException: Unexpected end of ZLIB input stream
at pl.skidam.automodpack.utils.SetupFiles.client(SetupFiles.java:100)
at pl.skidam.automodpack.utils.SetupFiles.(SetupFiles.java:28)
at pl.skidam.automodpack.PreLoad.onPreLaunch(PreLoad.java:42)
at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47)
... 4 more
Caused by: java.io.EOFException: Unexpected end of ZLIB input stream
at java.base/java.util.zip.InflaterInputStream.fill(InflaterInputStream.java:244)
at java.base/java.util.zip.InflaterInputStream.read(InflaterInputStream.java:158)
at java.base/java.util.zip.ZipInputStream.read(ZipInputStream.java:196)
at java.base/java.util.zip.ZipInputStream.closeEntry(ZipInputStream.java:142)
at java.base/java.util.zip.ZipInputStream.getNextEntry(ZipInputStream.java:120)
at pl.skidam.automodpack.utils.UnZipper.progressBarSetup(UnZipper.java:114)
at pl.skidam.automodpack.utils.UnZipper.(UnZipper.java:19)
at pl.skidam.automodpack.utils.SetupFiles.client(SetupFiles.java:98)
... 7 more

Describe the bug
Sometimes it's not unzipping all files to folder mods

Screenshots

Describe the bug
Server previously hosted on x.x.x.x, after the hosting provider has changed IPs and now serves on Y.Y.Y.Y, AutoModpack fails to get the updated modpack on the new server and still attempts to poll old IP.

To Reproduce
Steps to reproduce the behavior:

1. Change Server IP address
2. ???
3. Issue

Expected behavior
AutoModpack should not automatically pull modpack updates, but instead connect to the server first then show a "modpack updated" notification or a notice that there's a new modpack.

AutoModpack and Minecraft Version you are using (please complete the following information):

• AutoModpack 2.2.4
• Minecraft 1.19

[15:49:44] [Server thread/WARN]: Failed to handle packet for /myhomeip:63043
java.lang.NullPointerException: Cannot invoke "String.indexOf(String)" because "pl.skidam.automodpack.server.HostModpack.modpackHostIpForLocalPlayers" is null
at pl.skidam.automodpack.AutoModpackServer.onLoginStart(AutoModpackServer.java:98) ~[AutoModpack-1.18.x.jar:?]
at net.fabricmc.fabric.api.networking.v1.ServerLoginConnectionEvents.lambda$static$2(ServerLoginConnectionEvents.java:51) ~[fabric-networking-api-v1-1.0.23+2d30af4b60-4536c950854534c8.jar:?]
at net.fabricmc.fabric.impl.networking.server.ServerLoginNetworkAddon.queryTick(ServerLoginNetworkAddon.java:81) ~[fabric-networking-api-v1-1.0.23+2d30af4b60-4536c950854534c8.jar:?]
at net.minecraft.class_3248.redirect$zkd000$handlePlayerJoin(class_3248.java:1062) ~[server-intermediary.jar:?]
at net.minecraft.class_3248.method_18785(class_3248.java:67) ~[server-intermediary.jar:?]
at net.minecraft.class_2535.method_10754(class_2535.java:243) ~[server-intermediary.jar:?]
at net.minecraft.class_3242.method_14357(class_3242.java:183) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.handler$bkm000$onTickServer(MinecraftServer.java:9305) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:697) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:273) ~[server-intermediary.jar:?]
at java.lang.Thread.run(Thread.java:833) [?:?]

I would assume that I wouldn't want 2 servers trying to host the modpack download on the same port/ip so i turned it off and told it to point to the same server's ip that the other one reports it is hosting on
#Configuration file for AutoModpack
#Sun Sep 04 06:14:40 UTC 2022
generate_modpack_on_launch=false
host_thread_count=2
sync_mods=false
danger_screen=false
only_optional_modpack=false
host_port=30037
modpack_host=false
external_modpack_host=http://192.9.243.44:30037/modpack
delete_modpack_button=false
host_external_ip_for_local_players=http://127.0.1.1:30037/modpack
check_updates_button=false
host_external_ip=http://192.9.243.44:30037/modpack
auto_exclude_server_side_mods=false

the main server tells me
[10:08:44] [ForkJoinPool.commonPool-worker-1/INFO]: Modpack host started at http://192.9.243.44:30037/modpack and http://127.0.1.1:30037/modpack for local players.
when it starts the pack host

Suggestion
Add del-resourcepacks.txt for us, that will be good anti-cheat. And the second is that, when people have some mods from del-mods.txt notify admins. This mod could be as good anti-cheat as mod-pack installer.

Describe the bug
There seems to be an incompatibility with this mod and the essential mod: https://www.curseforge.com/minecraft/mc-mods/essential-mod
It's not that minecraft won't open, but when automodpack is installed, the essential mod hud does not seem to be accessible.

To Reproduce
Steps to reproduce the behavior:

1. Install both automodpack and the essential mod to your client and modmenu if you would like to confirm proper installation
2. Open minecraft
3. You can see that the essential mod hud isn't visible in the menu screen, even though it is still counted in the mod list

Expected behavior
For both Automodpack and Essential to operate together.

Screenshots
n/a

AutoModpack and Minecraft Version you are using (please complete the following information):

• Using AutoModpack 1.19.x and Essential 1.19.x mod for Minecraft 1.19.x

Additional context
This is all surface level checking that I've noticed and was hoping that there would be a way to apply compatibility between the two.

Automodpack crashes on start up.

https://paste.ee/p/2NjNg

modpack doesnt download on prelaunch even when the danger_screen config is set to false (or true, but that seems intentional)

Steps to reproduce the behavior:

1. update modpack on server
2. client doesnt download modpack on prelaunch, but does when trying to join server

should download on prelaunch

Versions:

• 2.4.1 for 1.19

Client & Server log
I dont have logs of client, but the server doesnt have any interesting info

Is your feature request related to a problem? Please describe.
Add a blacklist feature for mods which accidently get added, an example of why this happens is some mods can be server and client side but not required on client, in my case i have about 10+ mods which I'd rather keep server only.

Describe the solution you'd like
A blacklist feature to block specific jar files like below.

blacklist=true
blacklist:='Multiworld-Fabric-1.6.jar, smoothchunk-fabric-1.19.1-2.0, connectivity-fabric-1.19-3.2.jar"

Auto q/fapi downloader is broken? need more tests

clean it!!!

An while back (back when log4shell was discovered)
I had an idea to take advantage of this, in an secure way, even wrote up an entire spec on how it could work,

And here you are, with an almost 1:1 copy of my idea! just for mods and not individual classes!
https://hackmd.io/@merith-tk/r14Z6zu9t

Im just impressed! I honestly dont care if its an rip-off intentionally or not! people said this shit was impossible in general! and here you are! doing it!

I don't know if it's intentional, but when i'm generating a modpack the mod writes itself to delmods.txt.
Users are unable to update modpack second time because AutoModpack was removed from modpack.

Screenshot

Used version: Minecraft 1.19, AutoModpack 1.19 2.2.1, Fabric

After successfully update the self-update, the finish screen does not appear

Re-process all download processes without downloading modpack if modpack is up to date

it will be good to have players know whats change so maybe add some kind of change log that they can view

Describe the bug
The modpack will no longer properly download when starting the game after auto-updating to 2.3.0.
I can see the logs saying it is downloading but even if i leave it for a long time nothing happens, it just gets stuck on preload and doesn't open the game.
If i instead try to download it after starting the game, it downloads quickly.
Can also quickly directly download the modpack from the IP using a browser.

To Reproduce
Steps to reproduce the behavior:

1. Change server modpack (e.g. add a mod)
2. Start game
3. Modpack starts to download but never finishes, so game window never appears

Expected behavior
In the previous version of AutoModpack, the modpack would download after pre-loading.
In this current version the download should be done during pre-loading, then start the game. But this does not happen

Screenshots
Minecraft debug log (gets stuck like this)

Server log

AutoModpack and Minecraft Version you are using (please complete the following information):
MInecraft 1.19
AutoModpack 2.3.0

Is your feature request related to a problem? Please describe.
Now in most cases is accurate some kind of "incompatibility" because of other handshake packets from other mods for example Sit or ThonkUtil. In most cases you will be kicked from server because of ununderstood handshake from other mod before the AutoModpack packets aren't even send, that's why AutoModpack then is useless

Describe the solution you'd like
Make new own AutoModpack networking system whose will be faster because of feature that it will can be use even in title screen or more easiest method just use existing Minecraft networking but use the query ping packets I mean these whose are sends in multiplayer screen

After spamming the button it stops working

• Add config