Comments (67)
I have solved this problem with 2 changes.
I'm from China so my wow.exe is actually named 魔兽世界 and in this project it is written to be World of Warcraft.
So my solution is:
In the function SendMouseClick() in Classes\helpers\win32.cs
change the first line from
IntPtr Wow = FindWindow("GxWindowClass", "World Of Warcraft");
to
IntPtr Wow = FindWindow(null, "魔兽世界");
Second in the function SendMouseClick() in Classes\helpers\win32.cs
change the first line from
IntPtr Wow = FindWindow("GxWindowClass", "World Of Warcraft");
to
IntPtr Wow = FindWindow(null, "魔兽世界");
After this the program works great on my computer.
Thanks the author~!
from ultimatefishbot.
http://www.filedropper.com/fishbot
i compiled it with the necessary changes, re-uploaded...
it's latest version (as of 11/24/2016)
from ultimatefishbot.
@RandomFisher are you still having this issue? If so I can try to analyze this a bit more closely, but it does sound like an odd bug. Do you have a multi monitor setup btw?
from ultimatefishbot.
My issue too. I do have multi monitor, playing vanilla wow. Cursor goes to top left of my right hand (main monitor) I have tried disconnecting my second monitor and restarting with just a single. I have also tried to play wow in my second monitor. Did have a load of mods including xperl, disabled all but to no effect
from ultimatefishbot.
Can you please re-try with the newest version since we re-coded the bobber finder ?
from ultimatefishbot.
from ultimatefishbot.
Still same issue, building new PC within the week with single GPU will test again. *Note playing vanilla wow
from ultimatefishbot.
i have this problem too, cursor stuck in left top corner, I have only one monitor :/
from ultimatefishbot.
I have the same problem, with cursor going straight to upper left corner. And I have one monitor too. Please fix it.
from ultimatefishbot.
I am pretty sure you are in windowed mode, but maximized to full screen (no border). Try windowed mode and still be able to see the minimize/maximize/close buttons.
from ultimatefishbot.
Has anyone came up with a solution for this? I am running it with WoW 2.4.3, the casting works fine but the mouse goes up in the left corner and just stays there
OS: Windows 8.1
Resolution: 1366x768
EDIT: After a bit of debugging, I got to the GetWowRectangle() method in Win32.cs . For some reason, it doesn't find the window and the pointer that returns is 0, causing the mouse cursor to be stuck in the left corner.
EDIT2: Ok, so the problem was fixed partially, after I replaced
IntPtr Wow = FindWindow("GxWindowClass", "World of Warcraft");
with
IntPtr Wow = FindWindow(null, "World of Warcraft");
The next issue that appeared is that the cursor icon while you hover the bobber is different from the one you use in your app, looks like this. I'll try to find a workaround for this issue and will come back with comments later on.
from ultimatefishbot.
Need to be on the primary display as well, if you have multiple monitors have wow on the primary monitor.
The cursor doesnt matter, its looking for cursor changes so if a monster walks buy during the can it will grab it.
from ultimatefishbot.
I am playing on my laptop, so I only have one display.
And I am pretty sure the mouse cursor matters, otherwise, I don't see any way he can establish the initial position of the blobber while surfing the rectangle.
from ultimatefishbot.
Sorry to hear that, I am sure there are a number of issues with this corner problem. I have a number of monitors and this application only works when the monitor is primary, the cursor always moves over to the primary corner if the window is moved to another monitor.
If you go to display properties and then identify, just make sure the monitor is "1" and not your external monitor if any. To be clear, if you are using another video port it may not be the primary.
On the cursor discussion, the cursor is moved across the window within the x,y x2,y2 area
Ever so often the cursorinfo is checked to see if it has changed, this rate of check is a configuration option.
The detection of the cursor changing is all that is looked for, it doesnt know what changed it, so for example if a enemy walks in the path of the cursor scan, the cursor would change from hand to sword (to attack) and the bobber would be though to have been detected ... and the cursor movement stops.
You can see this easily when you fish in mop areas with monsters on the water surface or when other players walk in front of your bobber.
This is exactly as described in the faq and how the application works in practice.
You can make it detect a bobber pretty easily if you just bring up your bags 'b' key infront of the cursor and it changes when looking at a item to use it.
from ultimatefishbot.
Thank you @Crystalleaf for your post.
I'm embarrassed to say that I never considered the name of the .exe being different!
from ultimatefishbot.
Guys.. I have this exact problem. My cursor gets stuck in the top-left part of the screen as the program tries to find the bobber. As I try to move the mouse it keeps moving itself to the top-left corner, so it's definitely doing something. It just doesn't seem to be able to move around inside the WoW window.
I'm a total noob when it comes to code, so I have no idea what Crystalleaf is talking about. Anyone fixed this problem and got a version that works that a noob like me can use?
from ultimatefishbot.
Hey, Folks. I tried to fish with your bot, but I'm stuck with this problem too!
As far as I can tell I've tried it:
- Fullscreen-Windowed(maxd)-Windowed(usual) none worked! (how to says make it window and shrink it, so regular windowed seems to work, but not for me!)
- Several Cursos Findung settings from both low to both high, high-low and low-high and kinda all possible tries! (none worked)
- Also tried to change code as Crystalleaf did. Re-did all my previous tries! (still not working)
Some other stuff I experienced. As I use latest version with the spiral route alt cursor finding, if that is checked the cursos stays out of game window (but finds it) like its stuck and the border of the window! If not checked it gets inside but stays where wants to stay.
Somehow I was able to move my mouse from tha starting point, but when casting starts again, it goes back! I tried to take mouse over blobber by hand and waited the bot to 'catch', but nothing happened! Not even heard it. So I started to check about sounding options.
I'm pretty sure others noticed that casting is also with sound (when string touches water it splashes too).
I started to look in the setting, which effect is louder... Well starting splash was usually just 2-3 point less then actual splash!
So I guess putting it the best amount would be hard.
I also tried to put the Delay After Cast timer as high as it cannot hear the start-splash but usually would start before actually catching anything...
After all this noobish tries i looked my Statistics and saw only fish not found numbers...
Can it happen for like it casts and then nothing happened? :S
I also did something that I don't know how, but the bot started to cast fishing so fast like a spammer, like 1cast/sec - If you know why this happened, please tell me!
If anybody wants to know I'm using Win 7 32bit system and playing on 1.12 patch.
So if anybody using the same OS / patch AND can share a working bot with setting via some download I'd appreciate it!
Sorry for the long post, but it is really annoying that I found a quite cool bot and its not working at all!!!
Thanks
from ultimatefishbot.
Can you try using the latest version with custom area selection? If that'll work for you, then we can be sure that there is a problem with the bot getting the wow window...
from ultimatefishbot.
Hello,
I have the same problem. When I download last version, I can not compile it in VS coz of 1 error.
CODE
1>MSBUILD : error : Fody: An unhandled exception occurred:
1>MSBUILD : error : Exception:
1>MSBUILD : error : Unknown custom metadata item kind: 7
1>MSBUILD : error : StackTrace:
1>MSBUILD : error : at Microsoft.Cci.Pdb.PdbFunction.ReadCustomMetadata(BitAccess bits)
1>MSBUILD : error : at Microsoft.Cci.Pdb.PdbFunction..ctor(ManProcSym proc, BitAccess bits)
1>MSBUILD : error : at Microsoft.Cci.Pdb.PdbFunction.LoadManagedFunctions(BitAccess bits, UInt32 limit, Boolean readStrings)
1>MSBUILD : error : at Microsoft.Cci.Pdb.PdbFile.LoadFuncsFromDbiModule(BitAccess bits, DbiModuleInfo info, IntHashTable names, ArrayList funcList, Boolean readStrings, MsfDirectory dir, Dictionary2 nameIndex, PdbReader reader) 1>MSBUILD : error : at Microsoft.Cci.Pdb.PdbFile.LoadFunctions(Stream read, Dictionary
2& tokenToSourceMapping, String& sourceServerData, Int32& age, Guid& guid)
1>MSBUILD : error : at Mono.Cecil.Pdb.PdbReader.PopulateFunctions()
1>MSBUILD : error : at Mono.Cecil.Pdb.PdbReader.ProcessDebugHeader(ImageDebugDirectory directory, Byte[] header)
1>MSBUILD : error : at Mono.Cecil.ModuleDefinition.ProcessDebugHeader()
1>MSBUILD : error : at Mono.Cecil.ModuleDefinition.ReadSymbols(ISymbolReader reader)
1>MSBUILD : error : at Mono.Cecil.ModuleReader.ReadSymbols(ModuleDefinition module, ReaderParameters parameters)
1>MSBUILD : error : at Mono.Cecil.ModuleReader.CreateModuleFrom(Image image, ReaderParameters parameters)
1>MSBUILD : error : at Mono.Cecil.ModuleDefinition.ReadModule(Stream stream, ReaderParameters parameters)
1>MSBUILD : error : at Mono.Cecil.ModuleDefinition.ReadModule(String fileName, ReaderParameters parameters)
1>MSBUILD : error : at InnerWeaver.ReadModule() in c:\TeamCity\buildAgent\work\7495521761d392b9\FodyIsolated\ModuleReader.cs:line 14
1>MSBUILD : error : at InnerWeaver.Execute() in c:\TeamCity\buildAgent\work\7495521761d392b9\FodyIsolated\InnerWeaver.cs:line 28
1>MSBUILD : error : Source:
1>MSBUILD : error : Mono.Cecil.Pdb
1>MSBUILD : error : TargetSite:
1>MSBUILD : error : Void ReadCustomMetadata(Microsoft.Cci.Pdb.BitAccess)
1>MSBUILD : error :
1> Finished Fody 11ms.
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
CODE
Can u help me LaBlazer pls?
from ultimatefishbot.
Are you compiling it with latest version of VS??
from ultimatefishbot.
Yes, I am - VS for comunity.
Odesláno z iPhonu
-
- 2015 v 17:53, LaBlazer [email protected]:
Are you compiling it with latest version of VS??
—
Reply to this email directly or view it on GitHub.
from ultimatefishbot.
I just tried to download the code and compiled it from scratch, and it worked without problems... It seems that the fody version is outdated...
from ultimatefishbot.
I will sound dumb, but what is Fody pls? ;)
Odesláno z iPhonu
-
- 2015 v 19:26, LaBlazer [email protected]:
I just tried to download the code and compiled it from scratch, and it worked without problems... It seems that the fody version is outdated...
—
Reply to this email directly or view it on GitHub.
from ultimatefishbot.
In short Fody is a dependency for Costura and Costura is package that embeds other dependencies as resources into application...
from ultimatefishbot.
try to compile it now, ive updated the dependencies...
from ultimatefishbot.
I just tried to compile lastes version and this is the result:
1>C:\Users\Xeiro\Desktop\UltimateFishbot-CSharp\UltimateFishBot\UltimateFishBot.csproj(212,5): error : This project references NuGet package(s) that are missing on this computer. Enable NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is ..\packages\Fody.1.26.1\build\Fody.targets.
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========
I do have enabled downloading of the missing packages.
from ultimatefishbot.
Yeah, it just happened to me too... i will repair it, but Im unable to run visual studio, because Im updating it from 2013 to 2015
from ultimatefishbot.
Ok, np. Anyway - i downloaded older version and used fix to recognize wow process (window). I used IntPtr Wow = FindWindow(null, "World of Warcraft");
So now It switch to wow and starts to find bobber. But my problem is, that it is not casting my fishing skill and if I cast it manually, it does not click when it should. So problem is, that it is not sending "key usage" to wow.
Any ideas pls?
from ultimatefishbot.
i dont know, try to running it as administrator
from ultimatefishbot.
Still the same problem.
from ultimatefishbot.
I got it working - problem was in keyboard layout. I switched it from CZE to ENG and now it cast. I will just need to set sound to actually cast on hearing the fish.
from ultimatefishbot.
Thats good to hear. My visual studio will download in a bit, so i will fix the bugs i made 😄
(sorry for no english)
P.S.: Ja som zo slovenska, tak som rad, ze sa niekto okrem mna odtialto o tento projekt zaujima :)
from ultimatefishbot.
Nice, let me know when u fix it :).
(sorry for no english)
Paráda, možná by to chtělo upravit i instrukce k použití programu (třeba to, že musí být ENG kláveska).
from ultimatefishbot.
I fixed it now, it is passing appveyor build, so it should now work for you :) just clone clean copy from this repo... And i will update the instructions too when i'll have some time :)
from ultimatefishbot.
Alright, so it seems like you guys found a solution to the problem with mouse getting stuck in upper left corner when using the fishbot. I'm not that good with coding and i hope you are able to help me out here.
I've downloaded the sourcecode library and found the mentioned file in Classes\helpers\win32.cs. What do i do from here? What exactly do i change and how do i make sure that it effects the .exe file in my library where i keep my fishbot?
I'm sorry if I'm asking for the obvious, but i hope you are able to help me out anyway.
EDIT: I'm using a laptop (1 monitor), Windows 10 and Vanilla Wow
from ultimatefishbot.
Have you firstly tried changing the process name from settings?? If it still doesnt work you will need a compiler to compile tgis source code just changing the downloaded file will not do anything. Download Visual Studio 2015 Community from internet (its free) and install it, then open the solution file in the source folder, in IDE navigate to win32 helper class (upper right corner) and then change the code as mentioned in this thread. After you'll change the code you will need to compile it. To do this, press F5 or that little play button in visual studio. If you did everything ok, it should download all dependencies, compile the code and run it. I dont recommend running the bot with debugger attached tgough, because it slows it down... To run it normally you will have to navigate to runnable binary at /bin/Debug/ and run it from there. If you'll get errors try googling them first, there are a lot of answers on the internet already...
from ultimatefishbot.
Thank you for answering.
First of all; yes, i did try changing the process name in settings - it didn't change anything. (Tried with both 'World of Warcraft' and 'World of Warcraft (32 bit)').
I downloaded VS 2015 and did as you described. I changed
public static Rectangle GetWowRectangle()
{
IntPtr Wow = FindWindow("GxWindowClass", "World Of Warcraft");
to
public static Rectangle GetWowRectangle()
{
IntPtr Wow = FindWindow("null", "World Of Warcraft");
and
public static void SendMouseClick()
{
IntPtr Wow = FindWindow("GxWindowClass", "World Of Warcraft");
to
public static void SendMouseClick()
{
IntPtr Wow = FindWindow("null", "World Of Warcraft");
I then ran the program using F5 and it started up the fishing bot as intended, the issue is completely the same though. It catches the fishing bobber and the cursor jumps into the upper left corner and stays up there. After a while, VS will maximize and take me to the following code within Classes.BodyParts.Eyes with the option to edit:
throw new Exception("Fish not found"); // Will be catch in Manager:EyeProcess_RunWorkerCompleted
Sorry for being "new", but as people stated earlier - it's such a shame to find this kind of tool and then not being able to use it.
It's worth mentioning that accessing 'settings' from the botmenu after it's been compiled by VS2015 the process name will be 'Wow'. Vanilla runs with 'World of Warcraft (32 bit)' - could this be a source to the problem?
Thanks a lot in advance
from ultimatefishbot.
i dont think this is the fix for you... function FindWindow("GxWindowClass", "World Of Warcraft"); only finds a window with name World of Warcraft. What are you editing in settings is the name of process (executable) that you are running (wow.exe in most cases)... So if you run wow and you have a window named World of Warcraft, this most likely isnt a solution to your problem. You can add me on my skype "wowwac" and i can have a look at it if you want...
from ultimatefishbot.
Sorry, but I dont know about tablets, I dont have any windows tablet to try it on...
from ultimatefishbot.
I dont see any delay in code between detection and looting (hearing fish -> m_manager.HearFish(); -> m_hands.Loot(); -> Win32.SendMouseClick() -> clicks), so im afraid that i wont be able to fix this easily without changing or tweaking the audio library...
from ultimatefishbot.
Did you try to run it as an administrator???
from ultimatefishbot.
I have deleted my comments because no one is helping. We have sorted out the problem.
from ultimatefishbot.
Sorry, but I was busy with my school... Can you at least tell us how did you fix it??
from ultimatefishbot.
Windows 7 uses different then "GxWindowClass" class name. My local fix was to use null instead
from ultimatefishbot.
Can you then please download winlister (http://www.nirsoft.net/utils/winlister.html) and tell me what is your class name?
from ultimatefishbot.
GxWindowClassD3d
from ultimatefishbot.
Thank you, i will try to fix it...
from ultimatefishbot.
I just started playing vanilla wow and tried fishbot but I have the same issue, cursor hits the top left of the desktop and just stays there. Anyupdate on a fix for that? I have windows 7 installed and I am using a monitor connected (HDMI) to my Dell laptop. Thanks! I look forward to catching some tasty fish!
from ultimatefishbot.
Is anyone able to use this on Windows 7 with Vanilla Wow and no problems?
from ultimatefishbot.
I tested on WotLK client (probably works with TBC and vanilla too) replacing GxWindowClass with GxWindowClassD3d at SendMouseClick and GetWowRectangle and disabling Check Cursor Icon and works fine.
According to Winlister, Cata is GxWindowClass so you should have no problem there (probably the same with MoP,WoD). It has probably something to do with the graphical changes during Cata.
Since the icon for bobber mouseover was changed from gear cursor to hook cursor in Cata, having Check Cursor Icon option toggled on while using wotlk or lower will not work.
I tried replacing the .bmp file of the cursor in Resources folder but the mouse didn't stop neither. I tried many gear icons, even screenshotting the one in game (with highest quality) but didn't work. I guess it has something to do with the size of the icon since the method imageCompare checks first if the two images have the same height and width. I noticed that the hook icon has 35x35 but the gear icon i found on WowWiki had 32x32 (screenshotted icon had 28x28 which is a bit odd). It would probably work if someone got the actual image from game data files.
If you have wotlk version or lower just download the newest version of the Fishbot, correct the code lines I mentioned above and toggle off Check Cursor Icon in the settings (don't forget to manually set the scanning area in the settings, the searching is much more efficient if you select the area well). If you have Cata or higher, your problem should be solved by tweaking the Settings.
from ultimatefishbot.
Thanks for your input MonstaKilla, Downloading VSC now, I'm also having the cursor issue. I'll let you know if i can confirm
Running Vanilla WoW 1.12.1 x32 bit Client
Windows 10
from ultimatefishbot.
Update*
Following your steps provided Fishbot is working as intended, besides the Anti-AFK function, it crashes the bot every time.
from ultimatefishbot.
Hi guys! :)
I have currently more than lost my mind trying to get this to work...
those thingies you talk about chaning, how and where do i find them to be exact?
If you could specify exactly how, and maybe a path for us (aparently retardos) that would be great!
from ultimatefishbot.
So, anyone solved problem with left corner of the screen ?
from ultimatefishbot.
Hello, i made Github account to ask you. I'm having same problem. I'm don't have skills and i don't know anything about coding. Can someone help me with this by simple download and anything like that? Thanks
from ultimatefishbot.
Having same issue, has anyone found a fix that doesn't require recompiling stuff? I don't know jack about code and compiling. Can someone just upload a fixed version if you have it working?
from ultimatefishbot.
Unfortunately, your compiled version doesn't work for current Legion patch, cursor is still stuck on top left of screen.
from ultimatefishbot.
how does this filedropper work? Same problem w10, 1.12.1 client , 1 monitor
from ultimatefishbot.
MonstaKilla? can you please explain how to edit the prgram in VSC?
from ultimatefishbot.
@Crystalleaf 多谢多谢!
from ultimatefishbot.
I'm having the exact issue as well. I've tried the latest download, from here: https://github.com/UltimateFishbot/UltimateFishbot/releases/tag/Fishbot-4.0.36
Cursor just sit in the top left hand corner.
I only have the one monitor, I'm on a private server - tbc - 2.4.3.
If you need any more information, let me know.
from ultimatefishbot.
All, I found the issue. Leaving the code exactly as it is for US/ENGLISH versions, the task manager name of the application for WoW.exe is World of Warcraft. This also can be seen in the properties of the executable. The code in the Win32.cs file has two functions:
public static Rectangle GetWowRectangle()
IntPtr Wow = FindWindow("GxWindowClass", "World Of Warcraft");
This fails because of the capital "O" for Of. Changing this to lowercase "o" allows the wow window to be found by the fishingbot and the cursor to begin searching within it.
As well as in the function:
public static void SendMouseClick()
IntPtr Wow = FindWindow("GxWindowClass", "World of Warcraft");
Corrected: IntPtr Wow = FindWindow("GxWindowClass", "World of Warcraft");
After changing these, I rebuilt, published, and executed and works like a charm!
Hope this helps the developer and others!
from ultimatefishbot.
so braczy could you pls explain me in layperson language how you "changed, rebuilt, published, and executed"? I really want to fish bro pls.
<3
from ultimatefishbot.
Based on @daniel-widrick's work in March / April 2018, it looks like he resolved this issue. Is this newest version available for download somewhere?
from ultimatefishbot.
I haven't seen any movement from the original dev in awhile:
https://github.com/daniel-widrick/UltimateFishbot/releases
from ultimatefishbot.
from ultimatefishbot.
Fixed
from ultimatefishbot.
Related Issues (20)
- No casting/ No catching HOT 1
- .NET Exception Errors since 8.1 HOT 1
- Banhammer for UFB? HOT 7
- Could not verify status! Use at own risk HOT 1
- Exception while looking for bobber
- Not an issue but rather a question (Can we use it on Linux ?) HOT 1
- Not waiting on fish HOT 2
- Hi..has it been confirmed as detectable or just users using too much and being reported? HOT 10
- Is this bot still worked on ? HOT 9
- Ultimate fishbot for vanilla version HOT 3
- Vanilla fishing
- Need password HOT 4
- I can not use the Old version anymore?
- Isn't an issue, just a warning HOT 14
- Anyone banned using old V4.0? HOT 4
- Need help with mrfixit
- Doesnt click at all after it searches
- Mouse runs away from bobber when clicking HOT 3
- WoW Detection fix? HOT 3
- Using interact buttons?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ultimatefishbot.