Giter VIP home page Giter VIP logo

ultimatefishbot's Introduction

** CAUTION - USE AT YOUR OWN RISK! A SIGNIFICANT NUMBER OF USERS HAVE BEEN BANNED **

UltimateFishbot

A simple World of Warcraft fishbot written in C#.

Introduction

I started this project during my freshman year of college… Many, many years ago. It’s been years since I’ve played Wow and I no longer have the amounts of free time I used to. I’ve revised the code a few times since, but I can’t pretend it’s a shining example of anything; still, it remains a popular project and I hope someone who enjoys the game or enjoys the code will come along and get some value from this.

Coding Overview

This is originaly written in VB.NET (I know, I know….). It has been now ported to C#. You can get a free copy of Visual Studio Community.

The general idea is that the bot works by ‘listening’ to the output from the game (whereas most bots at the time were reading pixels and trying to find the bobber, or reading the game’s memory - which means updating the offsets after each patch). This works with the CoreAudio DLL file – I didn’t write it and I don’t believe it works with Windows XP.

The bot uses standard win32 API calls to move the mouse and send keystrokes.
I’ve never had any problems, but I’ve gotten reports from users saying it doesn’t work on their machine.

It starts by sending the ‘cast’ key, then moving the cursor systematically and using the GetCursorInfo api call to detect a change in the icon. We assume that that change is the fish bobber. Then it monitors the sound output (via CoreAudio) until there is a change above a threshold and we assume that this is the splash of a fish.
Then the bot sends the click mouse event. Rinse. Repeat.

There are quite a few ‘nice-to-haves’ I never got around to doing… Adding lures, improving the scanning, ironing out the hearth home functionality… Maybe someone will get a chance.

Thanks to everyone who supported the project and thanks to anyone reading this for your interest.

Updated for Mists of Pandaria & Warlords of Draenor

Updated by justanotherprogrammer to support MoP items such as the Ancient Pandaren Fishing Charm and the Angler's Fishing Raft. Also added support for people who don't use Auto-loot.

Updated by Henrik Hermansen to support WoD bait.

Updated in C#

Updated by Pierre Ghiot (Mograine) in C#.

Updated by @daniel-widrick, @Szabka, @NaNraptor, @Lunat1q

-Hearing optimisation.

-Bobber finding and Hearing is put in parallel threads.

-Bobber finding searches the differences between "before cast" and "after cast" screenshots, than previous bobber positions ordered by occurence.

-If bobber is still not found when fish is heard, it searches 2 seconds more for bobber, so that it still has a possibility to catch fish.

-Bobber recheck on hook, so if bobber moves a little it will find the fish again.

-Has log file for debugging purposes.

-Can capture fishing cursor with hotkey for more precision bobber finding.

-Hungarian translation.

-Bulgarian translation.

-Wow window handle searched when starts fishing(and not when fishbot starts).

-Hotkey actions disabled in settings screen.

-Stop fishing after 10 consecutive fish failures.

-Randomised delay and cast times to avoid detection

-Randomised window title on start

Happy Fishing!

Gorden [email protected] www.fishbot.net

ultimatefishbot's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

ultimatefishbot's Issues

Does Not Work In Windows XP

Several users have reported this; I suspect it is the CoreAudio library. Will need to find a more compatible way to listen to the game.

Ad Revenue....Thoughts?

First - thanks to everyone who has contributed code/features. Very cool.

Second - we've had a jump in traffic with the new WoW expansion. That usually happens, and in a few weeks, traffic drops back down to a trickle. The ad revenue from the 'enter the code' page usually covers the cost of the webhost and domain name, but for the first time we have a few dollars left over. By the end of the year, I'm estimating about $30 over the hosting costs.

It's not a lot of money, but I feel a little odd making money when other people are contributing to the code. What do you guys think?

  • Remove the ads for the next year with the revenue we've got.
  • Keep the ads and split the money among the contributors (I dunno the best way to do that - easiest might be something like Amazon gift cards or via PayPal?).
  • Not worry about it since $30 is pretty insignificant - revisit the issue if the amount grows.

works fine but...

all seems to be work, but i need that when rightclick to open the loot w8 1º sec and right click again. becouse autoloot in my servers dosent work for fishing. its just ignore fish.
edit: Shift autoloot dosent work to. i need to manualy right click to get loot

Preventing 'away' state.

Will be a good improvement to implement logic for preventing 'away' state? The reason: when I'm in 'away' state, I got a lot of spam-messages. I think simple jumping or moving left-right will be enough. Or there is an option in WoW for that which I missed? =)

Cursor finding monsters instead of bobber

I have noticed that sometimes the cursor will stop on a monster if it hovers over it. Is there any chance there could be a fix to that? That it will only stop on the bobber?

Does not detect cursor regardles of settings

I have tried tweeking the setting to both slower and faster. Tried changing resolution, and have all addons disabled but it passes the cursor every time. It is detecting sound because I was able to get the mouse on the cursor and it clicked when the splash occurred. Win7 x64 build. Just curious if I am missing something.

Doesn't loot fish

Everything is working fine but it fails to pick up the fish.
i tried increasing the time "delay after looting"
none of the settings worked

not clicking when it hears fishing

Hello,

I believe the bot is detecting the sound because manually fishing produces a change in the sound bar in the settings. It goes as high as 45 or something close. I have it set to 20 right now as the threshold. It casts, finds the bobber but that's it. It times out after the fishing sound. I have different sound outputs on my computer and have tried them both. Any ideas?

Value for "Ctrl" not Found

Hi,
first of all thanks for keeping the project going and sharing this bot with us.

Now the problem i got, im from germany and im using win 7-64bit.
Every time i start the new released version of the fish bot, i get this error.
With the previous version i didn't get the error code.

http://i38.servimg.com/u/f38/19/03/18/57/screen10.png

English:
The StartStop- Hotkey property could not be generated from the standard value.
Error Code: The requested value for "Ctrl" could not be found.

Now i got two options: I can stop the programm or i can go on and ignore that issue.

The fishbot window appears.
I can't change any value in the option.
If i press "Start" the fishbot begins to throw, mouse searching for lure and finds it.
If i get a bite nothing happens now, guess thats because the value for sound is "0".

Sry for this wall of text and i hope u can understand the problem i got.
I Tried the best with the english i got :P!

Greetings from germany

Won't cast or find bobber

i ran the application just fine one day and the next it stopped working. It says it's applying bait, lure, charm but it never casts the line. So I manually cast it and it won't find the bobber either. One thing I noticed is if I tab over to fishbot.exe it will start scanning for bobber. I haven't changed any settings and I even tried re-downloading the program. When I get home I'm going to try turning off all add ons to see if that helps.

Thanks in advance!

Add ability to pause bot

It would be nice to be able to simply pause to bot (if you need to check your bags or just do something on the computer) and then resume it while it still keeps track of timers for lure etc.
As it is now using Stop and Start will reset all timers. That seems reasonable, but a pause function could be useful too.
I'll work on this a bit today and make a pull request whenever it's finished. I suggest labeling this as an enhancement.

Does not detect Wow

Keeps saying can Error finding game. and game is open i used before now this issue just came up. Please help :) Thank you.

Great bot btw thanks.

UltimateFishbot has stopped working

so it worked before but now after I closed the program and closed WoW to go to RL stuff this happens.
I opened WoW before I opened the bot and did everything as I did before now I got:
Problem signature:
Problem Event Name: CLR20r3
Problem Signature 01: ultimatefishbot.exe
Problem Signature 02: 1.0.0.0
Problem Signature 03: 54ce19bd
Problem Signature 04: System.Windows.Forms
Problem Signature 05: 4.0.30319.34251
Problem Signature 06: 54daee67
Problem Signature 07: 425f
Problem Signature 08: 4b
Problem Signature 09: System.ArgumentOutOfRange
OS Version: 6.1.7601.2.1.0.768.3
Locale ID: 1033
Additional Information 1: 0a9e
Additional Information 2: 0a9e372d3b4ad19135b953a78882e789
Additional Information 3: 0a9e
Additional Information 4: 0a9e372d3b4ad19135b953a78882e789

I tried completely deleting it and reinstalling it, after redownloading it and I still get the same errors. I literally changed nothing from before it threw errors. HALP!

Unhandled exception

I am getting this error:
See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
at Gordenv30.frmMain.btnStart_Click(Object sender, EventArgs e)
at System.Windows.Forms.Control.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnClick(EventArgs e)
at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ButtonBase.WndProc(Message& m)
at System.Windows.Forms.Button.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

************** Loaded Assemblies **************
mscorlib
Assembly Version: 4.0.0.0
Win32 Version: 4.0.30319.18444 built by: FX451RTMGDR

CodeBase: file:///C:/Windows/Microsoft.NET/Framework/v4.0.30319/mscorlib.dll

Gordenv30
Assembly Version: 1.0.0.0
Win32 Version: 1.0.0.0

CodeBase: file:///C:/Users/Jacqueline/AppData/Local/Temp/Temp1_fishbot_3_0.zip/Gordenv30.exe

Microsoft.VisualBasic
Assembly Version: 10.0.0.0
Win32 Version: 11.0.50938.18408 built by: FX451RTMGREL

CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Microsoft.VisualBasic/v4.0_10.0.0.0__b03f5f7f11d50a3a/Microsoft.VisualBasic.dll

System
Assembly Version: 4.0.0.0
Win32 Version: 4.0.30319.34238 built by: FX452RTMGDR

CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll

System.Core
Assembly Version: 4.0.0.0
Win32 Version: 4.0.30319.18408 built by: FX451RTMGREL

CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll

System.Windows.Forms
Assembly Version: 4.0.0.0
Win32 Version: 4.0.30319.18408 built by: FX451RTMGREL

CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll

System.Drawing
Assembly Version: 4.0.0.0
Win32 Version: 4.0.30319.18408 built by: FX451RTMGREL

CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll

System.Runtime.Remoting
Assembly Version: 4.0.0.0
Win32 Version: 4.0.30319.34245 built by: FX452RTMGDR

CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Runtime.Remoting/v4.0_4.0.0.0__b77a5c561934e089/System.Runtime.Remoting.dll

System.Configuration
Assembly Version: 4.0.0.0
Win32 Version: 4.0.30319.18408 built by: FX451RTMGREL

CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll

System.Xml
Assembly Version: 4.0.0.0
Win32 Version: 4.0.30319.34234 built by: FX452RTMGDR

CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

Improve Lures

The suggestion: allow the time between applications of fishing lures to be set by the user. There are lures (that have been in game for a while now) that last for 15 and 30 minutes, and even some that last an hour. There's also the fishing raft, which needs to be cast slightly more often than every 10 minutes, so the buff doesn't come off and dump the fisher into the water.

Memory Leak on x64

So far I've noticed that on 64, I can set it up and leave it running for about 3 hours normally but it still requires supervision because at a point into about the 3 hour mark: it stops the screen scroll to search for the bobber and the cursor itself just bobs up and down with no search movement.

This only happens after progressive running for about 3 hours and over and then there's no response. The line is cast but there's no response otherwise from the cursor and I have to close it and restart it to get any sort of response even IF I restart it.

Bait and lure not working

Hi, everything is working great, but not luring and baiting. I have chosen 'USe Alt-Key modifier' to bind lure (Alt+1) and bait (Alt+6), but nothing happens
Cast key worlks fine (Alt+0]

Invalid hotkey to start/stop the bot

Maj is not a valid key on the keyboard. As far as I understand this is actually the Shift key. With Ctrl+Maj+S I get an exception when trying to launch the bot. If I change it to Ctrl+Shift+S I have no problems running it. Does it work for your French setup if you change this to Ctrl+Shift+S @Mograine ?

Won't click to loot the fish

First off, this is amazing. Great job!

However, and i am sure this is something that i am doing wrong, it won't loot the fish once it opens it up. Any help with this would be much appreciated.

Thanks!

Risk of Detection [Question]

Hello All,

First of all, thank you for making and maintaining this.

Obviously, there is no real "safe" bot solution, but I'm curious on your views on the chance of detection.

Also, are there any recommended practices or pointers for limiting the risk while using the bot?

Thank you for your time.

UltimateFishBot in C#

Hello,

I liked the project very much but i sincerely dislike the VB.Net :p So i decided to make a porting by myself, and here is the result : https://github.com/Mograine/UltimateFishbotCSharp .

After a mail with the project owner, he said that it's been a long time that he wanted to redo the bot in C#.

So here is the question : Would you agree that we stop VB.Net support and that we set the C# bot as 'official' ?

For those who don't want / can't contribute, it won't change anything (it may work a little better). The question is more difficult when it come to contributors (by example, henrikhermansen), who maybe can't code in C# or just don't want it.

Please add support for new Draenor Lures

In addition to lures such as sharpened hooks and worms, there is now a second lure or "bait" in the game that can be used simultaneously and only lasts for 5 minutes. Can we have support added for adding a second type of lure on button 3 with a duration of 5 minutes?

(Global) Keyboard Shortcuts

Keys bound to events to start and stop the application without the need to minimise wow. e.g. C+S would start / stop the application

Leaves the wow window

I do not know what the problem is, but it seems that after you click on the wow window it does its normal business. Until it is time to recast, at some point it leaves the wow window and thinks it has pressed the button for casting. Every time it has to recast I have to click on the wow window for it to work for that one cast.

WoD Bait not working

Everything works great. It was able to help me with my fishing skill. However, the WoD bait is bugged. It never adds bait. And since each type of bait is a unique item, we can only have one so trying to reapply every 5min wouldn't work unless it can detect or have a list of baits to choose from. That would be cool.

Cursor moves - but misses the game window (with video)

Hi all,

I got an e-mail from a user who took the time prepare a video of the behavior he was seeing:
http://youtu.be/ovTplS5xwpI

Clearly, it's not what it should be. It's moving the cursor, in the correct pattern, but it's not over WoW at the time. I don't really have any ideas on what the problem could be, but I wanted to log it here and see if anyone else does. I probably won't have a chance to look at this until next week (as I've got some time off work coming up).

Won't click with bobber splashes

Ive tried changing the settings, and doing everything it asks me to, but for some reason when the splash happens, it does not click the bobber.

Not Casting

Hello,

i have done everything whats to do. It Casts the first time but then the bot only searches the lure and dont recast

Trouble with lure with CD

I have Nat's Hat. It has a 10 min lure with 10 min CD. It seems the bot behaves like this:

  1. Apply lure
  2. Fish for 10 minutes
  3. After 10 minutes decide we need to re-apply lure. Count down to next lure begins.
  4. Finish off the current cast
  5. Re-apply lure. This can happen up to 20 seconds after the count down starts at 3.
    This will often result in the lure still being on CD on the 3rd application as the count down from the 2nd application starts before the lure is actually applied that 2nd time.

Auto loot does not work.

Hello,
In-game loot automatically closed.
ultimatefishbot (shit-loot) auto loot on.
Everything works great
only not work auto loot
please help me.

vanilla version

hi there,

is there any version or way to get this working on a vanilla 1.12 server?

no matter what i try it doesnt start searching the blooper or it recasts fishing every 3 or 10 seconds still without searchin for the blooper and it doesnt care about the values i entered, its just kinda instarecast or at 10 seconds.
if i check spiral route the mousepointer gets stuck topleft.

regards jim

Wont Detect WoW

recently started playing wow again, then realized I needed some money, so I booted up my fish character so I could bot and get some fish to sell. then when all the settings were as required I pressed start and it said "Error Finding Game. Make sure you start the game before clicking 'Start' on the bot" then I checked if it was an old version, it was, so I updated, then tried again, same outcome, then I turned of a software that is a form of game add-on (overwolf) but the same, and now I'm here. please help be, this is really bothering me...

Not using Fishing right away

I have everything set up right and the bot is not using the fishing right away, It is waiting about 6 seconds

Won't click when the bobber splashes.

I have the audio devices on both the program and WoW set to the same device. I have tested to see that the sounds in the game are being heard by the program, the green bar moves to 10-90 depending on what i'm doing. Still isn't clicking the bobber when a fish bites. Any suggestions?

Fishing Stats...

Suggested by user via e-mail 'Possibly some statistics about timed out catches, successful catches. '

Given how things currently work, this would probably be a pretty big undertaking :)

Warden detection?

Hi!

First of all i would like to say that i did use this application a lot before patch 6.1.2. Then i stopped for a while, and started last week again. But only after 5 hours i got instant 72h ban. I'm just wondering if it is likely too be bad luck and blizz detected suspicious activity, or does the WoW Warden detect this app nowadays?
"Warden uses API function calls to collect data on open programs on the user's computer and sends it back to Blizzard servers as hash values to be compared to those of known cheating programs.[1] Privacy advocates consider the program to be spyware.[2]" - http://wowwiki.wikia.com/Warden_%28software%29

Cursor stuck on upper left corner of the screen

Hi. I've been trying to make Fishbot working with no effect.

Every time I start the Fishbot, it casts fine. However after casting, the mouse cursor goes straight to the upper left corner of the screen and never moves. When I try to move the cursor, it goes back to the corner. As it doesn't try to search the bobber, it appears to do nothing after the splash but release the cursor to be able to move again.

Is there any solution?

Not casting

First time it always cast fishing but then it never cast fishing no matter what I change, And yes I have fishing on my 1 key

Cycle through all bait option.

Can we please get an option to cycle through all available WoD bait?

My goal is to use this for garrison fishing. When fishing in your garrison you cannot find more bait, yet you may use any bait you please. So going through each type of bait would be a good way to get a assortment of each fish in one run without having to change locations.

Thank you for your time.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.