Won't click with bobber splashes about ultimatefishbot HOT 22 CLOSED

Same issue here. Fishbot finds a bobber and never click it (not hearing sound). i selected proper device (same as in wow) and fisherman detects sound on it when fish comes (see screenshot).

from ultimatefishbot.

I'm playing on Warlords of Draneor 6.1.2 and also facing the same problem as yours. I've tried a lot of sound configurations but the bot just won't click the bobber when the splash happens. What is going on?

from ultimatefishbot.

Left this email for other admin but wanted to share since its the same issue,

I was using it most of the night with great success. today I tweeked my PC abit but did nothing specific to fishbot or WoW.It appears all the features are still working. I tested each default sound and even left the FB sound bar up to see if it was hearing the bobber and it sure was. It was going over halfway so I know the sound is correct. The casting, charm, and lures are all working well tooo. but as of today, when the bobber gets a bite (and I have it nice and loud as I mentioned before), it does nothing. I tried about 15 times then started to checking the autoloot features in the WoW interface and didn't see anything relevant in FB for it. it just wont click the bobber when there is a bite If I click it then it catches the fish then continues to countdown before recasting as if no bite had occurred, Any ideas? on a side note, I swore It used to right click the bobber to catch the fish. now its the left but that could be me. I made some changes in the interface to see but still noting.

Your FB got me my Land Shark, Sea Calf, and new crimson water mount. want the pole and a couple more pets. so it did work perfectly. IT just worked yesterday for about 4 hours and today not one catch from FB hearing the bobber.. please help. Kizzy

from ultimatefishbot.

Has this issue gotten any attention yet? still an ongoing issue.

from ultimatefishbot.

One sound issue I have noticed is if you have headphone mode turned on in wow or using headphones as your output device. Not sure why but My USB headphone doesn't seem to work.

from ultimatefishbot.

Have you noticed it works once, then never again?

from ultimatefishbot.

I will look at this issue, because the hearing works 7/10 times for me too... Im not sure, what can cause this tho...

from ultimatefishbot.

If it's only sometimes it happens, maybe it could be due to the library/code itself, is only checking the sound output every, lets say, 250ms? The peak of the bobbing sound could be within' that period and therefore the application doesn't hear it. What if it gets lowered to 1 and you crank all volume on game and Windows up?

from ultimatefishbot.

I have looked at the hearing code, and its weird. I will have to look what are those additional checks for when i'll have time...

from ultimatefishbot.

I haven't had a chance to try any of this; but I had a few thoughts. When I first tried to find the bobber, I used a set value - like '20' (that's 20% of maximum sound output) to hear the splash. And I'd get it working great in whatever location I was in WoW, but then I'd go somewhere else with more or less noise and it wouldn't hear anything (or it'd hear background noise and try to loot the fish).

That's why it has the queue. I'm not saying this is the best way to do it, but my goal was to keep track of how loud the game is, wherever you are. It checks the output and keeps track of the last X outputs. So if the sound right now is 20% but the average of the last 10 checks was 20% - it's not a splash. If the sound is 20% right now, but the average of the last 10 checks was 10% - it probably is a splash.

At least, that was my thought process. If something else works better, let's do that instead.

Having said all that, it looks like it's polling every 500ms. I think @Gasur makes a great point, that's a lot of time between sound checks. I'd be curious to try it with it set to 100ms and then increase the MAX_VOLUME_QUEUE_LENGTH to 25. Or something like that.

from ultimatefishbot.

I think it should be configurable- normal detection for quiet areas and queue detection for loud areas... I understand, why are you making the queue of sounds, but you are adding all the loud sounds to it too... So if there is a loud sound in the last 5 queue entries it will not trigger.. That is what im thinking, but I have to check it out first...

from ultimatefishbot.

Added an option for sound comparing without averaging, so this should work now... If you are still having this problem feel free to open a new issue.

from ultimatefishbot.

I have the same problem.

So we analyzed the source.

But one thing I found strange.

public static Rectangle GetWowRectangle(){
IntPtr Wow = FindWindow("GxWindowClass", "World Of Warcraft");
Rect Win32ApiRect = new Rect();
GetWindowRect(Wow, ref Win32ApiRect);
Rectangle myRect = new Rectangle();
myRect.X = Win32ApiRect.Left;
myRect.Y = Win32ApiRect.Top;
myRect.Width = (Win32ApiRect.Right - Win32ApiRect.Left);
myRect.Height = (Win32ApiRect.Bottom - Win32ApiRect.Top);
return myRect;
}

FindWindow Title is hard coded.

My WoW Title is "월드 오브 워크래프트" korea title.

So it seems you do not find the WoW.

from ultimatefishbot.

What happens if you change that line, and replaces it with your window title?

from ultimatefishbot.

I do not have a C # T.T

My version of WoW is South Korea.

My window title is "월드 오브 워크래프트"

"World of Warcraft" = "월드 오브 워크래프트"

from ultimatefishbot.

Okay. I'll quickly fork this bot, change the title & hand it over to you.

from ultimatefishbot.

thank you.^^

from ultimatefishbot.

Here it is: https://dl.dropboxusercontent.com/u/99913755/Release.zip
Please give it a try :)

from ultimatefishbot.

Thank you.

I'll try to go home and run

from ultimatefishbot.

Gasur@4db0cd0 Here is the commit, if you wish to see what I changed.

from ultimatefishbot.

I think that should be changed as follows.

IntPtr Wow = FindWindow("GxWindowClass", "World Of Warcraft");
IntPtr Wow = FindWindow("GxWindowClass", Properties.Settings.Default.ProcName);

public static void SendMouseClick()
{
IntPtr Wow = FindWindow("GxWindowClass", Properties.Settings.Default.ProcName);
long dWord = MakeDWord((LastX - LastRectX), (LastY - LastRectY));

        if (Properties.Settings.Default.ShiftLoot)
            SendKeyboardAction(16, keyState.KEYDOWN);

        SendNotifyMessage(Wow, WM_RBUTTONDOWN, (UIntPtr)1, (IntPtr)dWord);
        Thread.Sleep(100);
        SendNotifyMessage(Wow, WM_RBUTTONUP, (UIntPtr)1, (IntPtr)dWord);

        if (Properties.Settings.Default.ShiftLoot)
            SendKeyboardAction(16, keyState.KEYUP);

}

public static Rectangle GetWowRectangle()
{
IntPtr Wow = FindWindow("GxWindowClass", Properties.Settings.Default.ProcName);
Rect Win32ApiRect = new Rect();
GetWindowRect(Wow, ref Win32ApiRect);
Rectangle myRect = new Rectangle();
myRect.X = Win32ApiRect.Left;
myRect.Y = Win32ApiRect.Top;
myRect.Width = (Win32ApiRect.Right - Win32ApiRect.Left);
myRect.Height = (Win32ApiRect.Bottom - Win32ApiRect.Top);
return myRect;
}

from ultimatefishbot.

That requires adding more configuration fields as well. I might do that later, but did the file work or not?

from ultimatefishbot.