No Int Int listener? about unity-atoms HOT 7 CLOSED

Hey, so sorry I didnt respond here, for some reason I didnt get notifications of this, im happy with those bits just being added but if you wish to make it more flexible in the future I cannot see a downside to that.

from unity-atoms.

I'm pretty sure this is an oversight. probably because Ints and Floats where created before the Generation stuff was written and before x2 events/listeners where introduced.

There are missing x2 listeners for:

Bool, Collider2D (has no x2 event, too), Color, Float, GameObject, Int, Vector2, Vector3, Void.

There are x2 listeners:

String, TouchUserInput

It should be possible to write a Test that covers, that for each Event-Type there is also an Listener-Type

from unity-atoms.

Thanks for submitting the issue!

This has been overlooked. Will be continue working on the generator this weekend, so all the missing ones will be added to the canary branch.

Would you consider it useful if the generator was able to generate atoms that are of different types? Eg. IntStringListener or FloatIntEvent?

from unity-atoms.

Would you consider it useful if the generator was able to generate atoms that are of different types? Eg. IntStringListener or FloatIntEvent?

since those x2 events are usually used for "ChangedWithHistory"-events on a variable, and because there are a lot of combinations possible (IntString, StringInt ?) and if needed those classes can be created by the library user for the types needed. I'd vote against adding all those combinations

from unity-atoms.

Maybe I was unclear in my question :) I totally agree that we should not add all of them to the project, however do we think it would be helpful to add the possibility to be able to generate those via the code generator when needed?

from unity-atoms.

IntIntListener was added in cb20008

from unity-atoms.

@grofit Thanks! Will create a new issue regarding expanding the generator!

from unity-atoms.