External Dependencies in development branches about unity-atoms HOT 11 CLOSED

Thanks for submitting this issue!

What version of Unity are you running and how are you importing the Unity Atoms? I would also like to see an image of your folder structure in your Packages folder, in Unity's Project tab.

For me it works just fine to do this in my manifest.json:

"com.mambojambostudios.unity-atoms": "https://github.com/AdamRamberg/unity-atoms.git#canary",

I'm running Unity 2019.1.0f2 and UniRx is not included.

The idea is that UniRx is not going to be included in the library, only in the Examples project in the Github repo. The root package.json's files attribute should just point to the packages folder and thereby not include any of the examples. It doesn't seem to work for you though, so I'm thinking that this might not work on older versions of UPM.

from unity-atoms.

I've found the same UniRx issue within the examples. I'll provide a fix within the next days, where the UniRx examples won't throw errors when UniRx is missing, and will compile when UniRx is present

but i clones the project, and did not include it as package. so my fix is only meant for contributors who are not interested in UniRx

from unity-atoms.

@soraphis Do you get this when you are cloning the repo and running the Examples project or do you get it when you add unity-atoms as a dependency in your project via Git URL?

from unity-atoms.

@soraphis Do you get this when you are cloning the repo and running the Examples project

cloning the repo to work on it. the examples throw the error that UniRx is missing. I have not tested it as a package dependecy yet. I'll be at home tomorrow, will look into this a bit more then.

from unity-atoms.

That is really weird. Can't UPM resolve the UniRx dependency? How is your Packages folder structured / looking?

from unity-atoms.

That is really weird. Can't UPM resolve the UniRx dependency? How is your Packages folder structured / looking?

Probably totally different as yours:

<unity project root>
 ├ Assets <git root>
 │ ├ Examples
 │ │ └ ...
 │ ├ Packages
 │ │ ├ Core
 │ │ └ ...
 │ └ ...
 └ ...

since unirx is defined somewhere inside examples it will not be resolved. but this way i've all of the project together (and everything lives within unity, and not outside of it)

from unity-atoms.

Should UPM solve the dependencies for a project that was just added as a submodule for the other one? That's what I am doing specifically.

from unity-atoms.

@soraphis Do you have a local copy of the new unity atoms repo that you are referring to in another project? I know that UPM doesn't use the files attribute in the package.json when using the file: syntax in your manifest.json. Or are you just dropping the full package into a new Unity project? Don't really understand otherwise. The idea is that when you are working on Unity Atoms that you open the Examples folder as a Unity project. If you want to use Unity Atoms in another Unity project you should add it according to the docs (the README.md in the master branch is out dated): https://adamramberg.github.io/unity-atoms/introduction/quick-start

@mutmedia If you are using the Git URL approach described in the quick start link above then UPM should just include the folders that are specified in the files attribute in the root package.json (and its subdirectories / subfiles). If you are using the NPM approach (also from the quicj start link above) then those packages are basically just the folders in the Packages folder, so in that case it is really weird that you get errors regarding UniRx since it is only included in the Examples Unity project. If any of the approaches above doesn't work for you it would be really helpful if you can provide an example repo where you get this problem so that I can take a look.

from unity-atoms.

@AdamRamberg yes, i have the whole unity-atoms repo within a unity project. I've always had it like that and it works quite well.

from unity-atoms.

@soraphis Alright, so that is not the intention of the repo structure. However, if you really want to keep this setup you could add the UniRx dependency to your wrapping project's manifest.json like this:
"com.neuecc.unirx": "https://github.com/starikcetin/UniRx.git#7.1.0-upm",

@mutmedia Did the quick start guide solve your issue?

from unity-atoms.

Closing this issue due to inactivity. In my mind this issue is solved, reopen if you are of another opinion.

from unity-atoms.