Giter VIP home page Giter VIP logo

Comments (14)

holroy avatar holroy commented on June 19, 2024 2

@josephgarnier , that is indeed very wrong. Something strange has happened in one of the last updates. Neither response is correct when in live preview did that query.

This surely needs more attention and investigation.

from obsidian-dataview.

josephgarnier avatar josephgarnier commented on June 19, 2024 1

I can confirm a similar bug that occurred recently. For my test, I disabled all community plugins, except Obsidian DataView.

When I write $= dv.list(dv.pages()), the Live Preview mode displays <Promise>, while a Reading mode works well.

from obsidian-dataview.

GottZ avatar GottZ commented on June 19, 2024 1

tomorrow I'm back in my usual debug environment and will try to fix this.

from obsidian-dataview.

holroy avatar holroy commented on June 19, 2024 1

In other words, the code is going to be unstable for a version of two while working out those kinks? This should then possibly have not been a minor version raise , aka from 0.5.65 to 0.5.66, but rather have gone to something like 0.6.0. This change has caused breakage in many vaults, without been given a proper warning.

This change, alongside with that strange(?) live preview changes/bug in #2216, have broken two of the main use cases in my personal vault so I'm having issues on how to proceed.

And I guess the tests should possibly be extended to catch either of these

from obsidian-dataview.

GottZ avatar GottZ commented on June 19, 2024

can confirm. inline seems to be broken somewhat.

from obsidian-dataview.

pierremouchan avatar pierremouchan commented on June 19, 2024

For me, the issue was coming from the latest iconize version, I had to disable the plugin to make them work again.

from obsidian-dataview.

GottZ avatar GottZ commented on June 19, 2024

true but still. I'm not using iconize and have noticed a hard to reproduce related bug with inline queries.

from obsidian-dataview.

holroy avatar holroy commented on June 19, 2024

In my case it triggers immediately when I add await ... in front of the dv.view() called. So I guess it's related to some asynchronous issue. And no I don't have Iconize plugin installed, so that is not part of my use case. (In either case, I triggered this bug in the Sandbox vault with no other plugins except Dataview.

from obsidian-dataview.

holroy avatar holroy commented on June 19, 2024

@josephgarnier , neither dv.list() nor dv.pages() by themselves should produce a promise. What else do you do in that query?

In general whenever you get a <promise> return you'll need to add await in front of that call. In your case you might need to use Promise.all().

In any case a promise is not a bug, but when/if the result disappear after adding the await then that's a bug.

from obsidian-dataview.

josephgarnier avatar josephgarnier commented on June 19, 2024

@holroy Just to check, I've just tested a new vault with all default settings and only the "dataview" community plugin. As you can see on the screen below, the instruction $= dv.list(dv.pages()) is displayed <promise> in Live Preview mode only, whereas in Reading mode the instruction works. Furthermore, there are no errors in the console.

Live Preview mode :
image

Reading mode :
image

Now, with the $= await dv.list(dv.pages()) instruction, the display changes, but the result is not as expected: there is no list of files, only one item :

image

edit : actually, the problem persists even with all core plugins deactivated.

from obsidian-dataview.

holroy avatar holroy commented on June 19, 2024

Do you have any idea what causes this, @GottZ ?

from obsidian-dataview.

GottZ avatar GottZ commented on June 19, 2024

Increasing the compile target to es2022 might have broken code with bad structure. it also broke that server version check earlier.

I got confirmation from an obsidian employee, that es2022 is the correct target these days tho.

I suspect I'll have to do a little housekeeping and re-implenent a few pieces here and there to make sure the code is up to current standards.

from obsidian-dataview.

AB1908 avatar AB1908 commented on June 19, 2024

@GottZ should we roll back to previous stable version while we explore fix in beta release?

from obsidian-dataview.

holroy avatar holroy commented on June 19, 2024

@GottZ should we roll back to previous stable version while we explore fix in beta release?

If we go down that route, which I'm in favor of, should we then also include all the stuff related to #2216 since there isn't any easy fix to that issue, and since it's not very clear which issue was resolved introducing that code at all?

from obsidian-dataview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.