joshdick / onedark.vim Goto Github PK

Hi,

First, congrats for this color scheme!

I am getting a grey background, any idea why?

https://www.dropbox.com/s/f0cefosv3w4lff6/Screenshot%202016-01-14%2017.35.00.png?dl=0

Thanks!

I run into this problem a few times:

It's hard to tell at first glance where my code and the autocomplete end. Atom gets round this with a drop shadow. Maybe a slightly lighter shade could be used on the autocomplete background?

Hi,

This my environment:

• macOS sierra 10.12.1

• iterm2 3.0.13 - with xterm-256color and onedark-256 itermcolor

• tmux 2.3 (with true color, checked with "tmux info | grep Tc"

• nvim 0.1.7

Here is ~/.vimrc (the part which is related to the colors):

set t_Co=256
let g:rehash256 = 1
let g:onedark_termcolors=256

set background=dark
colorscheme onedark

and in tmux I see those colors:

Outside of tmux it works.

Is this tmux issue? if so what's the specific issue?

Hi,

Would like to request assigning Operator a color too. My preference would be the same color as that of Conditional.

Thanks

Thanks a lot for this plugin. I can now switch back to vim 😄

I've just set it up and have been having some odd inconsistencies.

• Colors in lightline (Terminal Vim)
  
  Mine looks like the above but I don't think this is what it should look like

• Colors in lightline (MacVim)
  
  I have the same settings in my .gvimrc but the default solarised theme doesn't seem to want to be changed from solarised.

• Nerdtree colors
  Yet another color issue I cant figure out. I woul dhave expected it to match ba78df2

It seems like only let g:onedark_terminal_italics=1 before colorscheme onedark could not make it become Italics. I also added below gists in .vimrc and turn on Iterm2 italics supports using this gists.

let &t_ZH="\e[3m"
let &t_ZR="\e[23m"

My vim configuration lists here.

Hey again! Long time no see :)

So I use nerdtree, which colors directories blue and executables red. But not with onedark.

Ideas?

Hey,
I've created a onedark theme, tmux-onedark-theme, based on the work you did.
Do you mind adding a comment about it in your readme?

Is there anyway to highlight whatever tab is open within vim?

What it looks like now:

Ideally I could see something like this (with your color scheme ofc):

Put airline theme into this repository, Vundle will install it automatically.

I found that the colorscheme is not showing as the example found here http://vimcolors.com/354/onedark/dark the color scheme is actually looking like this http://i.imgur.com/Q5wQbaO.png?1

i'm using neovim and starting it with NVIM_TUI_ENABLE_TRUE_COLOR=1 nvim wich enables true colors.

Use gvim or nvim, this problem is existing!

Just wondering why these are all set to grey.

Using the GitGutter colours looks pretty good.

I really like these colors (better than the current atom onedark theme). It would be great to have an atom version. :-)

I know that this repo is called oneDARK... but could you provide an option for a light background?

When using Rainbow parens, the matching paren is hard to see because of color reuse. How do I set it as Bold ?

What do you think about moving the airline theme into this repository? In the past I've found it very useful to be able to switch to the airline theme without installing another plugin.

Example themes:

• https://github.com/whatyouhide/vim-gotham
• https://github.com/rakr/vim-two-firewatch

I expect it will make maintenance much easier especially if we added a lightline theme.

It would be great if the comments in a git commit message could use the same dark grey as code files.

As you can see, it makes reading a bit difficult. Thanks.

The split delimiter line of | symbols is black, and thus hardly visible.

I've been using solarized-dark for a while, but I really like the colors in this theme. One problem I have though is that some languages have much less color (especially for symbols) using onedark instead of solarized. I'll just post some screenshots. The two main ones for me are the arrows (->) and symbols (<<<, ., etc) in PureScript and the symbols in JavaScript (const, =, &&, etc).

(FWIW, I find Atom's PureScript highlighting to be a bit odd (good for types, bad for code and imports) and way too colorful for JavaScript)

Solarized, PureScript:

Onedark, PureScript:

Solarized, JavaScript:

Onedark, JavaScript:

Atom, PureScript:

Atom, JavaScript:

And thanks for working on this theme, it's the best I've tried so far!

Would you consider adding an option for italic HTML attribute names? I tried adding highlight htmlArg cterm=italic to my VIMRC but it didn't work.

There are a lot of issues opened around incorrect colours that can usually be answered in the README. Should we consider adding a template to direct users there in case they missed it?

We could also request the relevant vimrc settings

Hi,

Would like to request assigning a color for the selected wildmenu entry.

Thanks and Cheers!

Seems like the vim theme works well using mvim, however, the colors seem off when using vim 7.4 within iterm and terminal app. Any thoughts? Screen capture depicts vim+iTerm on left and mvim on right.

When using onedark, the incremental search results aren't highlighted, making it impossible to use the incsearch feature.

Steps to reproduce:

1. Edit a file with some text in it.
2. :set incsearch
3. / and start typing something in the file.

Hi,

I really like your theme! Great job! One tiny nitpick I have, however, is the way the separator for vertical splits is colored. I find the black a bit too strong. I played around a bit with the colors and found that using s:cursor_grey instead of s:vertsplit looks much less obtrusive. I've attached a screenshot. Is this something you would be willing to change?

The cursor is hardly visible when writing new code. Please consider increasing the contrast a bit.

The tmux block in the README doesn't help things. Using minimal configs for both.

$ brew info tmux
tmux: stable 2.2 (bottled), HEAD

$ vim --version
VIM - Vi IMproved 7.4 (2013 Aug 10, compiled May 27 2016 20:19:09)

Hi!

First off, awesome theme, nicely done!

Second, once I enable this, sadly, my PowerShell syntax highlighting is completely gone. It just displays it as plain text. Other custom themes are also gone, like Dockerfile and Go. I suspect because on the first line, you are resetting syntax.

Can we do something about that? Can I somehow override for certain filetypes? What's the best way of solving this?

Cheers,
Gergely.

Hi,

Beautiful theme.
I am using it with neovim inside tmux. I set my colorcolumn as well. But I cant see it highlight-ed to cursor_grey. hitest doesnt show any color for it as well.
I have tried using a different color hi ColorColumn ctermbg=black for example but it doesnt seem to work.

Any pointers?

Great theme, thanks!

When I highlight a word that is commented out, the text is not legible :(

I'm getting the following error when starting Macvim and using this color scheme.

I get the same error when trying use it in Neovim (just different line numbers)

I do not get these errors with other color schemes.

It seems to load fine after I hit enter, it's just annoying to get them every time I open vim.

I previously thought this may be happening because my tmux didn't have TrueColor support enabled properly. I resolved my tmux TrueColor issue tmux/tmux#696, but my vim colors still do not match:

Relevant vimrc

if &term =~ '256color'
    " disable background color erase
    set t_ut=
endif

" enable 24 bit color support if supported
if (empty($TMUX) && has("termguicolors"))
    set termguicolors
endif

let g:onedark_termcolors=256
let g:onedark_terminal_italics=1

syntax on
set t_Co=256                  " Explicitly tell vim that the terminal supports 256 colors
set background=dark           " Enable dark background
colorscheme onedark           " Set the colorscheme

NeoVim Version

⇨ nvim --version
NVIM 0.1.7
Build type: RelWithDebInfo
Compilation: /usr/local/Homebrew/Library/Homebrew/shims/super/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -I/tmp/neovim-20161130-73384-ctpyvy/neovim-0.1.7/build/config -I/tmp/neovim-20161130-73384-ctpyvy/neovim-0.1.7/src -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/include -I/usr/local/opt/gettext/include -I/usr/include -I/usr/include -I/tmp/neovim-20161130-73384-ctpyvy/neovim-0.1.7/build/src/nvim/auto -I/tmp/neovim-20161130-73384-ctpyvy/neovim-0.1.7/build/include
Compiled by [email protected]

Optional features included (+) or not (-): +acl   +iconv    -jemalloc +tui
For differences from Vim, see :help vim-differences

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/usr/local/Cellar/neovim/0.1.7/share/nvim"

Screenshot

Left: iTerm > tmux > nvim
Right: iTerm > nvim

Noticeable Problems:

• Background color doesn't match. Background color of nvim running within tmux has a darker tone
• Normally all colors look more contrasted (colors on left eg: pink, red, etc. are darker inside tmux

Hi Team:
I realy like onedark and it could be the best vim theme I have ever tried. I get some problems recently.

I use vimdiff to compare the staged/unstaged files, and it really pains a lot to tell the difference.
you may take a look into the screenshot attached. Can we somehow highlighting the difference?

Might be a nice touch to add support for the built in terminal in neovim. As seen here - https://github.com/chriskempson/base16-builder/pull/346

How do I disable italic comment
I tried doing

let g:onedark_terminal_italics=0
colorscheme onedark

which is not working.
Using it with neovim.

I installed the scheme with iTerm2 and MacVim. In GVim it works well. However, it don't work in iTerm2 as it should.
Here's the relevant code in ~/.vimrc

" Basics
set nocompatible " get out of horrible vi-compatible mode [Vundle required]
filetype off " [Vundle required]
set encoding=utf-8

" Font
set guifont=PragmataPro\ for\ Powerline:h16

" Scheme
syntax on " syntax highlighting on
set t_Co=256
set background=dark
colorscheme onedark
let g:onedark_termcolors=256
let g:onedark_terminal_italics=1

When I use the onedark airline theme, I don't see the expected [Syntax: line:xx in the status line for syntax errors. Below is a minimal vimrc (using Vim 8.0 with packages to install both onedark and syntastic at startup) that shows the issue. Comment out colorscheme onedark to default to the current theme and show the syntastic error part of the status line again.

" onedark
if (has("termguicolors"))
  set termguicolors
endif
colorscheme onedark

" syntastic
let g:syntastic_always_populate_loc_list = 1
let g:syntastic_check_on_open = 1
let g:syntastic_check_on_wq = 0

Screenshots are taken while looking at the same file with one syntastic error.

Thanks for this scheme, I'm a big fan! Just curious if I'm missing something obvious.

hi

I work with vim.

so far, I use terminal.

but I use tmux.

one dark syntax high light is not working.

why?

.vimrc

let g:onedark_termcolors=16

screenshot with terminal

screenshot with tmux

So I installed onedark for iTerm2 and Vim as well. But it doesn't look right when I am using Vim in iTerm2 or even system terminal. Though it looks fine in MacVim.

As you can see, theme looks great in MacVim, great in iTerm but not so when Vim is opened inside iTerm

Hi.

Thanks for your work. I started using it from neovim in terminal.

The only thing that I've trouble with is missing highlightning matching parens, square bracket etc.
If I change the colorscheme to another schema - its starts working again..

I have installed the following syntax plugins, it has no effect toggling rainbows_parentheses

Plug 'guns/vim-clojure-highlight', { 'for': 'clojure' }
Plug 'guns/vim-clojure-static', { 'for': 'clojure' }
Plug 'junegunn/rainbow_parentheses.vim'

Cheers

Hey man.

I wondered if you could help me with this. Suddenly, my onedark colorscheme is no longer getting loaded. I can load it manually with :colorscheme onedark, but only after I load something different, like monokai.

I have no idea why this started to happen all of a sudden.

Here is my ./vimrc => https://github.com/Skarlso/devops/blob/master/vimrc

I switched it to syntax on and after that colorscheme, but it didn't work either.

Here is an output of :scriptnames:

  1: /usr/share/vim/vimrc
  2: /usr/share/vim/vim74/debian.vim
  3: /usr/share/vim/vim74/syntax/syntax.vim
  4: /usr/share/vim/vim74/syntax/synload.vim
  5: /usr/share/vim/vim74/syntax/syncolor.vim
  6: /usr/share/vim/vim74/filetype.vim
  7: ~/.vimrc
  8: /usr/share/vim/vim74/ftoff.vim
  9: ~/.vim/bundle/Vundle.vim/autoload/vundle.vim
 10: ~/.vim/bundle/Vundle.vim/autoload/vundle/config.vim
 11: ~/.vim/bundle/vim-go/ftdetect/gofiletype.vim
 12: ~/.vim/bundle/vim-ps1/ftdetect/ps1.vim
 13: ~/.vim/bundle/vim-ps1/ftdetect/ps1xml.vim
 14: ~/.vim/bundle/Dockerfile.vim/ftdetect/Dockerfile.vim
 15: ~/.vim/bundle/plaintasks.vim/ftdetect/plaintasks.vim
 16: /usr/share/vim/vim74/ftplugin.vim
 17: /usr/share/vim/vim74/indent.vim
 18: ~/.vim/colors/monokai.vim
 19: /usr/share/vim/vim74/syntax/nosyntax.vim
 20: ~/.vim/bundle/nerdtree/plugin/NERD_tree.vim
 21: ~/.vim/bundle/nerdtree/autoload/nerdtree.vim
 22: ~/.vim/bundle/nerdtree/lib/nerdtree/path.vim
 23: ~/.vim/bundle/nerdtree/lib/nerdtree/menu_controller.vim
 24: ~/.vim/bundle/nerdtree/lib/nerdtree/menu_item.vim
 25: ~/.vim/bundle/nerdtree/lib/nerdtree/key_map.vim
 26: ~/.vim/bundle/nerdtree/lib/nerdtree/bookmark.vim
 27: ~/.vim/bundle/nerdtree/lib/nerdtree/tree_file_node.vim
 28: ~/.vim/bundle/nerdtree/lib/nerdtree/tree_dir_node.vim
 29: ~/.vim/bundle/nerdtree/lib/nerdtree/opener.vim
 30: ~/.vim/bundle/nerdtree/lib/nerdtree/creator.vim
 31: ~/.vim/bundle/nerdtree/lib/nerdtree/flag_set.vim
 32: ~/.vim/bundle/nerdtree/lib/nerdtree/nerdtree.vim
 33: ~/.vim/bundle/nerdtree/lib/nerdtree/ui.vim
 34: ~/.vim/bundle/nerdtree/lib/nerdtree/event.vim
 35: ~/.vim/bundle/nerdtree/lib/nerdtree/notifier.vim
 36: ~/.vim/bundle/nerdtree/autoload/nerdtree/ui_glue.vim
 37: ~/.vim/bundle/nerdtree/nerdtree_plugin/exec_menuitem.vim
 38: ~/.vim/bundle/nerdtree/nerdtree_plugin/fs_menu.vim
 39: ~/.vim/bundle/vim-nerdtree-tabs/nerdtree_plugin/vim-nerdtree-tabs.vim
 40: ~/.vim/bundle/vim-fugitive/plugin/fugitive.vim
 41: ~/.vim/bundle/vim-go/plugin/go.vim
 42: ~/.vim/bundle/YouCompleteMe/plugin/youcompleteme.vim
 43: ~/.vim/bundle/syntastic/plugin/syntastic/autoloclist.vim
 44: ~/.vim/bundle/syntastic/plugin/syntastic/balloons.vim
 45: ~/.vim/bundle/syntastic/plugin/syntastic/checker.vim
 46: ~/.vim/bundle/syntastic/plugin/syntastic/cursor.vim
 47: ~/.vim/bundle/syntastic/plugin/syntastic/highlighting.vim
 48: ~/.vim/bundle/syntastic/plugin/syntastic/loclist.vim
 49: ~/.vim/bundle/syntastic/plugin/syntastic/modemap.vim
 50: ~/.vim/bundle/syntastic/plugin/syntastic/notifiers.vim
 51: ~/.vim/bundle/syntastic/plugin/syntastic/registry.vim
 52: ~/.vim/bundle/syntastic/plugin/syntastic/signs.vim
 53: ~/.vim/bundle/syntastic/plugin/syntastic.vim
 54: ~/.vim/bundle/syntastic/autoload/syntastic/log.vim
 55: ~/.vim/bundle/syntastic/autoload/syntastic/util.vim
 56: ~/.vim/bundle/vim-airline/plugin/airline.vim
 57: ~/.vim/bundle/vim-airline/autoload/airline.vim
 58: ~/.vim/bundle/vim-airline/autoload/airline/init.vim
 59: ~/.vim/bundle/vim-airline/autoload/airline/parts.vim
 60: ~/.vim/bundle/svndiff/plugin/svndiff.vim
 61: /usr/share/vim/vim74/plugin/getscriptPlugin.vim
 62: /usr/share/vim/vim74/plugin/gzip.vim
 63: /usr/share/vim/vim74/plugin/matchparen.vim
 64: /usr/share/vim/vim74/plugin/netrwPlugin.vim
 65: /usr/share/vim/vim74/plugin/rrhelper.vim
 66: /usr/share/vim/vim74/plugin/spellfile.vim
 67: /usr/share/vim/vim74/plugin/tarPlugin.vim
 68: /usr/share/vim/vim74/plugin/tohtml.vim
 69: /usr/share/vim/vim74/plugin/vimballPlugin.vim
 70: /usr/share/vim/vim74/plugin/zipPlugin.vim
 71: ~/.vim/bundle/vim-airline/autoload/airline/extensions.vim
 72: ~/.vim/bundle/vim-airline/autoload/airline/extensions/quickfix.vim
 73: ~/.vim/bundle/vim-airline/autoload/airline/extensions/netrw.vim
 74: ~/.vim/bundle/vim-airline/autoload/airline/extensions/branch.vim
 75: ~/.vim/bundle/vim-airline/autoload/airline/extensions/syntastic.vim
 76: ~/.vim/bundle/vim-airline/autoload/airline/extensions/whitespace.vim
 77: ~/.vim/bundle/vim-airline/autoload/airline/extensions/wordcount.vim
 78: ~/.vim/bundle/vim-airline/autoload/airline/section.vim
 79: ~/.vim/bundle/vim-airline/autoload/airline/highlighter.vim
 80: ~/.vim/bundle/vim-airline/autoload/airline/themes/molokai.vim
 81: ~/.vim/bundle/vim-airline/autoload/airline/themes.vim
 82: ~/.vim/bundle/vim-airline/autoload/airline/util.vim
 83: ~/.vim/bundle/vim-airline/autoload/airline/builder.vim
 84: ~/.vim/bundle/vim-airline/autoload/airline/extensions/default.vim
 85: ~/.vim/bundle/nerdtree/syntax/nerdtree.vim
 86: ~/.vim/bundle/YouCompleteMe/autoload/youcompleteme.vim
 87: ~/.vim/bundle/vim-airline/autoload/airline/deprecation.vim

Thanks for any insight you could provide!!

Additions should be green not red, removals should be red not blue.

Hi @joshdick ,

I use SearchParty and one of its features is to use IncSearch and highlight the occurrence under the cursor using the inverted colorscheme of the Syntax group the word belongs to.

This gets overridden when hl-IncSearch is explicitly defined, as is the case here. If you dont see this as a deal breaker, I would request removing (or temporarily commenting it out).

Alternatively, you could use a flag for the user to set/reset this hl group.

Cheers

First of all I want to say that this theme is great and my favourite, really good work. 👍
Are you going to support flow syntax? It would be really nice. This is how it looks now:

I'm using the standard gnome-terminal on Ubuntu 16.04 and unless I'm wrong, this should support the truecolor-mode. I applied the install instructions to my vimrc, here it is:

" All system-wide defaults are set in $VIMRUNTIME/debian.vim and sourced by
" the call to :runtime you can find below.  If you wish to change any of those
" settings, you should do it in this file (/etc/vim/vimrc), since debian.vim
" will be overwritten everytime an upgrade of the vim packages is performed.
" It is recommended to make changes after sourcing debian.vim since it alters
" the value of the 'compatible' option.

" This line should not be removed as it ensures that various options are
" properly set to work with the Vim-related packages available in Debian.
runtime! debian.vim

" Uncomment the next line to make Vim more Vi-compatible
" NOTE: debian.vim sets 'nocompatible'.  Setting 'compatible' changes numerous
" options, so any other options should be set AFTER setting 'compatible'.
"set compatible

" Vim5 and later versions support syntax highlighting. Uncommenting the next
" line enables syntax highlighting by default.
if has("syntax")
  syntax on
endif

" If using a dark background within the editing area and syntax highlighting
" turn on this option as well
"set background=dark

" Uncomment the following to have Vim jump to the last position when
" reopening a file
"if has("autocmd")
"  au BufReadPost * if line("'\"") > 1 && line("'\"") <= line("$") | exe "normal! g'\"" | endif
"endif

" Uncomment the following to have Vim load indentation rules and plugins
" according to the detected filetype.
"if has("autocmd")
"  filetype plugin indent on
"endif

" The following are commented out as they cause vim to behave a lot
" differently from regular Vi. They are highly recommended though.
"set showcmd		" Show (partial) command in status line.
"set showmatch		" Show matching brackets.
"set ignorecase		" Do case insensitive matching
"set smartcase		" Do smart case matching
"set incsearch		" Incremental search
"set autowrite		" Automatically save before commands like :next and :make
"set hidden		" Hide buffers when they are abandoned
"set mouse=a		" Enable mouse usage (all modes)

" Source a global configuration file if available
if filereadable("/etc/vim/vimrc.local")
  source /etc/vim/vimrc.local
endif

" Set ESC-key to jk
inoremap jk <ESC>

"remap leader key to Space
let mapleader ="\<Space>"

filetype plugin indent on

"Use 24-bit (true-color) mode in Vim/Neovim when outside tmux.
"If you're using tmux version 2.2 or later, you can remove the outermost $TMUX check and use tmux's 24-bit color support
"(see < http://sunaku.github.io/tmux-24bit-color.html#usage > for more information.)
if (empty($TMUX))
  if (has("nvim"))
    "For Neovim 0.1.3 and 0.1.4 < https://github.com/neovim/neovim/pull/2198 >
    let $NVIM_TUI_ENABLE_TRUE_COLOR=1
  endif
  "For Neovim > 0.1.5 and Vim > patch 7.4.1799 < https://github.com/vim/vim/commit/61be73bb0f965a895bfb064ea3e55476ac175162 >
  "Based on Vim patch 7.4.1770 (`guicolors` option) < https://github.com/vim/vim/commit/8a633e3427b47286869aa4b96f2bfc1fe65b25cd >
  " < https://github.com/neovim/neovim/wiki/Following-HEAD#20160511 >
  if (has("termguicolors"))
    set termguicolors
  endif
endif

set encoding=utf-8
execute pathogen#infect()

syntax on
colorscheme onedark
set background=dark

I also copied onedark.vim into the colors folders as instructed. Still, the colors are all wrong compared to atom:

Local

• VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jun 16 2016 14:20:57)
• echo $TERM; // xterm-256color

SSH

• VIM - Vi IMproved 7.4 (2013 Aug 10, compiled Jul 24 2015 02:23:23)
• echo $TERM; // xterm-256color

It seems like only the background color is slightly different over ssh then in my local vim..
any ideas what might be causing this?

I noticed after 5640329 that my Git commit coloring appeared a bit off. In particular, comments and regular text are the same color. While I primarily use neovim + iterm2 (and the associated onedark themes), I notice the same issue with regular vim and a minimal vimrc. For example:

However, tweaking the Git highlighting to use s:comment_grey where previously no color was specified, such as:

call s:h("gitcommitComment", {"fg": s:comment_grey })
call s:h("gitcommitUnmerged", { "fg": s:green })
call s:h("gitcommitOnBranch", { "fg": s:comment_grey })
call s:h("gitcommitBranch", { "fg": s:purple })
call s:h("gitcommitDiscardedType", { "fg": s:red })
call s:h("gitcommitSelectedType", { "fg": s:green })
call s:h("gitcommitHeader", { "fg": s:comment_grey })
call s:h("gitcommitUntrackedFile", { "fg": s:cyan })
call s:h("gitcommitDiscardedFile", { "fg": s:red })
call s:h("gitcommitSelectedFile", { "fg": s:green })
call s:h("gitcommitUnmergedFile", { "fg": s:yellow })
call s:h("gitcommitFile", { "fg": s:comment_grey })

results in something more like what I would expect:

I'm not entirely sure what colors were intended for git commits, or how the above modification affects other configurations, or whether this is an issue with the color scheme or simply my personal configs.

In vim the background is a nice dark gray, but in my terminal it looks like a very dark navy. Have you encountered this issue before?