manshar / manshar Goto Github PK

While i was adding a new Article . i tried to attache a picture between the line
but it gave me some JS Errors and the Form sometimes Popups, sometimes not.

I am using : Ubuntu - Chrome Version 42.0.2311.135 (64-bit)
Picture attached.

The web-client is full separated. why I have to setup local backend, just wanna to contribute to the web-cient-app. this issue blocking me from contributing since three months every time I'm trying I got tired of backend setup and loose my passion.

Can you guys separate the contribution instructions to backend and web-client ?

Unless you are ok with personal pictures being used against the will of the owner for example :).

It would be nice to have RSS/Atom feed for the website, say, for the latest, the best, etc. and also for categories. and (maybe in the future) for the users.

Tried Manshar on mobile (iPhone5), and noticed these issues (I'll work on them):

• Listing types nav elements disappear behind the logo
• When I scroll and the types nav stick at top, I couldn't open the profile menu
• Articles with title more than 2 lines, or long slogan in home page crashing the style!
• I wrote my bio, checked my profile can't see my name. If bio is more then 3 lines I won't be able to read it
• In contributors page, names with 3 lines
• In صحة ورياضة category, the third topic is: img src=x><"<(onerror=alert(1

Let me know if you have any suggestions for the above issues.

Thanks,

If it'd be bigger than it now I think it's gonna be better :)

That's what I get whenever I click the Facebook share button:

The same thing happens with the G+ button

I'm trying to save article to pocket but unfortunately it's not compatible.

The current contributing guidelines reflect the old structure of the app. The current structure (2 separate apps for backend/ and web-client) need to be documented better in the contributing guidelines.

Bad behavior, recommendation button works on drafts.

I think it'll be better if the container goes to right and not to be centered like this in the page.

Writing a new blog title in Manshar can be styled !

I've got this error while establishing the rails s command.
/home/ahmgeek/.rvm/gems/ruby-2.2.2/gems/fog-1.27.0/lib/fog/openstack/volume.rb:191: warning: duplicated key at line 196 ignored: :openstack_region.
it's related to this I guess.

In the last days I was thinking about manshar structure.
Why manshar does not use Angular in Rails directly?
I can not get a good answer. So can someone explain to me why you guys did that

Critical security issue for Rails 4.0.1: http://seclists.org/oss-sec/2013/q4/400

• While the article is loading, that's what I see,
  

Currently we don't do any optimizing for returning smaller images instead we return the original uploaded image. Manshar need to optimize for slow connections by returning thumbnails in list view and return properly sized and optimized images when needed.

Should I be redirected to the home page after deleting a draft ?
ref: _manshar/web-client/app/scripts/controllers/profileController.js_

var deleteSuccess = function () {
  $analytics.eventTrack('Article Deleted', {
       category: 'Article'
     });
     $location.path('/');
   };

• Navigation keys scrolling is not working in any article page or the home page. I can scroll up/down using the mouse only!
  [Edit] I have to click inside the page to control it using navigation keys, otherwise, it don't work.

We can use a ribbon or just a small word that says "Tajribi".

People have been having troubles using Manshar on Firefox. I only have been testing the work on Chrome, this bug is to track the basic support of Manshar for Firefox browser.

Hi,

When I navigate to https://www.manshar.com/articles/new/ I get a blank page with a javascript error that says: Cannot transition to abstract state 'app'.

I should say, I'm not logged in, so maybe that's why; but a login page should show up instead of a blank page.

Here are the steps to reproduce this error:

• Open up an incognito window (Ctrl + shift + N) -- this is to make sure you're not signed in
• Go to: https://www.manshar.com/articles/new/

The first time I noticed this is was when I clicked on the link "اكتب مقال الان" from the side menshar.org

Let me know if you need any more details.

Thanks
Hady

As described in the Manshar Code Structure document, all frontend and static resources should love in web-client/ folder. Please remove all the the frontend setup files from the rails app. Rails app should only be used to implement API endpoints.

If the user is using an unsupported browser warn them of the currently supported browsers.

During signing up and submit to http://api.manshar.com/api/v1/registrations.json request fails with Google Chrome.

make the name of the comment author link-able, redirect to author profile.

As indicated in the Login System document. Can we have normal email/password signup/sign in flow?

Examples:

• manshar.com/moradtaleeb instead of manshar.com/profile/4
• manshar.com/article/home-alone instead of manshar.com/article/1456

I think (as a UI designer) the main font is a little bit old fashion and It's gonna be great if it'd be 'Greta' or any new fontface :)

As a followup to #190. highlight.js sometimes break and doesn't highlight code correctly.

Investigate and fix.

Profile image/Bio should not be in the signup form, otherwise users will bounce more oftn before signup.

I would also remove the name (and ask for it afterward), but that's less of an issue.

Also, why not just use Gravatar for profile images?

#article-body contains empty paragraphs (<p>) in some situations. This may cause several problems, including styling ones (adding padding for p's, for example).

As a solution, I would suggest using <br>'s for empty paragraphs, in case the user wanted a blank line.

The problem is present in this article. The cause of this issue may be related to that of #205.

(updated list)

• Recommend button should be at the bottom of the page and not floating.
• Recommend button should be explicitly shows that an article is recommended or not.
• Decrease article container's width.
• Add loading indicator angular-loading-bar?

Words can be broken as separate parts among consecutive lines if there is no space in the original line. This is due to the CSS property word-wrap: break-word, which is applied to the #article-body element.

The problem is: When deleting this property, the text flow gets all weird in some articles (in latest Chrome at least).

I found that the real problem is that text in #article-body uses   (non-breaking space) as a space character in some situations (some paragraphs has 1 or 2, some has none, some are full of).

So, adding that CSS property solves this problem, but breaks other words as well.

A good example article of the whole problem: www.manshar.com/articles/2422.

the size of both files (DroidNaskh-Regular / Bold) is more than 78 KB.
if we used base64, we can decrees the size to 5 KB!
i have done it locally but i am not sure if thats real number (from 78KB to 5KB).
for converting from woff to base64 i used this tool (http://www.fontsquirrel.com/tools/webfont-generator)

• Articles view is not horizontally at the middle of the page.
  Check this photo of the front page:
  

input of upload image, can upload any file from this input so i think need more validation for image extensions

Links doesn't display properly in the comments.

i'm trying to login to manshar using facebook but i got this error message

Long lines in pre tags are trimmed, the you have to zoom out to see the complete line.

Environment: Firefox 36.0.4/Ubuntu

Example:
http://www.manshar.com/articles/509

Issue

Issue after zooming out

In order to keep the web client development as separate as possible from the backend and to make it easy to test quickly without having to run a locale instance of the backend we need to have mock services that returns mock data.

This also will help when writing unit tests.

Dear Manshar Team.

I was trying to Login with my G-Mail ( Google Auth API )
and it gives me empty page with " Redirecting... " with a
Javascript Error " SyntaxError: Unexpected token ILLEGAL "

• New article form: the fields overlap when using Firefox ( FF 35.0.1, Ubuntu 14.04 LTS)
  When I use firefox to create new article, the fields of the form overlap a bit. See the screen-shot:
  http://screencloud.net/v/zS7o
• New article saves a draft always even if I didn't enter any thing.
• Browser back button
  scenario: new article -> click back button -> the url changes to http://www.manshar.com/articles/new, but it keeps coming back to http://www.manshar.com/articles/SOMEID/edit (this also keeps creating new drafts, as mentioned in the previous point)
• http://www.manshar.com/articles/WRONG_ID/edit -> should show not found msg or something like this.
• Go to an article and refresh the browser, the page comes out like this:
  • First, the side menu opens with an empty page, after a bit it closes.
  • Then, the placeholder page appears, which I guess has the template but not the information yet (at this point I can see something like بقلم: غير معروف).
  • After loading, the intended page comes out.
  • %% I guess showing a loading indicator or something like this and not opening the side menu would be more convenient. Or server rendering would be cooler.
• One can notice that to load an article page 12 XHRs are issued (in case the user is logged in) which is too much. I am wondering, why do you need an OPTIONS req for each.

Summary

re-login in manshar after 401 will always redirect the user to the homepage

Scenario

while reading an article on manshar and got distracted for sometime by other natural phenomena ( my daughter ) then continuing to finish reading, when I pressed the "like" I was redirected to the login ( e.g my session ended ) but after I did login, it redirected me to the homepage instead of the article I was at.

Going through the code, I noticed previous path isn't preserved and redirected to upon "unauthorized access" from the $httpProvider interceptor.

Response:
POST http://api.manshar.com/api/v1/articles/205/recommendations 401 (Unauthorized)
No Authorization Token.
Payload {"articleId":205}

content:
{"errors":"Unauthorized."}

// https://github.com/manshar/manshar/blob/master/web-client/app/scripts/app.js#L144
'responseError': function(response) {
        if (response.status === 401) {
          $location.path('/login');
          return $q.reject(response);
        }
        else {
          return $q.reject(response);
        }

Migrating from legacy to container-based infrastructure for faster builds.

Users currently are seeing a lot of slowness in Manshar. We need to do optimizations, some ideas include:

• Properly minimizing JS and CSS code.
• Loading JS code at the bottom of the page.
• Cache API JSON responses on the client side in services.
• Load properly sized images instead of very large images - specially in listing views where all needed is a thumbnail rather than the full image.

I tried to edit my bio, it forced me to change profile photo!

• I see this horizontal scroll bar on Chrome for no reason
  
• Profile picture doesn't load
  
• Manshar Logo in the login page doesn't load
  
• Menu button is not looking good
  

/articles/wrong-id
/articles/wrong-id/edit

Should 404 and show a proper message.